Skip to content

Commit 99a8298

Browse files
authored
fix: Correct the image_url for calling gpt vision (#1004)
1 parent 4b13f13 commit 99a8298

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

code/backend/batch/utilities/helpers/embedders/push_embedder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ def __generate_image_caption(self, source_url):
103103
"text": "Describe this image in detail. Limit the response to 500 words.",
104104
"type": "text",
105105
},
106-
{"image_url": source_url, "type": "image_url"},
106+
{"image_url": {"url": source_url}, "type": "image_url"},
107107
],
108108
},
109109
]

code/backend/batch/utilities/tools/question_answer_tool.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def generate_on_your_data_messages(
137137
[
138138
{
139139
"type": "image_url",
140-
"image_url": image_url,
140+
"image_url": {"url": image_url},
141141
}
142142
for image_url in image_urls
143143
]

code/tests/functional/tests/backend_api/default/test_advanced_image_processing.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ def test_image_urls_included_in_call_to_openai(
266266
"type": "text",
267267
"text": '## Retrieved Documents\n{"retrieved_documents":[{"[doc1]":{"content":"content"}}]}\n\n## User Question\nWhat is the meaning of life?',
268268
},
269-
{"type": "image_url", "image_url": ANY},
269+
{"type": "image_url", "image_url": {"url": ANY}},
270270
],
271271
"role": "user",
272272
},
@@ -286,6 +286,6 @@ def test_image_urls_included_in_call_to_openai(
286286
),
287287
)[0]
288288

289-
assert request.json["messages"][6]["content"][1]["image_url"].startswith(
289+
assert request.json["messages"][6]["content"][1]["image_url"]["url"].startswith(
290290
"https://source"
291291
)

code/tests/functional/tests/functions/advanced_image_processing/test_advanced_image_processing.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ def test_image_passed_to_llm_to_generate_caption(
174174
"text": "Describe this image in detail. Limit the response to 500 words.",
175175
"type": "text",
176176
},
177-
{"image_url": ANY, "type": "image_url"},
177+
{"image_url": {"url": ANY}, "type": "image_url"},
178178
],
179179
},
180180
],
@@ -192,7 +192,7 @@ def test_image_passed_to_llm_to_generate_caption(
192192
),
193193
)[0]
194194

195-
assert request.get_json()["messages"][1]["content"][1]["image_url"].startswith(
195+
assert request.get_json()["messages"][1]["content"][1]["image_url"]["url"].startswith(
196196
f"{app_config.get('AZURE_STORAGE_ACCOUNT_ENDPOINT')}{app_config.get('AZURE_BLOB_CONTAINER_NAME')}/{FILE_NAME}"
197197
)
198198

code/tests/utilities/helpers/test_push_embedder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ def test_embed_file_advanced_image_processing_uses_vision_model_for_captioning(
164164
"text": "Describe this image in detail. Limit the response to 500 words.",
165165
"type": "text",
166166
},
167-
{"image_url": source_url, "type": "image_url"},
167+
{"image_url": {"url": source_url}, "type": "image_url"},
168168
],
169169
},
170170
],

code/tests/utilities/tools/test_question_answer_tool.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ def test_use_advanced_vision_processing(env_helper_mock, llm_helper_mock):
339339
"type": "text",
340340
"text": 'Sources: {"retrieved_documents":[{"[doc1]":{"content":"mock content"}},{"[doc2]":{"content":"mock content 2"}}]}, Question: mock question',
341341
},
342-
{"type": "image_url", "image_url": "mock source 2mock sas"},
342+
{"type": "image_url", "image_url": {"url": "mock source 2mock sas"}},
343343
],
344344
"role": "user",
345345
},
@@ -411,7 +411,7 @@ def test_limit_number_of_images_passed_to_llm(
411411
"type": "text",
412412
"text": 'Sources: {"retrieved_documents":[{"[doc1]":{"content":"mock content"}},{"[doc2]":{"content":"mock content 2"}},{"[doc3]":{"content":"mock content 3"}}]}, Question: mock question',
413413
},
414-
{"type": "image_url", "image_url": "mock source 2mock sas"},
414+
{"type": "image_url", "image_url": {"url": "mock source 2mock sas"}},
415415
],
416416
"role": "user",
417417
},

0 commit comments

Comments
 (0)