Skip to content

Commit db33e52

Browse files
fix: Cleanup multiple gpt41 deployments (#1964)
1 parent 1372068 commit db33e52

File tree

6 files changed

+13
-30
lines changed

6 files changed

+13
-30
lines changed

code/backend/batch/utilities/helpers/env_helper.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def __load_config(self, **kwargs) -> None:
186186
"AZURE_OPENAI_MODEL_NAME", "gpt-4.1"
187187
)
188188

189-
self.AZURE_OPENAI_VISION_MODEL = os.getenv("AZURE_OPENAI_VISION_MODEL", "gpt-4")
189+
self.AZURE_OPENAI_VISION_MODEL = os.getenv("AZURE_OPENAI_VISION_MODEL", "gpt-4.1")
190190
self.AZURE_OPENAI_TEMPERATURE = os.getenv("AZURE_OPENAI_TEMPERATURE", "0")
191191
self.AZURE_OPENAI_TOP_P = os.getenv("AZURE_OPENAI_TOP_P", "1.0")
192192
self.AZURE_OPENAI_MAX_TOKENS = os.getenv("AZURE_OPENAI_MAX_TOKENS", "1000")

code/tests/utilities/helpers/test_push_embedder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def test_embed_file_advanced_image_processing_uses_vision_model_for_captioning(
192192
):
193193
# given
194194
env_helper_mock = MagicMock()
195-
env_helper_mock.AZURE_OPENAI_VISION_MODEL = "gpt-4"
195+
env_helper_mock.AZURE_OPENAI_VISION_MODEL = "gpt-4.1"
196196
push_embedder = PushEmbedder(MagicMock(), env_helper_mock)
197197
source_url = "http://localhost:8080/some-file-name.jpg"
198198

docs/model_configuration.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ This document outlines the necessary steps and configurations required for setti
2727
- `AZURE_OPENAI_VISION_MODEL`: The Azure OpenAI Model Deployment Name
2828
- example: `my-gpt-4`
2929
- `AZURE_OPENAI_VISION_MODEL_NAME`: The Azure OpenAI Model Name
30-
- example: `gpt-4`
30+
- example: `gpt-4.1`
3131
- `AZURE_OPENAI_VISION_MODEL_VERSION`: The Azure OpenAI Model Version
32-
- example: `turbo-2024-04-09`
32+
- example: `2025-04-14`
3333
- `AZURE_OPENAI_VISION_MODEL_CAPACITY`: The Tokens per Minute Rate Limit (thousands)
3434
- example: `10`
3535

infra/main.bicep

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ param useAdvancedImageProcessing bool = false
151151
param advancedImageProcessingMaxImages int = 1
152152

153153
@description('Optional. Azure OpenAI Vision Model Deployment Name.')
154-
param azureOpenAIVisionModel string = 'gpt-4.1-vision'
154+
param azureOpenAIVisionModel string = 'gpt-4.1'
155155

156156
@description('Optional. Azure OpenAI Vision Model Name.')
157157
param azureOpenAIVisionModelName string = 'gpt-4.1'
@@ -963,26 +963,6 @@ var defaultOpenAiDeployments = [
963963
}
964964
]
965965

966-
var openAiDeployments = concat(
967-
defaultOpenAiDeployments,
968-
useAdvancedImageProcessing
969-
? [
970-
{
971-
name: azureOpenAIVisionModel
972-
model: {
973-
format: 'OpenAI'
974-
name: azureOpenAIVisionModelName
975-
version: azureOpenAIVisionModelVersion
976-
}
977-
sku: {
978-
name: 'GlobalStandard'
979-
capacity: azureOpenAIVisionModelCapacity
980-
}
981-
}
982-
]
983-
: []
984-
)
985-
986966
module openai 'modules/core/ai/cognitiveservices.bicep' = {
987967
name: azureOpenAIResourceName
988968
scope: resourceGroup()
@@ -992,7 +972,7 @@ module openai 'modules/core/ai/cognitiveservices.bicep' = {
992972
tags: allTags
993973
kind: 'OpenAI'
994974
sku: azureOpenAISkuName
995-
deployments: openAiDeployments
975+
deployments: defaultOpenAiDeployments
996976
userAssignedResourceId: managedIdentityModule.outputs.resourceId
997977
restrictOutboundNetworkAccess: true
998978
allowedFqdnList: concat(

infra/main.parameters.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,11 +127,14 @@
127127
"value": "${ADVANCED_IMAGE_PROCESSING_MAX_IMAGES=1}"
128128
},
129129
"azureOpenAIVisionModel": {
130-
"value": "${AZURE_OPENAI_VISION_MODEL=gpt-4.1-vision}"
130+
"value": "${AZURE_OPENAI_VISION_MODEL=gpt-4.1}"
131131
},
132132
"azureOpenAIVisionModelName": {
133133
"value": "${AZURE_OPENAI_VISION_MODEL_NAME=gpt-4.1}"
134134
},
135+
"azureOpenAIVisionModelVersion": {
136+
"value": "${AZURE_OPENAI_VISION_MODEL_VERSION=2025-04-14}"
137+
},
135138
"azureOpenAIVisionModelCapacity": {
136139
"value": "${AZURE_OPENAI_VISION_MODEL_CAPACITY=10}"
137140
},

infra/main.waf.parameters.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,13 @@
127127
"value": "${ADVANCED_IMAGE_PROCESSING_MAX_IMAGES=1}"
128128
},
129129
"azureOpenAIVisionModel": {
130-
"value": "${AZURE_OPENAI_VISION_MODEL=gpt-4}"
130+
"value": "${AZURE_OPENAI_VISION_MODEL=gpt-4.1}"
131131
},
132132
"azureOpenAIVisionModelName": {
133-
"value": "${AZURE_OPENAI_VISION_MODEL_NAME=gpt-4}"
133+
"value": "${AZURE_OPENAI_VISION_MODEL_NAME=gpt-4.1}"
134134
},
135135
"azureOpenAIVisionModelVersion": {
136-
"value": "${AZURE_OPENAI_VISION_MODEL_VERSION=turbo-2024-04-09}"
136+
"value": "${AZURE_OPENAI_VISION_MODEL_VERSION=2025-04-14}"
137137
},
138138
"azureOpenAIVisionModelCapacity": {
139139
"value": "${AZURE_OPENAI_VISION_MODEL_CAPACITY=10}"

0 commit comments

Comments
 (0)