Make GetAvailableAndFreshSpaces clearer on failure and work better if run before device-connectivity (#57)

Author: fernandoviton

occupancy-quickstart/src/actions/getAvailableAndFreshSpaces.cs

@@ -21,22 +21,32 @@ public static async Task GetAvailableAndFreshSpaces(HttpClient httpClient)
             var maxGets = 30;
             for (var curGets = 0; curGets < maxGets; ++curGets)
             {
-                var spaces = await GetManagementItemsAsync<Models.Space>(httpClient, "spaces", "includes=values");
-                var availableAndFreshSpaces = spaces.Where(s => s.Values != null && s.Values.Any(v => v.Type == "AvailableAndFresh"));
-                if (!availableAndFreshSpaces.Any())
+                var (spaces, response) = await GetManagementItemsAsync<Models.Space>(httpClient, "spaces", "includes=values");
+                if (spaces == null)
                 {
-                    Console.WriteLine("ERROR: Unable to find a space with value type 'AvailableAndFresh'");
+                    var content = await response.Content?.ReadAsStringAsync();
+                    Console.WriteLine($"ERROR: GET spaces?includes=values failed with: {(int)response.StatusCode}, {response.StatusCode} {content}");
                     break;
                 }
-                var availableAndFreshDisplay = availableAndFreshSpaces
-                    .Select(s => GetDisplayValues(s))
-                    .Aggregate((acc, cur) => acc + "\n" + cur);
-                Console.WriteLine($"{availableAndFreshDisplay}");
+
+                var availableAndFreshSpaces = spaces.Where(s => s.Values != null && s.Values.Any(v => v.Type == "AvailableAndFresh"));
+                if (availableAndFreshSpaces.Any())
+                {
+                    var availableAndFreshDisplay = availableAndFreshSpaces
+                        .Select(s => GetDisplayValues(s))
+                        .Aggregate((acc, cur) => acc + "\n" + cur);
+                    Console.WriteLine($"{availableAndFreshDisplay}");
+                }
+                else
+                {
+                    Console.WriteLine("Unable to find a space with value type 'AvailableAndFresh'");
+                }
+
                 await Task.Delay(TimeSpan.FromSeconds(4));
             }
         }
 
-        private static async Task<IEnumerable<T>> GetManagementItemsAsync<T>(
+        private static async Task<(IEnumerable<T>, HttpResponseMessage)> GetManagementItemsAsync<T>(
             HttpClient httpClient,
             string queryItem,
             string queryParams)
@@ -46,10 +56,10 @@ private static async Task<IEnumerable<T>> GetManagementItemsAsync<T>(
             {
                 var content = await response.Content.ReadAsStringAsync();
                 var objects = JsonConvert.DeserializeObject<IEnumerable<T>>(content);
-                return objects;
+                return (objects, response);
             }
 
-            return null;
+            return (null, response);
         }
 
         private static string GetDisplayValues(Models.Space space)

occupancy-quickstart/src/loggingHttpHandler.cs

@@ -49,7 +49,7 @@ private async Task LogResponse(HttpResponseMessage response)
                 ? content
                 : content.Substring(0, maxContentLength - 3) + "...";
             var contentDisplay = contentMaxLength == null ? "" : $", {contentMaxLength}";
-            logger.LogTrace($"Response Status: {(int)response.StatusCode}, {response.StatusCode}{contentDisplay}");
+            logger.LogTrace($"Response Status: {(int)response.StatusCode}, {response.StatusCode} {contentDisplay}");
 
             // Enable to get more details:
             // logger.LogTrace($"Full Response: {Serialize(response)}");