Resolve comments and more clean up

Author: howieleung

README.md

@@ -50,6 +50,7 @@ Make sure the following tools are installed:
 2. [Python 3.9+](https://www.python.org/downloads/)
 3. [Git](https://git-scm.com/downloads)
 4. [Docker Desktop](https://www.docker.com/products/docker-desktop/)
+5. \[Windows Only\] [PowerShell](https://learn.microsoft.com/powershell/scripting/install/installing-powershell-on-windows) of the latest version, needed only for local application development on Windows operation system. Please make sure that power shell executable `pwsh.exe` is added to the `PATH` variable.
 
 ## Configure your Environment
 

infra/core/ai/hub-dependencies.bicep

@@ -13,8 +13,6 @@ param aiServiceModelDeployments array = []
 param logAnalyticsName string = ''
 @description('Name of the Application Insights instance')
 param applicationInsightsName string = ''
-@description('Name of the container registry')
-param containerRegistryName string = ''
 @description('Name of the Azure Cognitive Search service')
 param searchServiceName string = ''
 
@@ -114,15 +112,6 @@ module applicationInsights '../monitor/applicationinsights.bicep' =
     }
   }
 
-module containerRegistry '../host/container-registry.bicep' =
-  if (!empty(containerRegistryName)) {
-    name: 'containerRegistry'
-    params: {
-      location: location
-      tags: tags
-      name: containerRegistryName
-    }
-  }
 
 module cognitiveServices '../ai/cognitiveservices.bicep' = {
   name: 'cognitiveServices'
@@ -154,10 +143,6 @@ output keyVaultEndpoint string = keyVault.outputs.endpoint
 output storageAccountId string = storageAccount.outputs.id
 output storageAccountName string = storageAccount.outputs.name
 
-output containerRegistryId string = !empty(containerRegistryName) ? containerRegistry.outputs.id : ''
-output containerRegistryName string = !empty(containerRegistryName) ? containerRegistry.outputs.name : ''
-output containerRegistryEndpoint string = !empty(containerRegistryName) ? containerRegistry.outputs.loginServer : ''
-
 output applicationInsightsId string = !empty(applicationInsightsName) ? applicationInsights.outputs.id : ''
 output applicationInsightsName string = !empty(applicationInsightsName) ? applicationInsights.outputs.name : ''
 output logAnalyticsWorkspaceId string = !empty(logAnalyticsName) ? logAnalytics.outputs.id : ''

infra/core/ai/hub.bicep

@@ -8,8 +8,6 @@ param storageAccountId string
 param keyVaultId string
 @description('The application insights ID to use for the AI Foundry Hub Resource')
 param applicationInsightsId string = ''
-@description('The container registry ID to use for the AI Foundry Hub Resource')
-param containerRegistryId string = ''
 @description('The AI Services account name to use for the AI Foundry Hub Resource')
 param aiServicesName string
 @description('The AI Services connection name to use for the AI Foundry Hub Resource')
@@ -49,7 +47,6 @@ resource hub 'Microsoft.MachineLearningServices/workspaces@2024-07-01-preview' =
     storageAccount: storageAccountId
     keyVault: keyVaultId
     applicationInsights: !empty(applicationInsightsId) ? applicationInsightsId : null
-    containerRegistry: !empty(containerRegistryId) ? containerRegistryId : null
     hbiWorkspace: false
     managedNetwork: {
       isolationMode: 'Disabled'

infra/core/host/ai-environment.bicep

@@ -35,7 +35,6 @@ module hubDependencies '../ai/hub-dependencies.bicep' = {
     tags: tags
     keyVaultName: keyVaultName
     storageAccountName: storageAccountName
-    containerRegistryName: containerRegistryName
     applicationInsightsName: applicationInsightsName
     logAnalyticsName: logAnalyticsName
     aiServicesName: aiServicesName
@@ -53,7 +52,6 @@ module hub '../ai/hub.bicep' = {
     displayName: hubName
     keyVaultId: hubDependencies.outputs.keyVaultId
     storageAccountId: hubDependencies.outputs.storageAccountId
-    containerRegistryId: hubDependencies.outputs.containerRegistryId
     applicationInsightsId: hubDependencies.outputs.applicationInsightsId
     aiServicesName: hubDependencies.outputs.aiServicesName
     aiServicesConnectionName: aiServicesConnectionName
@@ -94,10 +92,6 @@ output keyVaultEndpoint string = hubDependencies.outputs.keyVaultEndpoint
 output applicationInsightsName string = hubDependencies.outputs.applicationInsightsName
 output logAnalyticsWorkspaceName string = hubDependencies.outputs.logAnalyticsWorkspaceName
 
-// Container Registry
-output containerRegistryName string = hubDependencies.outputs.containerRegistryName
-output containerRegistryEndpoint string = hubDependencies.outputs.containerRegistryEndpoint
-
 // Storage Account
 output storageAccountName string = hubDependencies.outputs.storageAccountName