Skip to content

Commit a188803

Browse files
committed
remove registry
1 parent ec88704 commit a188803

File tree

3 files changed

+3
-28
lines changed

3 files changed

+3
-28
lines changed

infra/api.bicep

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ param tags object = {}
44

55
param identityName string
66
param containerAppsEnvironmentName string
7-
param serviceName string = 'api'
87
param projectConnectionString string
98
param agentDeploymentName string
109
param searchConnectionName string
@@ -68,14 +67,13 @@ var env = [
6867
}
6968
]
7069

71-
var module_name = replace(serviceName, ' ', '-')
7270

7371
module app 'core/host/container-app-upsert.bicep' = {
74-
name: '${module_name}-container-app-module'
72+
name: 'container-app-module'
7573
params: {
7674
name: name
7775
location: location
78-
tags: union(tags, { 'azd-service-name': serviceName })
76+
tags: tags
7977
identityName: apiIdentity.name
8078
containerAppsEnvironmentName: containerAppsEnvironmentName
8179
targetPort: 50505

infra/core/host/container-apps.bicep

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
1-
metadata description = 'Creates an Azure Container Registry and an Azure Container Apps environment.'
1+
metadata description = 'Creates an Azure Container Apps environment.'
22
param name string
33
param location string = resourceGroup().location
44
param tags object = {}
55

66
param containerAppsEnvironmentName string
7-
param containerRegistryName string
8-
param containerRegistryResourceGroupName string = ''
9-
param containerRegistryAdminUserEnabled bool = false
107
param logAnalyticsWorkspaceName string
118
param applicationInsightsName string = ''
129

@@ -21,20 +18,7 @@ module containerAppsEnvironment 'container-apps-environment.bicep' = {
2118
}
2219
}
2320

24-
module containerRegistry 'container-registry.bicep' = {
25-
name: '${name}-container-registry'
26-
scope: !empty(containerRegistryResourceGroupName) ? resourceGroup(containerRegistryResourceGroupName) : resourceGroup()
27-
params: {
28-
name: containerRegistryName
29-
location: location
30-
adminUserEnabled: containerRegistryAdminUserEnabled
31-
tags: tags
32-
}
33-
}
34-
3521
output defaultDomain string = containerAppsEnvironment.outputs.defaultDomain
3622
output environmentName string = containerAppsEnvironment.outputs.name
3723
output environmentId string = containerAppsEnvironment.outputs.id
3824

39-
output registryLoginServer string = containerRegistry.outputs.loginServer
40-
output registryName string = containerRegistry.outputs.name

infra/main.bicep

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ param embedDeploymentSku string = 'Standard'
104104
// https://learn.microsoft.com/azure/ai-services/openai/quotas-limits
105105
param embedDeploymentCapacity int = 30
106106

107-
param useContainerRegistry bool = true
108107
param useApplicationInsights bool = true
109108
@description('Do we want to use the Azure AI Search')
110109
param useSearchService bool = false
@@ -251,7 +250,6 @@ module containerApps 'core/host/container-apps.bicep' = {
251250
name: 'app'
252251
location: location
253252
tags: tags
254-
containerRegistryName: '${abbrs.containerRegistryRegistries}${resourceToken}'
255253
containerAppsEnvironmentName: 'containerapps-env-${resourceToken}'
256254
logAnalyticsWorkspaceName: empty(aiExistingProjectConnectionString)
257255
? ai.outputs.logAnalyticsWorkspaceName
@@ -267,11 +265,8 @@ module api 'api.bicep' = {
267265
name: 'ca-api-${resourceToken}'
268266
location: location
269267
tags: tags
270-
serviceName: 'api_and_frontend'
271-
// serviceName: 'get-started-with-ai-agents'
272268
identityName: '${abbrs.managedIdentityUserAssignedIdentities}api-${resourceToken}'
273269
containerAppsEnvironmentName: containerApps.outputs.environmentName
274-
//containerRegistryName: containerApps.outputs.registryName
275270
projectConnectionString: projectConnectionString
276271
agentDeploymentName: agentDeploymentName
277272
searchConnectionName: searchConnectionName
@@ -409,8 +404,6 @@ output AZURE_AI_AGENT_ID string = agentID
409404

410405
// Outputs required by azd for ACA
411406
output AZURE_CONTAINER_ENVIRONMENT_NAME string = containerApps.outputs.environmentName
412-
output AZURE_CONTAINER_REGISTRY_NAME string = containerApps.outputs.registryName
413-
output AZURE_CONTAINER_REGISTRY_ENDPOINT string = containerApps.outputs.registryLoginServer
414407
output SERVICE_API_IDENTITY_PRINCIPAL_ID string = api.outputs.SERVICE_API_IDENTITY_PRINCIPAL_ID
415408
output SERVICE_API_NAME string = api.outputs.SERVICE_API_NAME
416409
output SERVICE_API_URI string = api.outputs.SERVICE_API_URI

0 commit comments

Comments
 (0)