fix: unblock Wave0 shared CI failures (#376)

Cataldir · web-flow · commit c7d3e5a28589 · 2026-03-19T23:38:46.000-03:00
* fix: unblock wave0 shared CI failures (#371) * chore: satisfy black gate for shared lint blockers * fix: enforce instruction override guard and stale agent links * fix: import prompt loader in cart agent instructions helper
diff --git a/.github/agents/pr-evaluator.agent.md b/.github/agents/pr-evaluator.agent.md
@@ -410,8 +410,8 @@ Follow ADR-022: `<prefix>/<issue-id>-<short-description>`
 
 ## References
 
-- [`docs/OPERATIONAL-WORKFLOWS.md`](docs/OPERATIONAL-WORKFLOWS.md) — Merge and release workflows
-- [`.github/governance-map.md`](.github/governance-map.md) — Repository governance
+- [`docs/governance`](docs/governance) — Governance policies and workflows
+- [`docs/architecture/README.md`](docs/architecture/README.md) — Repository architecture references
 - [GitHub PR Documentation](https://docs.github.com/en/pull-requests)
 
 ---
diff --git a/apps/ecommerce-cart-intelligence/src/ecommerce_cart_intelligence/agents.py b/apps/ecommerce-cart-intelligence/src/ecommerce_cart_intelligence/agents.py
@@ -14,6 +14,7 @@
     read_hot_with_compatibility,
     resolve_namespace_context,
 )
+from holiday_peak_lib.agents.prompt_loader import load_prompt_instructions
 
 from .adapters import CartAdapters, build_cart_adapters
 
diff --git a/apps/ecommerce-catalog-search/src/ecommerce_catalog_search/agents.py b/apps/ecommerce-catalog-search/src/ecommerce_catalog_search/agents.py
@@ -13,8 +13,8 @@
 from holiday_peak_lib.agents.fastapi_mcp import FastAPIMCPServer
 from holiday_peak_lib.agents.prompt_loader import load_prompt_instructions
 from holiday_peak_lib.schemas.product import CatalogProduct
-from pydantic import ValidationError
 from holiday_peak_lib.schemas.truth import IntentClassification
+from pydantic import ValidationError
 
 from .adapters import (
     CatalogAdapters,
@@ -313,10 +313,14 @@ async def _search_products_intelligent(
     complexity = agent.assess_complexity(query)
     if complexity < agent.complexity_threshold:
         products = await _search_products_keyword(adapters, query=query, limit=limit)
-        return products, {}, IntentClassification(
-            intent="keyword_lookup",
-            confidence=1.0,
-            entities={"reason": "low_complexity"},
+        return (
+            products,
+            {},
+            IntentClassification(
+                intent="keyword_lookup",
+                confidence=1.0,
+                entities={"reason": "low_complexity"},
+            ),
         )
 
     intent = await agent.classify_intent(query)
@@ -347,9 +351,7 @@ def _build_sub_queries(query: str, intent: IntentClassification) -> list[str]:
             sub_queries.append(value.strip())
         elif isinstance(value, list):
             sub_queries.extend(
-                item.strip()
-                for item in value
-                if isinstance(item, str) and item.strip()
+                item.strip() for item in value if isinstance(item, str) and item.strip()
             )
     unique: list[str] = []
     seen: set[str] = set()
diff --git a/apps/ecommerce-catalog-search/src/ecommerce_catalog_search/ai_search.py b/apps/ecommerce-catalog-search/src/ecommerce_catalog_search/ai_search.py
@@ -138,9 +138,7 @@ def _normalize_result_document(document: dict[str, Any]) -> AISearchDocumentResu
     if not sku:
         return None
     enriched_fields = {
-        field: document.get(field)
-        for field in _ENRICHED_FIELDS
-        if document.get(field) is not None
+        field: document.get(field) for field in _ENRICHED_FIELDS if document.get(field) is not None
     }
     return AISearchDocumentResult(
         sku=sku,
diff --git a/apps/ecommerce-catalog-search/tests/test_agents.py b/apps/ecommerce-catalog-search/tests/test_agents.py
@@ -391,5 +391,7 @@ async def test_handle_intelligent_mode_runs_multi_query_and_merges_enrichment(
             assert first["complementary_products"] == ["SKU-321"]
             assert first["substitute_products"] == ["SKU-654"]
             assert "extended_attributes" in first
-            assert first["extended_attributes"]["enriched_description"].startswith("Noise-canceling")
+            assert first["extended_attributes"]["enriched_description"].startswith(
+                "Noise-canceling"
+            )
             mock_multi.assert_awaited_once()
diff --git a/apps/ecommerce-catalog-search/tests/test_mcp_tools.py b/apps/ecommerce-catalog-search/tests/test_mcp_tools.py
@@ -166,9 +166,7 @@ async def test_catalog_intent_tool_requires_query(self, mock_mcp_server, mock_ag
         assert result["error"] == "query is required"
 
     @pytest.mark.asyncio
-    async def test_catalog_intent_tool_returns_classification_for_real_agent(
-        self, mock_mcp_server
-    ):
+    async def test_catalog_intent_tool_returns_classification_for_real_agent(self, mock_mcp_server):
         """Intent MCP tool should call classify_intent when the bound agent supports it."""
         deps = AgentDependencies(
             service_name="test-catalog-search",
diff --git a/apps/search-enrichment-agent/src/search_enrichment_agent/adapters.py b/apps/search-enrichment-agent/src/search_enrichment_agent/adapters.py
@@ -12,8 +12,8 @@
     build_ai_search_indexing_client_from_env,
 )
 from holiday_peak_lib.schemas.truth import SearchEnrichedProduct
-from holiday_peak_lib.utils.rate_limiter import RateLimitExceededError, RateLimiter
 from holiday_peak_lib.utils.logging import configure_logging
+from holiday_peak_lib.utils.rate_limiter import RateLimiter, RateLimitExceededError
 
 logger = configure_logging(app_name="search-enrichment-agent")
 
@@ -113,7 +113,9 @@ async def enrich_complex_fields(
         parsed["_status"] = "ok"
         return parsed
 
-    def _build_messages(self, *, entity_id: str, approved_truth: dict[str, Any]) -> list[dict[str, Any]]:
+    def _build_messages(
+        self, *, entity_id: str, approved_truth: dict[str, Any]
+    ) -> list[dict[str, Any]]:
         instruction = (
             "Generate search enrichment fields from approved truth data. "
             "Return a JSON object with keys: use_cases, complementary_products, "
@@ -159,7 +161,9 @@ async def sync_after_upsert(
             document = enriched.model_dump(mode="json", by_alias=True)
             document.setdefault("id", entity_id)
             document.setdefault("sku", entity_id)
-            return await self._client.index_documents(self._client.settings.default_index_name, [document])
+            return await self._client.index_documents(
+                self._client.settings.default_index_name, [document]
+            )
 
         indexer_name = self._client.settings.default_indexer_name
         if not indexer_name:
diff --git a/apps/search-enrichment-agent/src/search_enrichment_agent/agents.py b/apps/search-enrichment-agent/src/search_enrichment_agent/agents.py
@@ -67,9 +67,7 @@ async def run(
             sku=entity_id,
             score=1.0 if strategy == "complex" else 0.75,
             sourceType=(
-                SourceType.AI_REASONING
-                if strategy == "complex"
-                else SourceType.PRODUCT_CONTEXT
+                SourceType.AI_REASONING if strategy == "complex" else SourceType.PRODUCT_CONTEXT
             ),
             sourceAssets=[],
             originalData=approved,
diff --git a/apps/search-enrichment-agent/src/search_enrichment_agent/enrichment_engine.py b/apps/search-enrichment-agent/src/search_enrichment_agent/enrichment_engine.py
@@ -83,7 +83,12 @@ def build_complex_fields(
         merged = dict(simple)
         for key in _REQUIRED_FIELDS:
             candidate = model_output.get(key)
-            if key in {"use_cases", "complementary_products", "substitute_products", "search_keywords"}:
+            if key in {
+                "use_cases",
+                "complementary_products",
+                "substitute_products",
+                "search_keywords",
+            }:
                 normalized = self._normalize_string_list(candidate)
                 if normalized:
                     merged[key] = normalized
diff --git a/apps/search-enrichment-agent/tests/test_agents.py b/apps/search-enrichment-agent/tests/test_agents.py
@@ -67,7 +67,10 @@ def _mock_adapters() -> SearchEnrichmentAdapters:
 @pytest.mark.asyncio
 async def test_handle_requires_entity_id() -> None:
     agent_config_without_models = _build_agent_config_without_models()
-    with patch("search_enrichment_agent.agents.build_search_enrichment_adapters", return_value=_mock_adapters()):
+    with patch(
+        "search_enrichment_agent.agents.build_search_enrichment_adapters",
+        return_value=_mock_adapters(),
+    ):
         agent = SearchEnrichmentAgent(config=agent_config_without_models)
 
     result = await agent.handle({})
@@ -78,7 +81,9 @@ async def test_handle_requires_entity_id() -> None:
 async def test_handle_enriches_with_simple_strategy_when_models_unavailable() -> None:
     agent_config_without_models = _build_agent_config_without_models()
     adapters = _mock_adapters()
-    with patch("search_enrichment_agent.agents.build_search_enrichment_adapters", return_value=adapters):
+    with patch(
+        "search_enrichment_agent.agents.build_search_enrichment_adapters", return_value=adapters
+    ):
         agent = SearchEnrichmentAgent(config=agent_config_without_models)
 
     result = await agent.handle({"entity_id": "SKU-1"})
@@ -101,7 +106,9 @@ def add_tool(path, handler):  # noqa: ANN001
     mcp.add_tool = add_tool
 
     adapters = _mock_adapters()
-    with patch("search_enrichment_agent.agents.build_search_enrichment_adapters", return_value=adapters):
+    with patch(
+        "search_enrichment_agent.agents.build_search_enrichment_adapters", return_value=adapters
+    ):
         agent = SearchEnrichmentAgent(config=agent_config_with_slm)
         register_mcp_tools(mcp, agent)
 
@@ -125,7 +132,9 @@ async def test_enrich_triggers_search_indexing_after_upsert() -> None:
     adapters.search_indexing = AsyncMock()
     adapters.search_indexing.sync_after_upsert = AsyncMock(return_value={"status": "accepted"})
 
-    with patch("search_enrichment_agent.agents.build_search_enrichment_adapters", return_value=adapters):
+    with patch(
+        "search_enrichment_agent.agents.build_search_enrichment_adapters", return_value=adapters
+    ):
         agent = SearchEnrichmentAgent(config=agent_config_without_models)
 
     result = await agent.enrich("SKU-1", trigger="test")
@@ -148,8 +157,13 @@ def add_tool(path, handler):  # noqa: ANN001
     fake_client = object()
     adapters = _mock_adapters()
     with (
-        patch("search_enrichment_agent.agents.build_search_enrichment_adapters", return_value=adapters),
-        patch("search_enrichment_agent.agents.build_ai_search_indexing_client_from_env", return_value=fake_client),
+        patch(
+            "search_enrichment_agent.agents.build_search_enrichment_adapters", return_value=adapters
+        ),
+        patch(
+            "search_enrichment_agent.agents.build_ai_search_indexing_client_from_env",
+            return_value=fake_client,
+        ),
         patch("search_enrichment_agent.agents.register_ai_search_indexing_tools") as register_tools,
     ):
         agent = SearchEnrichmentAgent(config=agent_config_with_slm)
diff --git a/apps/truth-enrichment/src/truth_enrichment/adapters.py b/apps/truth-enrichment/src/truth_enrichment/adapters.py
@@ -218,6 +218,7 @@ def _fallback(self, reason: str, field_name: str) -> dict[str, Any]:
             "metadata": {"source": "image_analysis", "fallback_reason": reason},
         }
 
+
 class ProposedAttributeStoreAdapter:
     """Write proposed attributes to the Cosmos DB `attributes_proposed` container."""
 
diff --git a/apps/truth-enrichment/src/truth_enrichment/enrichment_engine.py b/apps/truth-enrichment/src/truth_enrichment/enrichment_engine.py
@@ -120,28 +120,27 @@ def merge_enrichment_candidates(
             source_type = "image_analysis"
             selected_value = image_value
             confidence = image_confidence
-            reasoning = (
-                f"Image analysis selected with confidence={image_confidence:.2f}."
-            )
+            reasoning = f"Image analysis selected with confidence={image_confidence:.2f}."
             evidence = str(image_parsed.get("evidence", ""))
         elif has_text_value:
             source_type = "text_enrichment"
             selected_value = text_value
             confidence = text_confidence
-            reasoning = (
-                f"Text enrichment selected with confidence={text_confidence:.2f}."
-            )
+            reasoning = f"Text enrichment selected with confidence={text_confidence:.2f}."
             evidence = str(text_parsed.get("evidence", ""))
         else:
             source_type = "text_enrichment" if text_parsed else "image_analysis"
             selected_value = None
             confidence = max(image_confidence, text_confidence)
             reasoning = "No reliable value extracted from available enrichment sources."
-            evidence = " | ".join(
-                str(part)
-                for part in [image_parsed.get("evidence", ""), text_parsed.get("evidence", "")]
-                if part
-            ) or "enrichment unavailable"
+            evidence = (
+                " | ".join(
+                    str(part)
+                    for part in [image_parsed.get("evidence", ""), text_parsed.get("evidence", "")]
+                    if part
+                )
+                or "enrichment unavailable"
+            )
 
         return {
             "value": selected_value,
diff --git a/apps/truth-enrichment/tests/test_adapters.py b/apps/truth-enrichment/tests/test_adapters.py
@@ -5,7 +5,6 @@
 from unittest.mock import AsyncMock
 
 import pytest
-
 from truth_enrichment.adapters import DAMImageAnalysisAdapter, build_enrichment_adapters
 
 
diff --git a/apps/truth-enrichment/tests/test_agents.py b/apps/truth-enrichment/tests/test_agents.py
@@ -13,6 +13,7 @@
 @pytest.fixture()
 def agent_config_with_slm() -> AgentDependencies:
     """Create agent dependencies with an enabled fast-model route."""
+
     async def dummy_invoker(*, messages, tools=None, **kwargs):  # noqa: ANN001
         return {"value": "dummy", "confidence": 0.0, "evidence": "dummy"}
 
@@ -111,7 +112,9 @@ async def fake_model(*, request, messages):  # noqa: ANN001
                 "metadata": {"source": "text_enrichment"},
             }
 
-        agent.adapters.image_analysis.analyze_attribute_from_images = AsyncMock(side_effect=fake_image)
+        agent.adapters.image_analysis.analyze_attribute_from_images = AsyncMock(
+            side_effect=fake_image
+        )
         agent.invoke_model = AsyncMock(side_effect=fake_model)
 
         proposed = await agent.enrich_field(
diff --git a/apps/truth-export/src/truth_export/export_engine.py b/apps/truth-export/src/truth_export/export_engine.py
@@ -7,8 +7,8 @@
 from typing import Any
 
 from holiday_peak_lib.adapters.acp_mapper import AcpCatalogMapper
-from holiday_peak_lib.integrations import PIMWritebackManager
 from holiday_peak_lib.adapters.ucp_mapper import UcpProtocolMapper
+from holiday_peak_lib.integrations import PIMWritebackManager
 
 from .schemas_compat import AuditAction, AuditEvent, ExportResult
 
@@ -109,7 +109,9 @@ async def writeback_entity(
 
         This command-style method is reused by REST routes and event handlers.
         """
-        result = await (manager.dry_run(entity_id) if dry_run else manager.writeback_product(entity_id))
+        result = await (
+            manager.dry_run(entity_id) if dry_run else manager.writeback_product(entity_id)
+        )
         summary = result.model_dump()
         summary["dry_run"] = dry_run
         summary["status"] = self._resolve_writeback_status(summary)
diff --git a/apps/truth-export/tests/test_event_handlers.py b/apps/truth-export/tests/test_event_handlers.py
@@ -68,7 +68,8 @@ async def test_export_jobs_hitl_approval_triggers_writeback_path() -> None:
     assert adapters.truth_store._results  # pylint: disable=protected-access
     assert adapters.truth_store._audit_events  # pylint: disable=protected-access
     assert (
-        adapters.truth_store._audit_events[-1]["details"]["writeback_status"] == "completed"  # pylint: disable=protected-access
+        adapters.truth_store._audit_events[-1]["details"]["writeback_status"]
+        == "completed"  # pylint: disable=protected-access
     )
 
 
@@ -101,4 +102,6 @@ async def test_export_jobs_protocol_export_uses_existing_path() -> None:
     await handler(MagicMock(), event)
 
     assert adapters.truth_store._results  # pylint: disable=protected-access
-    assert adapters.truth_store._results[-1]["protocol"] == "ucp"  # pylint: disable=protected-access
+    assert (
+        adapters.truth_store._results[-1]["protocol"] == "ucp"
+    )  # pylint: disable=protected-access
diff --git a/apps/truth-export/tests/test_export.py b/apps/truth-export/tests/test_export.py
@@ -4,8 +4,8 @@
 
 from __future__ import annotations
 
-from datetime import datetime, timedelta, timezone
 import json
+from datetime import datetime, timedelta, timezone
 from unittest.mock import AsyncMock
 
 import httpx
@@ -17,8 +17,7 @@
     PIMWritebackManager,
     TenantConfig,
 )
-from truth_export.adapters import build_truth_export_adapters
-from truth_export.adapters import GenericPIMWritebackAdapter
+from truth_export.adapters import GenericPIMWritebackAdapter, build_truth_export_adapters
 from truth_export.export_engine import ExportEngine
 from truth_export.main import app
 from truth_export.routes import get_adapters, get_engine
diff --git a/apps/truth-hitl/src/truth_hitl/routes.py b/apps/truth-hitl/src/truth_hitl/routes.py
@@ -27,7 +27,9 @@ def build_review_router(adapters: HITLAdapters) -> APIRouter:
     """Return an APIRouter wired to the provided adapters."""
     router = APIRouter(prefix="/review", tags=["hitl-review"])
 
-    def execute_review_action(entity_id: str, decision: ReviewDecision, action: str) -> list[ReviewItem]:
+    def execute_review_action(
+        entity_id: str, decision: ReviewDecision, action: str
+    ) -> list[ReviewItem]:
         """Execute a review action and keep single-action response semantics."""
         action_map = {
             "approve": adapters.review_manager.approve,
diff --git a/apps/truth-hitl/tests/test_mcp_tools.py b/apps/truth-hitl/tests/test_mcp_tools.py
@@ -85,7 +85,9 @@ async def test_get_proposal_requires_entity_id(self, mock_mcp_server, mock_agent
         assert result["error"] == "entity_id is required"
 
     @pytest.mark.asyncio
-    async def test_get_proposal_returns_none_for_missing_proposal(self, mock_mcp_server, mock_agent):
+    async def test_get_proposal_returns_none_for_missing_proposal(
+        self, mock_mcp_server, mock_agent
+    ):
         register_mcp_tools(mock_mcp_server, mock_agent)
         tool = mock_mcp_server.tools["/review/get_proposal"]
 
diff --git a/apps/ui/tests/setupTests.ts b/apps/ui/tests/setupTests.ts
@@ -52,6 +52,16 @@ if (!window.matchMedia) {
 	});
 }
 
+if (!(global as any).ResizeObserver) {
+	class MockResizeObserver {
+		observe() {}
+		unobserve() {}
+		disconnect() {}
+	}
+	(global as any).ResizeObserver = MockResizeObserver;
+	(window as any).ResizeObserver = MockResizeObserver;
+}
+
 jest.mock('@stripe/stripe-js', () => ({
 	__esModule: true,
 	loadStripe: jest.fn(async () => ({
diff --git a/lib/src/holiday_peak_lib/app_factory.py b/lib/src/holiday_peak_lib/app_factory.py
diff --git a/lib/src/holiday_peak_lib/mcp/ai_search_indexing.py b/lib/src/holiday_peak_lib/mcp/ai_search_indexing.py
diff --git a/lib/src/holiday_peak_lib/schemas/__init__.py b/lib/src/holiday_peak_lib/schemas/__init__.py
diff --git a/lib/src/holiday_peak_lib/utils/telemetry.py b/lib/src/holiday_peak_lib/utils/telemetry.py
diff --git a/lib/tests/test_ai_search_indexing_mcp.py b/lib/tests/test_ai_search_indexing_mcp.py
diff --git a/lib/tests/test_evaluation_metrics.py b/lib/tests/test_evaluation_metrics.py
diff --git a/lib/tests/test_truth_schemas.py b/lib/tests/test_truth_schemas.py

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@`
`14`	`14`	`read_hot_with_compatibility,`
`15`	`15`	`resolve_namespace_context,`
`16`	`16`	`)`
	`17`	`+from holiday_peak_lib.agents.prompt_loader import load_prompt_instructions`
`17`	`18`
`18`	`19`	`from .adapters import CartAdapters, build_cart_adapters`
`19`	`20`