Skip to content

Commit 01063aa

Browse files
committed
review comments
1 parent f9038b2 commit 01063aa

File tree

1 file changed

+24
-21
lines changed

1 file changed

+24
-21
lines changed

1-Authentication/5-sign-in-express/README.md

Lines changed: 24 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ This sample demonstrates how to sign users into a sample Node.js & Express web a
4848
| **Use case** | This code sample applies to **customer configuration uses case**![Yes button](./ReadmeFiles/yes.png "Title"). If you're looking for a workforce configuration use case, use [Tutorial: Enable a Node.js (Express) application to sign in users by using Microsoft Entra ID](https://github.com/Azure-Samples/ms-identity-node) |
4949
| **Scenario** | Sign in users. You acquire an ID token by using authorization code flow with PKCE. |
5050
| **Add sign in to your app** | Use the instructions in [Sign in users in a Node.js web app](https://learn.microsoft.com/entra/external-id/customers/tutorial-web-app-node-sign-in-prepare-tenant) to learn how to add sign in to your Node web app. |
51-
|**Product documentation** | Explore [Microsoft Entra ID for customers documentation](https://review.learn.microsoft.com/entra/external-id/customers/) |
51+
|**Product documentation** | Explore [Microsoft Entra ID for customers documentation](https://learn.microsoft.com/entra/external-id/customers/) |
5252

5353
## Contents
5454

@@ -69,31 +69,34 @@ This sample demonstrates how to sign users into a sample Node.js & Express web a
6969

7070
## Register the web application in your tenant
7171

72-
You can register an app in your tenant automatically by using Microsoft Graph PowerShell or Manually register your apps in Microsoft Entra Admin center.
72+
You can register an app in your tenant automatically by using Microsoft Graph PowerShell or via the Microsoft Entra Admin center.
7373

74-
When you use Microsoft Graph PowerShell, you automatically register the applications and related objects app secrets, then modifies your project config files, so you run the app without any further action.
74+
When you use Microsoft Graph PowerShell, you automatically register the applications and related objects app secrets, then modify your project config files, so you can run the app without any further action:
7575

76-
To register your app manually in the Microsoft Entra admin center use the steps in [Register the web app](https://learn.microsoft.com/entra/external-id/customers/sample-web-app-node-sign-in#register-the-web-app).
7776

78-
<details>
79-
<summary>Expand this section if you want to use this automation:</summary>
80-
81-
> :warning: If you have never used **Microsoft Graph PowerShell** before, we recommend you go through the [App Creation Scripts Guide](./AppCreationScripts/AppCreationScripts.md) once to ensure that you've prepared your environment correctly for this step.
77+
* To register your app in the Microsoft Entra admin center use the steps in [Register the web app](https://learn.microsoft.com/entra/external-id/customers/sample-web-app-node-sign-in#register-the-web-app).
8278

83-
1. Ensure that you have PowerShell 7 or later installed.
84-
1. Run the script to create your Microsoft Entra ID application and configure the code of the sample application accordingly.
85-
1. For interactive process in PowerShell, run:
86-
87-
```PowerShell
88-
cd .\AppCreationScripts\
89-
.\Configure.ps1 -TenantId "[Optional] - your tenant id" -AzureEnvironmentName "[Optional] - Azure environment, defaults to 'Global'"
90-
```
79+
* To register and configure your app automatically,
9180

92-
> Other ways of running the scripts are described in [App Creation Scripts guide](./AppCreationScripts/AppCreationScripts.md). The scripts also provides a guide to automated application registration, configuration and removal which can help in your CI/CD scenarios.
93-
94-
> :exclamation: NOTE: This sample can make use of client certificates. You can use **AppCreationScripts** to register an Microsoft Entra ID application with certificates. For more information see, [Use client certificate for authentication in your Node.js web app instead of client secrets](https://review.learn.microsoft.com/entra/external-id/customers/how-to-web-app-node-use-certificate).
95-
96-
</details>
81+
<details>
82+
<summary>Expand this section</summary>
83+
84+
> :warning: If you have never used **Microsoft Graph PowerShell** before, we recommend you go through the [App Creation Scripts Guide](./AppCreationScripts/AppCreationScripts.md) once to ensure that you've prepared your environment correctly for this step.
85+
86+
1. Ensure that you have PowerShell 7 or later installed.
87+
1. Run the script to create your Microsoft Entra ID application and configure the code of the sample application accordingly.
88+
1. For interactive process in PowerShell, run:
89+
90+
```PowerShell
91+
cd .\AppCreationScripts\
92+
.\Configure.ps1 -TenantId "[Optional] - your tenant id" -AzureEnvironmentName "[Optional] - Azure environment, defaults to 'Global'"
93+
```
94+
95+
> Other ways of running the scripts are described in [App Creation Scripts guide](./AppCreationScripts/AppCreationScripts.md). The scripts also provides a guide to automated application registration, configuration and removal which can help in your CI/CD scenarios.
96+
97+
> :exclamation: NOTE: This sample can make use of client certificates. You can use **AppCreationScripts** to register an Microsoft Entra ID application with certificates. For more information see, [Use client certificate for authentication in your Node.js web app instead of client secrets](https://review.learn.microsoft.com/entra/external-id/customers/how-to-web-app-node-use-certificate).
98+
99+
</details>
97100
98101
## Add app client secret
99102

0 commit comments

Comments
 (0)