Address copilot feedback

Author: madebygps

.env-sample

@@ -19,3 +19,7 @@ OLLAMA_API_KEY=ollama
 # OpenAI Configuration (default if API_HOST not set)
 OPENAI_MODEL=gpt-4o-mini
 OPENAI_API_KEY=your_openai_api_key_here
+
+# OpenTelemetry Configuration (for Aspire Dashboard)
+# Uncomment to enable tracing, metrics, and logs export
+# OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4317

README.md

@@ -170,7 +170,21 @@ You can use the [.NET Aspire Dashboard](https://learn.microsoft.com/dotnet/aspir
        mcr.microsoft.com/dotnet/aspire-dashboard:latest
    ```
 
-2. Set the environment variable and start the HTTP server:
+   > The Aspire Dashboard exposes its OTLP endpoint on container port 18889. The mapping `-p 4317:18889` makes it available on the host's standard OTLP port 4317.
+
+   Get the dashboard URL and login token from the container logs:
+
+   ```bash
+   docker logs aspire-dashboard 2>&1 | grep "Login to the dashboard"
+   ```
+
+2. Enable OpenTelemetry by adding this to your `.env` file:
+
+   ```bash
+   OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4317
+   ```
+
+3. Start the HTTP server:
 
    ```bash
    uv run servers/basic_mcp_http.py

pyproject.toml

@@ -18,6 +18,7 @@ dependencies = [
     "azure-cosmos>=4.9.0",
     "azure-monitor-opentelemetry>=1.6.4",
     "opentelemetry-instrumentation-starlette>=0.49b0",
+    "opentelemetry-exporter-otlp-proto-grpc>=1.28.0",
     "logfire>=4.15.1",
     "azure-core-tracing-opentelemetry>=1.0.0b12"
 ]

servers/basic_mcp_http.py

@@ -6,27 +6,30 @@
 from pathlib import Path
 from typing import Annotated
 
+from dotenv import load_dotenv
 from fastmcp import FastMCP
 from opentelemetry_middleware import OpenTelemetryMiddleware, configure_aspire_dashboard
 
+load_dotenv(override=True)
+
 logging.basicConfig(level=logging.INFO, format="%(asctime)s - %(message)s")
 logger = logging.getLogger("ExpensesMCP")
 
 
-# Configure Aspire Dashboard telemetry if OTEL_EXPORTER_OTLP_ENDPOINT is set
-if os.getenv("OTEL_EXPORTER_OTLP_ENDPOINT"):
+otel_endpoint = os.getenv("OTEL_EXPORTER_OTLP_ENDPOINT")
+middleware: list = []
+
+if otel_endpoint:
     logger.info("Setting up Aspire Dashboard instrumentation (OTLP)")
     configure_aspire_dashboard(service_name="expenses-mcp")
+    middleware = [OpenTelemetryMiddleware(tracer_name="expenses.mcp")]
 
 
 SCRIPT_DIR = Path(__file__).parent
 EXPENSES_FILE = SCRIPT_DIR / "expenses.csv"
 
 
-mcp = FastMCP(
-    "Expenses Tracker",
-    middleware=[OpenTelemetryMiddleware(tracer_name="expenses.mcp")]
-)
+mcp = FastMCP("Expenses Tracker", middleware=middleware)
 
 
 class PaymentMethod(Enum):

servers/opentelemetry_middleware.py

@@ -1,6 +1,5 @@
 import logging
 import os
-from urllib.parse import urlparse
 
 from fastmcp.server.middleware import Middleware, MiddlewareContext
 from opentelemetry import metrics, trace
@@ -14,45 +13,36 @@
 from opentelemetry.sdk.metrics.export import PeriodicExportingMetricReader
 from opentelemetry.sdk.resources import Resource
 from opentelemetry.sdk.trace import TracerProvider
-from opentelemetry.sdk.trace.export import SimpleSpanProcessor
+from opentelemetry.sdk.trace.export import BatchSpanProcessor
 from opentelemetry.trace import Status, StatusCode
 
 
 def configure_aspire_dashboard(service_name: str = "expenses-mcp"):
     """Configure OpenTelemetry to send telemetry to the Aspire standalone dashboard."""
     otlp_endpoint = os.getenv("OTEL_EXPORTER_OTLP_ENDPOINT", "http://localhost:4317")
-    parsed_endpoint = urlparse(otlp_endpoint)
-    use_insecure = parsed_endpoint.scheme not in ("https", "grpcs")
 
     # Create resource with service name
     resource = Resource.create({"service.name": service_name})
 
     # Configure Tracing
     tracer_provider = TracerProvider(resource=resource)
-    tracer_provider.add_span_processor(
-        SimpleSpanProcessor(OTLPSpanExporter(endpoint=otlp_endpoint, insecure=use_insecure))
-    )
+    tracer_provider.add_span_processor(BatchSpanProcessor(OTLPSpanExporter(endpoint=otlp_endpoint)))
     trace.set_tracer_provider(tracer_provider)
 
     # Configure Metrics
-    metric_reader = PeriodicExportingMetricReader(
-        OTLPMetricExporter(endpoint=otlp_endpoint, insecure=use_insecure)
-    )
+    metric_reader = PeriodicExportingMetricReader(OTLPMetricExporter(endpoint=otlp_endpoint))
     meter_provider = MeterProvider(resource=resource, metric_readers=[metric_reader])
     metrics.set_meter_provider(meter_provider)
 
     # Configure Logging
     logger_provider = LoggerProvider(resource=resource)
-    logger_provider.add_log_record_processor(
-        BatchLogRecordProcessor(OTLPLogExporter(endpoint=otlp_endpoint, insecure=use_insecure))
-    )
+    logger_provider.add_log_record_processor(BatchLogRecordProcessor(OTLPLogExporter(endpoint=otlp_endpoint)))
     set_logger_provider(logger_provider)
 
     # Add logging handler to send Python logs to OTLP
     root_logger = logging.getLogger()
     handler_exists = any(
-        isinstance(existing, LoggingHandler)
-        and getattr(existing, "logger_provider", None) is logger_provider
+        isinstance(existing, LoggingHandler) and getattr(existing, "logger_provider", None) is logger_provider
         for existing in root_logger.handlers
     )