feat: e2e increase upgrade test to also test updates

upgrades and updates can happen at the same time, increase the e2e
test coverage to cover this case. In this test we upgrade the version
and also update the replicas to 2.

Author: ahitacat

test/e2e/nodepool_version_upgrade.go

@@ -28,6 +28,7 @@ import (
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/rand"
+	"k8s.io/utils/ptr"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
 
@@ -43,7 +44,7 @@ import (
 )
 
 var _ = Describe("Customer", func() {
-	DescribeTable("should upgrade a nodepool",
+	DescribeTable("should upgrade and update a nodepool",
 		func(ctx context.Context, nodePoolMinor string, targetMinor string) {
 			// ARO-25490 (https://redhat.atlassian.net/browse/ARO-25490): remove after 2026-04-07 UTC or when fixed in CS.
 			// Node pools on minor 4.21 fail during install (Azure marketplace image missing in CS).
@@ -197,10 +198,12 @@ var _ = Describe("Customer", func() {
 			Expect(err).NotTo(HaveOccurred())
 			Expect(previousReleaseImages).NotTo(BeEmpty(), "expected node pool nodes to report at least one release image ref before upgrade")
 
-			By(fmt.Sprintf("triggering nodepool upgrade to version %s", nodePoolDesiredVersion))
+			By(fmt.Sprintf("triggering nodepool upgrade to version %s and update replicas to 1", nodePoolDesiredVersion))
+			updateReplicas := 3
 			nodePoolsClient := tc.Get20240610ClientFactoryOrDie(ctx).NewNodePoolsClient()
 			update := hcpsdk20240610preview.NodePoolUpdate{
 				Properties: &hcpsdk20240610preview.NodePoolPropertiesUpdate{
+					Replicas: ptr.To(int32(updateReplicas)),
 					Version: &hcpsdk20240610preview.NodePoolVersionProfile{
 						ID:           to.Ptr(nodePoolDesiredVersion),
 						ChannelGroup: to.Ptr(channelGroup),
@@ -227,6 +230,11 @@ var _ = Describe("Customer", func() {
 			Expect(npGetResponse.Properties.Version).NotTo(BeNil())
 			Expect(npGetResponse.Properties.Version.ID).NotTo(BeNil())
 			Expect(*npGetResponse.Properties.Version.ID).To(Equal(nodePoolDesiredVersion))
+
+			By("verifiying node pool reflects correct node count")
+			Expect(verifiers.VerifyNodeCount(updateReplicas).Verify(ctx, adminRESTConfig)).To(Succeed())
+			Expect(verifiers.VerifyNodesReady().Verify(ctx, adminRESTConfig)).To(Succeed())
+
 		},
 		Entry("from 4.20.z to 4.21.zLatest",
 			labels.RequireNothing, labels.Critical, labels.Positive, labels.AroRpApiCompatible,