add more tests

Author: r2k1

aks-node-controller/pkg/nodeconfigutils/utils_test.go

@@ -21,14 +21,14 @@ func TestUnmarshalConfigurationV1(t *testing.T) {
 			name: "valid minimal config",
 			data: []byte(`{
 				"version": "v1",
-				"authConfig": {
-					"subscriptionId": "test-subscription"
+				"auth_config": {
+					"subscription_id": "test-subscription"
 				},
-				"clusterConfig": {
-					"resourceGroup": "test-rg",
+				"cluster_config": {
+					"resource_group": "test-rg",
 					"location": "eastus"
 				},
-				"apiServerConfig": {
+				"api_server_config": {
 					"apiServerName": "test-api-server"
 				}
 			}`),
@@ -50,22 +50,24 @@ func TestUnmarshalConfigurationV1(t *testing.T) {
 		{
 			name:    "empty data",
 			data:    []byte(""),
-			want:    nil,
+			want:    &aksnodeconfigv1.Configuration{},
 			wantErr: true,
 		},
 		{
-			name:    "invalid JSON",
-			data:    []byte(`{"version": "v1", invalid}`),
-			want:    nil,
+			name: "invalid JSON",
+			data: []byte(`{"version": "v1", invalid}`),
+			want: &aksnodeconfigv1.Configuration{
+				Version: "v1",
+			},
 			wantErr: true,
 		},
 		{
 			name: "string is assigned with a boolean value",
 			data: []byte(`{
 				"version": "v1",
-				"LinuxAdminUsername": true,
-				"authConfig": {
-					"subscriptionId": "test-subscription"
+				"linux_admin_username": true,
+				"auth_config": {
+					"subscription_id": "test-subscription"
 				}
 			}`),
 			want: &aksnodeconfigv1.Configuration{
@@ -74,15 +76,15 @@ func TestUnmarshalConfigurationV1(t *testing.T) {
 					SubscriptionId: "test-subscription",
 				},
 			},
-			wantErr: false,
+			wantErr: true,
 		},
 		{
 			name: "unknown field should be ignored",
 			data: []byte(`{
 				"version": "v1",
-				"unknownField": "should be ignored",
-				"authConfig": {
-					"subscriptionId": "test-subscription"
+				"unknown_feld": "should be ignored",
+				"auth_config": {
+					"subscription_id": "test-subscription"
 				}
 			}`),
 			want: &aksnodeconfigv1.Configuration{
@@ -93,6 +95,119 @@ func TestUnmarshalConfigurationV1(t *testing.T) {
 			},
 			wantErr: false,
 		},
+		{
+			name: "valid enum values as strings",
+			data: []byte(`{
+				"version": "v1",
+				"auth_config": {
+					"subscription_id": "test-subscription"
+				},
+				"workload_runtime": "WORKLOAD_RUNTIME_OCI_CONTAINER"
+			}`),
+			want: &aksnodeconfigv1.Configuration{
+				Version: "v1",
+				AuthConfig: &aksnodeconfigv1.AuthConfig{
+					SubscriptionId: "test-subscription",
+				},
+				WorkloadRuntime: aksnodeconfigv1.WorkloadRuntime_WORKLOAD_RUNTIME_OCI_CONTAINER,
+			},
+			wantErr: false,
+		},
+		{
+			name: "unknown enum values should default to UNSPECIFIED",
+			data: []byte(`{
+				"version": "v1",
+				"auth_config": {
+					"subscription_id": "test-subscription"
+				},
+				"workload_runtime": "WHAT IS THIS?"
+			}`),
+			want: &aksnodeconfigv1.Configuration{
+				Version: "v1",
+				AuthConfig: &aksnodeconfigv1.AuthConfig{
+					SubscriptionId: "test-subscription",
+				},
+				WorkloadRuntime: aksnodeconfigv1.WorkloadRuntime_WORKLOAD_RUNTIME_UNSPECIFIED,
+			},
+			wantErr: false,
+		},
+		{
+			name: "repeated string field with wrong type is ignored",
+			data: []byte(`{
+				"version": "v1",
+				"auth_config": {
+					"subscription_id": "test-subscription"
+				},
+				"custom_ca_certs": "not-an-array"
+			}`),
+			want: &aksnodeconfigv1.Configuration{
+				Version: "v1",
+				AuthConfig: &aksnodeconfigv1.AuthConfig{
+					SubscriptionId: "test-subscription",
+				},
+			},
+			wantErr: true,
+		},
+		{
+			name: "repeated string field with mixed types parses valid elements",
+			data: []byte(`{
+				"version": "v1",
+				"auth_config": {
+					"subscription_id": "test-subscription"
+				},
+				"custom_ca_certs": ["valid-cert", 123, true]
+			}`),
+			want: &aksnodeconfigv1.Configuration{
+				Version: "v1",
+				AuthConfig: &aksnodeconfigv1.AuthConfig{
+					SubscriptionId: "test-subscription",
+				},
+				CustomCaCerts: []string{"valid-cert"},
+			},
+			wantErr: true,
+		},
+		{
+			name: "map field with wrong value type is ignored",
+			data: []byte(`{
+				"version": "v1",
+				"auth_config": {
+					"subscription_id": "test-subscription"
+				},
+				"kubelet_config": {
+					"kubelet_flags": {
+						"key1": "value1",
+						"key2": 123
+					}
+				}
+			}`),
+			want: &aksnodeconfigv1.Configuration{
+				Version: "v1",
+				AuthConfig: &aksnodeconfigv1.AuthConfig{
+					SubscriptionId: "test-subscription",
+				},
+			},
+			wantErr: true,
+		},
+		{
+			name: "optional int32 field with string value is ignored",
+			data: []byte(`{
+				"version": "v1",
+				"auth_config": {
+					"subscription_id": "test-subscription"
+				},
+				"kubelet_config": {
+					"max_pods": "42"
+				}
+			}`),
+			want: &aksnodeconfigv1.Configuration{
+				Version: "v1",
+				AuthConfig: &aksnodeconfigv1.AuthConfig{
+					SubscriptionId: "test-subscription",
+				},
+				KubeletConfig: &aksnodeconfigv1.KubeletConfig{},
+			},
+			wantErr: false,
+		},
 	}
 
 	for _, tt := range tests {
@@ -104,9 +219,9 @@ func TestUnmarshalConfigurationV1(t *testing.T) {
 			} else {
 				require.NoError(t, err)
 				// here we use proto.Equal for deep equality check
-				if !proto.Equal(tt.want, got) {
-					assert.Fail(t, "UnmarshalConfigurationV1() result mismatch", "want: %+v\n got: %+v", tt.want, got)
-				}
+			}
+			if !proto.Equal(tt.want, got) {
+				assert.Fail(t, "UnmarshalConfigurationV1() result mismatch", "want: %+v\n got: %+v", tt.want, got)
 			}
 		})
 	}
@@ -149,3 +264,16 @@ func TestUnmarshalConfigurationV1FromAJsonFile(t *testing.T) {
 		})
 	}
 }
+
+func TestMarsalConfiguratioV1(t *testing.T) {
+	cfg := &aksnodeconfigv1.Configuration{
+		Version: "v1",
+		AuthConfig: &aksnodeconfigv1.AuthConfig{
+			SubscriptionId: "test-subscription",
+		},
+		WorkloadRuntime: aksnodeconfigv1.WorkloadRuntime_WORKLOAD_RUNTIME_OCI_CONTAINER,
+	}
+	data, err := MarshalConfigurationV1(cfg)
+	require.NoError(t, err)
+	require.JSONEq(t, `{"version":"v1","auth_config":{"subscription_id":"test-subscription"}, "workload_runtime":"WORKLOAD_RUNTIME_OCI_CONTAINER"}`, string(data))
+}