Skip to content

Commit 4077d86

Browse files
committed
address comments
1 parent 9c357aa commit 4077d86

File tree

63 files changed

+137
-133
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

63 files changed

+137
-133
lines changed

parts/linux/cloud-init/artifacts/cse_config.sh

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1149,24 +1149,17 @@ EOF
11491149
}
11501150

11511151
configureManagedGPUExperience() {
1152-
if [ "$?" -ne 0 ] && [ "${GPU_NODE}" = "true" ] && [ "${skip_nvidia_driver_install}" != "true" ]; then
1153-
echo "failed to determine if managed GPU experience should be enabled by nodepool tags"
1154-
exit $ERR_LOOKUP_ENABLE_MANAGED_GPU_EXPERIENCE_TAG
1155-
elif [ "${GPU_NODE}" = "true" ] && [ "${skip_nvidia_driver_install}" != "true" ] && [ "${ENABLE_MANAGED_GPU_EXPERIENCE}" = "true" ]; then
1152+
if [ "${GPU_NODE}" = "true" ] && [ "${skip_nvidia_driver_install}" != "true" ] && [ "${ENABLE_MANAGED_GPU_EXPERIENCE}" = "true" ]; then
11561153
logs_to_events "AKS.CSE.installNvidiaManagedExpPkgFromCache" "installNvidiaManagedExpPkgFromCache" || exit $ERR_NVIDIA_DCGM_INSTALL
11571154
logs_to_events "AKS.CSE.startNvidiaManagedExpServices" "startNvidiaManagedExpServices" || exit $ERR_NVIDIA_DCGM_EXPORTER_FAIL
11581155

1159-
# Add node label to indicate DCGM exporter is enabled
1160-
DCGM_EXPORTER_LABEL="kubernetes.azure.com/dcgm-exporter=enabled"
1161-
addKubeletNodeLabel $DCGM_EXPORTER_LABEL
1156+
addKubeletNodeLabel "kubernetes.azure.com/dcgm-exporter=enabled"
11621157
elif [ "${GPU_NODE}" = "true" ] && [ "${skip_nvidia_driver_install}" != "true" ] && [ "${ENABLE_MANAGED_GPU_EXPERIENCE}" = "false" ]; then
11631158
logs_to_events "AKS.CSE.stop.nvidia-device-plugin" "systemctlDisableAndStop nvidia-device-plugin"
11641159
logs_to_events "AKS.CSE.stop.nvidia-dcgm" "systemctlDisableAndStop nvidia-dcgm"
11651160
logs_to_events "AKS.CSE.stop.nvidia-dcgm-exporter" "systemctlDisableAndStop nvidia-dcgm-exporter"
11661161

1167-
# Add node label to indicate DCGM exporter is disabled
1168-
DCGM_EXPORTER_LABEL="kubernetes.azure.com/dcgm-exporter=disabled"
1169-
addKubeletNodeLabel $DCGM_EXPORTER_LABEL
1162+
addKubeletNodeLabel "kubernetes.azure.com/dcgm-exporter=disabled"
11701163
fi
11711164
}
11721165

parts/linux/cloud-init/artifacts/cse_main.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -397,6 +397,10 @@ function nodePrep {
397397

398398
export -f enableManagedGPUExperience
399399
ENABLE_MANAGED_GPU_EXPERIENCE=$(retrycmd_silent 10 1 10 bash -cx enableManagedGPUExperience)
400+
if [ "$?" -ne 0 ] && [ "${GPU_NODE}" = "true" ] && [ "${skip_nvidia_driver_install}" != "true" ]; then
401+
echo "failed to determine if managed GPU experience should be enabled by nodepool tags"
402+
exit $ERR_LOOKUP_ENABLE_MANAGED_GPU_EXPERIENCE_TAG
403+
fi
400404
logs_to_events "AKS.CSE.configureManagedGPUExperience" configureManagedGPUExperience || exit $ERR_ENABLE_MANAGED_GPU_EXPERIENCE
401405

402406
VALIDATION_ERR=0

pkg/agent/testdata/AKSUbuntu2204+China/CustomData

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu2204+Containerd+CDI/CustomData

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu2204+Containerd+DevicePlugin/CustomData

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu2204+Containerd+MIG+ArtifactStreaming/CustomData

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu2204+Containerd+MIG/CustomData

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu2204+CustomCloud+USNat/CustomData

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu2204+CustomCloud+USSec/CustomData

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu2204+CustomCloud+ootcredentialprovider/CustomData

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)