Skip to content

Commit 592aaa2

Browse files
juan-leeganeshkumarashokrenovate[bot]
authored
feat: enable CDI in containerd configuration (#6726)
Co-authored-by: Ganeshkumar Ashokavardhanan <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 parent 1cae077 commit 592aaa2

File tree

97 files changed

+435
-91
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

97 files changed

+435
-91
lines changed

aks-node-controller/parser/helper_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,7 @@ func Test_getContainerdConfig(t *testing.T) {
383383
oom_score = -999
384384
[plugins."io.containerd.grpc.v1.cri"]
385385
sandbox_image = ""
386+
enable_cdi = true
386387
[plugins."io.containerd.grpc.v1.cri".containerd]
387388
default_runtime_name = "runc"
388389
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]
@@ -415,6 +416,7 @@ oom_score = -999
415416
oom_score = -999
416417
[plugins."io.containerd.grpc.v1.cri"]
417418
sandbox_image = ""
419+
enable_cdi = true
418420
[plugins."io.containerd.grpc.v1.cri".containerd]
419421
default_runtime_name = "nvidia-container-runtime"
420422
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.nvidia-container-runtime]
@@ -444,6 +446,7 @@ oom_score = -999
444446
oom_score = -999
445447
[plugins."io.containerd.grpc.v1.cri"]
446448
sandbox_image = ""
449+
enable_cdi = true
447450
[plugins."io.containerd.grpc.v1.cri".containerd]
448451
default_runtime_name = "runc"
449452
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]

aks-node-controller/parser/templates/containerd.toml.gtpl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ oom_score = -999{{if getHasDataDir .KubeletConfig}}
33
root = "{{.KubeletConfig.GetContainerDataDir}}"{{- end}}
44
[plugins."io.containerd.grpc.v1.cri"]
55
sandbox_image = "{{ .KubeBinaryConfig.GetPodInfraContainerImageUrl }}"
6+
enable_cdi = true
67
[plugins."io.containerd.grpc.v1.cri".containerd]
78
{{- if .TeleportConfig.GetStatus }}
89
snapshotter = "teleportd"

pkg/agent/baker.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1431,6 +1431,7 @@ oom_score = -999{{if HasDataDir }}
14311431
root = "{{GetDataDir}}"{{- end}}
14321432
[plugins."io.containerd.grpc.v1.cri"]
14331433
sandbox_image = "{{GetPodInfraContainerSpec}}"
1434+
enable_cdi = true
14341435
[plugins."io.containerd.grpc.v1.cri".containerd]
14351436
{{- if TeleportEnabled }}
14361437
snapshotter = "teleportd"

pkg/agent/baker_test.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1781,6 +1781,7 @@ testdomain567.com:53 {
17811781
oom_score = -999
17821782
[plugins."io.containerd.grpc.v1.cri"]
17831783
sandbox_image = ""
1784+
enable_cdi = true
17841785
[plugins."io.containerd.grpc.v1.cri".containerd]
17851786
snapshotter = "overlaybd"
17861787
disable_snapshot_annotations = false
@@ -1882,6 +1883,18 @@ oom_score = -999
18821883
}
18831884
config.ContainerService.Properties.AgentPoolProfiles[0].Distro = datamodel.AKSUbuntuContainerd2204
18841885
}, nil),
1886+
Entry("AKSUbuntu2204 with containerd and CDI enabled", "AKSUbuntu2204+Containerd+CDI", "1.24.2", func(config *datamodel.NodeBootstrappingConfiguration) {
1887+
config.ContainerService.Properties.AgentPoolProfiles[0].KubernetesConfig = &datamodel.KubernetesConfig{
1888+
ContainerRuntime: datamodel.Containerd,
1889+
}
1890+
config.ContainerService.Properties.AgentPoolProfiles[0].Distro = datamodel.AKSUbuntuContainerd2204
1891+
config.KubeletConfig = map[string]string{}
1892+
}, func(o *nodeBootstrappingOutput) {
1893+
Expect(o.vars["CONTAINERD_CONFIG_CONTENT"]).NotTo(BeEmpty())
1894+
containerdConfigFileContent, err := getBase64DecodedValue([]byte(o.vars["CONTAINERD_CONFIG_CONTENT"]))
1895+
Expect(err).To(BeNil())
1896+
Expect(containerdConfigFileContent).To(ContainSubstring("enable_cdi = true"))
1897+
}),
18851898
Entry("AKSUbuntu2204 containerd with multi-instance GPU", "AKSUbuntu2204+Containerd+MIG", "1.19.13",
18861899
func(config *datamodel.NodeBootstrappingConfiguration) {
18871900
config.ContainerService.Properties.AgentPoolProfiles[0].KubernetesConfig = &datamodel.KubernetesConfig{

pkg/agent/testdata/AKSUbuntu1604+Containerd/CSECommand

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu1604+CustomKubeletConfig+CustomLinuxOSConfig/CSECommand

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu1604+CustomKubeletConfig+DynamicKubeletConfig/CSECommand

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu1604+Disable1804SystemdResolved=false/CSECommand

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu1604+Disable1804SystemdResolved=true/CSECommand

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

pkg/agent/testdata/AKSUbuntu1604+Docker/CSECommand

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)