Skip to content

Commit aeebf07

Browse files
authored
remove criticalhostsentries from e2e
1 parent 848a672 commit aeebf07

File tree

1 file changed

+0
-27
lines changed

1 file changed

+0
-27
lines changed

e2e/node_config.go

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -142,22 +142,6 @@ func getBaseNBC(t testing.TB, cluster *Cluster, vhd *config.Image) (*datamodel.N
142142
return nbc, nil
143143
}
144144

145-
// convertCriticalHostsEntriesToProto converts the NBC LocalDNSProfile CriticalHostsEntries
146-
// (map[string][]string) to the proto CriticalHostsEntries (map[string]*CriticalHostsEntry).
147-
// Returns nil if the profile or entries are nil/empty.
148-
func convertCriticalHostsEntriesToProto(profile *datamodel.AgentPoolProfile) map[string]*aksnodeconfigv1.CriticalHostsEntry {
149-
if profile == nil || profile.LocalDNSProfile == nil || len(profile.LocalDNSProfile.CriticalHostsEntries) == 0 {
150-
return nil
151-
}
152-
result := make(map[string]*aksnodeconfigv1.CriticalHostsEntry, len(profile.LocalDNSProfile.CriticalHostsEntries))
153-
for fqdn, ips := range profile.LocalDNSProfile.CriticalHostsEntries {
154-
result[fqdn] = &aksnodeconfigv1.CriticalHostsEntry{
155-
IpAddresses: ips,
156-
}
157-
}
158-
return result
159-
}
160-
161145
// is a temporary workaround
162146
// eventually we want to phase out usage of nbc
163147
func nbcToAKSNodeConfigV1(nbc *datamodel.NodeBootstrappingConfiguration) *aksnodeconfigv1.Configuration {
@@ -232,7 +216,6 @@ func nbcToAKSNodeConfigV1(nbc *datamodel.NodeBootstrappingConfiguration) *aksnod
232216
EnableLocalDns: true,
233217
CpuLimitInMilliCores: to.Ptr(int32(2008)),
234218
MemoryLimitInMb: to.Ptr(int32(256)),
235-
CriticalHostsEntries: convertCriticalHostsEntriesToProto(nbc.AgentPoolProfile),
236219
VnetDnsOverrides: map[string]*aksnodeconfigv1.LocalDnsOverrides{
237220
".": {
238221
QueryLogging: "Log",
@@ -468,11 +451,6 @@ func baseTemplateLinux(t testing.TB, location string, k8sVersion string, arch st
468451
EnableLocalDNS: true,
469452
CPULimitInMilliCores: to.Ptr(int32(2008)),
470453
MemoryLimitInMB: to.Ptr(int32(128)),
471-
CriticalHostsEntries: map[string][]string{
472-
"mcr.microsoft.com": {"20.61.99.68", "2603:1061:1002::2"},
473-
"login.microsoftonline.com": {"20.190.160.1"},
474-
"acs-mirror.azureedge.net": {"152.199.19.161"},
475-
},
476454
VnetDNSOverrides: map[string]*datamodel.LocalDNSOverrides{
477455
".": {
478456
QueryLogging: "Log",
@@ -622,11 +600,6 @@ func baseTemplateLinux(t testing.TB, location string, k8sVersion string, arch st
622600
EnableLocalDNS: true,
623601
CPULimitInMilliCores: to.Ptr(int32(2008)),
624602
MemoryLimitInMB: to.Ptr(int32(128)),
625-
CriticalHostsEntries: map[string][]string{
626-
"mcr.microsoft.com": {"20.61.99.68", "2603:1061:1002::2"},
627-
"login.microsoftonline.com": {"20.190.160.1"},
628-
"acs-mirror.azureedge.net": {"152.199.19.161"},
629-
},
630603
VnetDNSOverrides: map[string]*datamodel.LocalDNSOverrides{
631604
".": {
632605
QueryLogging: "Log",

0 commit comments

Comments
 (0)