Skip to content

Commit e493603

Browse files
authored
fix: log aks-node-controller arguments and update readme (#7595)
1 parent 01ab164 commit e493603

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

aks-node-controller/README.md

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,21 @@ Clients need to provide CSE and Custom Data. [nodeconfigutils](pkg/nodeconfiguti
109109
```mermaid
110110
sequenceDiagram
111111
participant Client as Client
112-
participant ARM as Azure Resource Manager (ARM)
113-
participant VM as Virtual Machine (VM)
112+
participant AgentBaker as Versioned AgentBaker Services<br/>(Deprecated)
113+
participant ARM as Azure Resource Manager<br/>(ARM)
114+
participant VM as Virtual Machine<br/>(VM)
114115
115-
Client->>ARM: Request to create VM<br/>with CustomData & CSE
116+
Client -x AgentBaker: ~~Request artifacts for<br/> node provisioning~~ (deprecated)
117+
note over Client, AgentBaker: Scriptless no longer needs the 26+ absvc pods.<br/> Instead it uses one AgentBaker service that keeps<br/> providing the latest SIG images list (not shown).
118+
119+
AgentBaker-->>Client: ~~Provide "CSE command<br/> & provisioning scripts"~~ (deprecated)
120+
121+
Client->>ARM: Request to create VM<br/>with CustomData & CSE<br/>(using AgentBaker artifacts)
116122
ARM->>VM: Deploy config.json<br/>(CustomData)
117123
note over VM: cloud-init handles<br/>config.json deployment
118124
119125
note over VM: cloud-init completes processing
120-
note over VM: Start aks-node-controller.service (systemd service)<br/> after cloud-init
126+
note over VM: Start aks-node-controller.service (systemd service)<br/>after cloud-init
121127
VM->>VM: Run aks-node-controller<br/>(Go binary) in provision mode<br/>using config.json
122128
123129
ARM->>VM: Initiate aks-node-controller (Go binary)<br/>in provision-wait mode via CSE
@@ -126,7 +132,7 @@ sequenceDiagram
126132
VM->>VM: Check /opt/azure/containers/provision.complete
127133
end
128134
129-
VM->>Client: Return CSE status with<br/>/var/log/azure/aks/provision.json content
135+
VM-->>Client: Return CSE status with<br/>/var/log/azure/aks/provision.json content
130136
```
131137

132138
Key components:

aks-node-controller/app.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ type ProvisionStatusFiles struct {
4343
}
4444

4545
func (a *App) Run(ctx context.Context, args []string) int {
46-
slog.Info("aks-node-controller started")
46+
slog.Info("aks-node-controller started", "args", args)
4747
err := a.run(ctx, args)
4848
exitCode := errToExitCode(err)
4949
if exitCode == 0 {
50-
slog.Info("aks-node-controller finished successfully")
50+
slog.Info("aks-node-controller finished successfully.")
5151
} else {
5252
slog.Error("aks-node-controller failed", "error", err)
5353
}

0 commit comments

Comments
 (0)