update

Author: zhiyuanliang-ms

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationExtensions.cs

@@ -15,7 +15,7 @@ namespace Microsoft.Extensions.Configuration
     /// </summary>
     public static class AzureAppConfigurationExtensions
     {
-        private static readonly bool _isProviderDisabled = ProviderToggleChecker.IsProviderDisabled();
+        private static readonly bool _isProviderDisabled = EnvironmentVariableHelper.GetBoolOrDefault(EnvironmentVariableNames.AppConfigurationProviderDisabled);
 
         /// <summary>
         /// Adds key-value data from an Azure App Configuration store to a configuration builder using its connection string.

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationHealthChecksBuilderExtensions.cs

@@ -14,7 +14,7 @@ namespace Microsoft.Extensions.DependencyInjection
     /// </summary>
     public static class AzureAppConfigurationHealthChecksBuilderExtensions
     {
-        private static readonly bool _isProviderDisabled = ProviderToggleChecker.IsProviderDisabled();
+        private static readonly bool _isProviderDisabled = EnvironmentVariableHelper.GetBoolOrDefault(EnvironmentVariableNames.AppConfigurationProviderDisabled);
 
         /// <summary>
         /// Add a health check for Azure App Configuration to given <paramref name="builder"/>.

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs

@@ -16,7 +16,6 @@
 using System.Net;
 using System.Net.Http;
 using System.Net.Sockets;
-using System.Security;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
@@ -143,15 +142,7 @@ public AzureAppConfigurationProvider(IConfigurationClientManager configClientMan
                 MinRefreshInterval = RefreshConstants.DefaultRefreshInterval;
             }
 
-            // Enable request tracing if not opt-out
-            string requestTracingDisabled = null;
-            try
-            {
-                requestTracingDisabled = Environment.GetEnvironmentVariable(EnvironmentVariableNames.RequestTracingDisabled);
-            }
-            catch (SecurityException) { }
-
-            _requestTracingEnabled = bool.TryParse(requestTracingDisabled, out bool tracingDisabled) ? !tracingDisabled : true;
+            _requestTracingEnabled = !EnvironmentVariableHelper.GetBoolOrDefault(EnvironmentVariableNames.RequestTracingDisabled);
 
             if (_requestTracingEnabled)
             {

…ppConfiguration/ProviderToggleChecker.cs …nfiguration/EnvironmentVariableHelper.cssrc/Microsoft.Extensions.Configuration.AzureAppConfiguration/ProviderToggleChecker.cs renamed to src/Microsoft.Extensions.Configuration.AzureAppConfiguration/EnvironmentVariableHelper.cs src/Microsoft.Extensions.Configuration.AzureAppConfiguration/ProviderToggleChecker.cs renamed to src/Microsoft.Extensions.Configuration.AzureAppConfiguration/EnvironmentVariableHelper.cs

@@ -7,13 +7,13 @@
 
 namespace Microsoft.Extensions.Configuration.AzureAppConfiguration
 {
-    internal static class ProviderToggleChecker
+    internal static class EnvironmentVariableHelper
     {
-        public static bool IsProviderDisabled()
+        public static bool GetBoolOrDefault(string variableName)
         {
             try
             {
-                return bool.TryParse(Environment.GetEnvironmentVariable(EnvironmentVariableNames.AppConfigurationProviderDisabled), out bool disabled) ? disabled : false;
+                return bool.TryParse(Environment.GetEnvironmentVariable(variableName), out bool disabled) ? disabled : false;
             }
             catch (SecurityException) { }
 

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureManagementKeyValueAdapter.cs

@@ -27,15 +27,7 @@ public FeatureManagementKeyValueAdapter(FeatureFlagTracing featureFlagTracing)
         {
             _featureFlagTracing = featureFlagTracing ?? throw new ArgumentNullException(nameof(featureFlagTracing));
 
-            string fmSchemaCompatibilityDisabled = null;
-
-            try
-            {
-                fmSchemaCompatibilityDisabled = Environment.GetEnvironmentVariable(EnvironmentVariableNames.FmSchemacompatibilityDisabled);
-            }
-            catch (SecurityException) { }
-
-            _fmSchemaCompatibilityDisabled = bool.TryParse(fmSchemaCompatibilityDisabled, out bool disabled) ? disabled : false;
+            _fmSchemaCompatibilityDisabled = EnvironmentVariableHelper.GetBoolOrDefault(EnvironmentVariableNames.FmSchemacompatibilityDisabled);
         }
 
         public Task<IEnumerable<KeyValuePair<string, string>>> ProcessKeyValue(ConfigurationSetting setting, Uri endpoint, Logger logger, CancellationToken cancellationToken)