support unconfigured lb (#140)

Author: mbrat2005

AzureBasicLoadBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/AzureBasicLoadBalancerUpgrade.psd1

@@ -12,7 +12,7 @@
     RootModule = 'AzureBasicLoadBalancerUpgrade'
 
     # Version number of this module.
-    ModuleVersion = '2.4.22'
+    ModuleVersion = '2.4.23'
 
     # Supported PSEditions
     # CompatiblePSEditions = @()
@@ -107,7 +107,7 @@
             # IconUri = ''
 
             # ReleaseNotes of this module
-            ReleaseNotes = 'Added validation check for customers using floating IP and non-primary IP configurations.'
+            ReleaseNotes = 'Added support for basic LBs with no child resources.'
 
             # Prerelease string of this module
             # Prerelease = 'beta'

AzureBasicLoadBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/modules/Start-AzBasicLoadBalancerUpgrade/Start-AzBasicLoadBalancerUpgrade.psm1

@@ -439,8 +439,19 @@ function Start-AzBasicLoadBalancerUpgrade {
                             RestoreExternalLBMigrationEmpty @standardScenarioParams
                         }
                     }
+                    'none' {
+                        if ((!$PSBoundParameters.ContainsKey("FailedMigrationRetryFilePathLB"))) {
+                            InternalLBMigrationEmpty @standardScenarioParams -RecoveryBackupPath $RecoveryBackupPath
+                        }
+                        else {
+                            RestoreInternalLBMigrationEmpty @standardScenarioParams
+                        }
+                    }
                 }
             }
+            default {
+                log -Severity 'Error' -Message "[Start-AzBasicLoadBalancerUpgrade] Unexpected backend type '$($migrationConfig.scenario.ExternalOrInternal)' for Basic Load Balancer '$($migrationConfig.BasicLoadBalancer.Name)' in Resource Group '$($migrationConfig.BasicLoadBalancer.ResourceGroupName)'. Migration failed." -terminateOnError
+            }
         }
 
         $migrationConfigsCompleted++

AzureBasicLoadBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/modules/ValidateScenario/ValidateScenario.psm1

@@ -156,7 +156,11 @@ Function Test-SupportedMigrationScenario {
 
     # detecting if source load balancer is internal or external-facing
     log -Message "[Test-SupportedMigrationScenario] Determining if LB is internal or external based on FrontEndIPConfiguration[0]'s IP configuration"
-    If (![string]::IsNullOrEmpty($BasicLoadBalancer.FrontendIpConfigurations[0].PrivateIpAddress)) {
+    If ([string]::IsNullOrEmpty($BasicLoadBalancer.FrontendIpConfigurations[0])) {
+        log -Message "[Test-SupportedMigrationScenario] FrontEndIPConfiguiration[0] is empty--this load balancer has no configuration (sigh)."
+        $scenario.ExternalOrInternal = 'None'
+    }
+    ElseIf (![string]::IsNullOrEmpty($BasicLoadBalancer.FrontendIpConfigurations[0].PrivateIpAddress)) {
         log -Message "[Test-SupportedMigrationScenario] FrontEndIPConfiguiration[0] is assigned a private IP address '$($BasicLoadBalancer.FrontendIpConfigurations[0].PrivateIpAddress)', so this LB is Internal"
         $scenario.ExternalOrInternal = 'Internal'
     }

AzureBasicLoadBalancerUpgrade/testEnvs/scenarios/044-basic-lb-int-empty-bes-no-fe.bicep

@@ -0,0 +1,43 @@
+targetScope = 'resourceGroup'
+param randomGuid string = newGuid()
+param location string
+param resourceGroupName string
+
+// vnet
+module virtualNetworks '../modules/Microsoft.Network/virtualNetworks/deploy.bicep' = {
+  name: '${uniqueString(deployment().name)}-virtualNetworks'
+  scope: resourceGroup(resourceGroupName)
+  params: {
+    // Required parameters
+    location: location
+    addressPrefixes: [
+      '10.0.0.0/16'
+    ]
+    name: 'vnet-01'
+    subnets: [
+      {
+        name: 'subnet-01'
+        addressPrefix: '10.0.1.0/24'
+      }
+    ]
+  }
+  dependsOn: [
+  ]
+}
+
+// basic lb
+resource loadbalancer_emptyfe 'Microsoft.Network/loadBalancers@2024-05-01' = {
+  name: 'lb-basic-01'
+  location: location
+  sku: {
+    name: 'Basic'
+  }
+  properties: {
+    frontendIPConfigurations: []
+    backendAddressPools: []
+    inboundNatRules: []
+    loadBalancingRules: []
+    probes: [] 
+    
+  }
+}

AzureBasicLoadBalancerUpgrade/testEnvs/scripts/deploy.ps1

@@ -136,7 +136,19 @@ $jobs = @()
 ForEach ($resourceGroupSuffixI in $resourceGroupSuffix) {
     foreach ($template in $filteredTemplates) {
         $rgTemplateName = "rg-{0}{1}-{2}" -f $template.BaseName.split('-')[0], $resourceGroupSuffixI, $template.BaseName.split('-', 2)[1]
-        if ($template.FullName -like "*.bicep") {
+        if ($template.Name -match "(019|044)-") {
+
+            $params = @{
+                Name         = "vmss-lb-deployment-$((get-date).tofiletime())"
+                TemplateFile = $template.FullName
+                Location    = $Location
+                resourceGroupNameFromTemplate = $rgTemplateName
+            }
+            $null = New-AzResourceGroup -Name $rgTemplateName -Location $Location -Force -ErrorAction SilentlyContinue
+            $jobs += New-AzResourceGroupDeployment -ResourceGroupName $rgTemplateName @params -AsJob
+        }
+
+        elseif ($template.FullName -like "*.bicep") {
             $params = @{
                 Name                    = "vmss-lb-deployment-$((get-date).tofiletime())"
                 TemplateFile            = $template.FullName
@@ -151,16 +163,6 @@ ForEach ($resourceGroupSuffixI in $resourceGroupSuffix) {
             $jobs += $job
         }
 
-        elseif ($template.Name -like "019*.json") {
-
-            $params = @{
-                Name         = "vmss-lb-deployment-$((get-date).tofiletime())"
-                TemplateFile = $template.FullName
-            }
-            $null = New-AzResourceGroup -Name $rgTemplateName -Location $Location -Force -ErrorAction SilentlyContinue
-            $jobs += New-AzResourceGroupDeployment -ResourceGroupName $rgTemplateName @params -AsJob
-        }
-
         elseif ($template.Name -like "*.json") {
             $params = @{
                 Name                    = "vmss-lb-deployment-$((get-date).tofiletime())"