fix: json

Author: kaixuanxu

.github/actions/validate-template/action.yml

@@ -1,28 +1,28 @@
 name: Validate template
-
 description: Validate ADF template
 
 inputs:
   path:
     required: true
-    description: Project root
+    description: Project root path
   directory:
     required: false
     description: Template directory
+    default: ''
 
 outputs:
   status:
-    description: Validate status
+    description: Validation exit code (0 = success, non-zero = failure)
     value: ${{ steps.validate-template.outputs.status }}
   detail:
-    description: Validate detail
+    description: Validation details or error message
     value: ${{ steps.validate-template.outputs.detail }}
 
 runs:
   using: composite
   steps:
     - name: Setup Deno environment
-      uses: denoland/setup-deno@v1
+      uses: denoland/setup-deno@v2
       with:
         deno-version: v1.x
 
@@ -31,12 +31,41 @@ runs:
       env:
         INPUT_PATH: ${{ inputs.path }}
         INPUT_DIRECTORY: ${{ inputs.directory }}
-        ACTION_PATH: ${{ github.action_path }}
       shell: bash
       run: |
-        result=$(deno run --allow-read "${ACTION_PATH}/src/main.ts" "${INPUT_PATH}" "${INPUT_DIRECTORY}")
-        # Parse JSON and extract status and detail separately
-        status=$(echo "$result" | jq -r '.status')
-        detail=$(echo "$result" | jq -r '.detail')
+        set -euo pipefail
+        
+        # Run validation script
+        if ! result=$(deno run --allow-read "${{ github.action_path }}/src/main.ts" "${INPUT_PATH}" "${INPUT_DIRECTORY}" 2>&1); then
+          echo "status=1" >> "$GITHUB_OUTPUT"
+          # Handle multi-line error output using heredoc
+          {
+            echo "detail<<EOF"
+            echo "Deno execution failed: ${result}"
+            echo "EOF"
+          } >> "$GITHUB_OUTPUT"
+          exit 0  # Don't fail the step, let caller handle status
+        fi
+        
+        # Validate JSON output
+        if ! echo "$result" | jq empty 2>/dev/null; then
+          echo "status=1" >> "$GITHUB_OUTPUT"
+          {
+            echo "detail<<EOF"
+            echo "Invalid JSON output from validation script: ${result}"
+            echo "EOF"
+          } >> "$GITHUB_OUTPUT"
+          exit 0
+        fi
+        
+        # Extract status and detail from JSON response
+        status=$(echo "$result" | jq -r '.status // 1')
+        detail=$(echo "$result" | jq -r '.detail // "No details provided"')
+        
         echo "status=${status}" >> "$GITHUB_OUTPUT"
-        echo "detail=${detail}" >> "$GITHUB_OUTPUT"
+        # Handle potential multi-line detail content
+        {
+          echo "detail<<EOF"
+          echo "${detail}"
+          echo "EOF"
+        } >> "$GITHUB_OUTPUT"

.github/workflows/validate-template.yml

@@ -1,27 +1,46 @@
 name: Template Validation
+
 on:
   pull_request_target:
     branches:
       - main
+    types: [opened, synchronize, reopened]
 
   workflow_dispatch:
 
+permissions:
+  contents: read
+  pull-requests: write
+
 jobs:
   validate:
     runs-on: ubuntu-latest
+    timeout-minutes: 10
 
     steps:
-      - uses: actions/checkout@v2
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
 
       - name: Validate template
         id: validate-template
         uses: ./.github/actions/validate-template
         with:
-          path: $GITHUB_WORKSPACE
+          path: ${{ github.workspace }}
 
-      - name: Create comment
-        if: ${{ steps.validate-template.outputs.status != 0 && !github.event.pull_request.head.repo.fork }}
-        uses: peter-evans/create-or-update-comment@v1
+      - name: Create or update comment on failure
+        if: ${{ steps.validate-template.outputs.status != '0' && github.event_name == 'pull_request_target' && !github.event.pull_request.head.repo.fork }}
+        uses: peter-evans/create-or-update-comment@v4
         with:
           issue-number: ${{ github.event.pull_request.number }}
-          body: ${{ steps.validate-template.outputs.detail }}
+          body: |
+            ## ❌ Template Validation Failed
+            
+            ${{ steps.validate-template.outputs.detail }}
+
+      - name: Fail workflow if validation failed
+        if: ${{ steps.validate-template.outputs.status != '0' }}
+        run: |
+          echo "::error::Template validation failed"
+          exit 1