Skip to content

Commit 1cbc279

Browse files
author
kaixuanxu
committed
chore: fix sec, remove key
1 parent de79bcb commit 1cbc279

File tree

2 files changed

+6
-23
lines changed

2 files changed

+6
-23
lines changed

.github/actions/validate-template/action.yml

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,6 @@ inputs:
1010
required: false
1111
description: Template directory
1212

13-
outputs:
14-
status:
15-
description: Validate status
16-
value: ${{ steps.validate-template.outputs.status }}
17-
detail:
18-
description: Validate detail
19-
value: ${{ steps.validate-template.outputs.detail }}
20-
2113
runs:
2214
using: composite
2315
steps:
@@ -38,16 +30,15 @@ runs:
3830
# Parse JSON and extract status and detail separately
3931
status=$(echo "$result" | jq -r '.status')
4032
detail=$(echo "$result" | jq -r '.detail')
41-
# Print for debugging
33+
# Print validation result
4234
echo "::group::Validation Result"
4335
echo "Status: ${status}"
4436
echo "Detail:"
4537
echo "$detail"
4638
echo "::endgroup::"
47-
# Output status and detail
48-
echo "status=${status}" >> "$GITHUB_OUTPUT"
49-
{
50-
echo "detail<<EOF"
39+
# If status is not 0, fail the action
40+
if [ "$status" != "0" ]; then
41+
echo "::error::Template validation failed"
5142
echo "$detail"
52-
echo "EOF"
53-
} >> "$GITHUB_OUTPUT"
43+
exit 1
44+
fi

.github/workflows/validate-template.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,6 @@ jobs:
1414
- uses: actions/checkout@v2
1515

1616
- name: Validate template
17-
id: validate-template
1817
uses: ./.github/actions/validate-template
1918
with:
2019
path: ${{ github.workspace }}
21-
22-
- name: Create comment
23-
if: ${{ steps.validate-template.outputs.status != 0 && !github.event.pull_request.head.repo.fork }}
24-
uses: peter-evans/create-or-update-comment@v1
25-
with:
26-
issue-number: ${{ github.event.pull_request.number }}
27-
body: ${{ steps.validate-template.outputs.detail }}

0 commit comments

Comments
 (0)