Skip to content

Commit fde47c2

Browse files
committed
Merge branch 'master' into v-rusraut/InfobloxCloud,InfobloxSOC-DCRemove
2 parents 6a97ba9 + b944d75 commit fde47c2

File tree

10 files changed

+25
-21
lines changed

10 files changed

+25
-21
lines changed

.github/workflows/detection-template-schema-validations.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
workflow_dispatch:
99
jobs:
1010
DetectionTemplateSchemaValidation:
11-
runs-on: ubuntu-latest
11+
runs-on: ubuntu-22.04
1212
env:
1313
buildConfiguration: Release
1414
dotnetSdkVersion: 3.1.401

.github/workflows/non-ascii-validations.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
workflow_dispatch:
1010
jobs:
1111
NonAsciiValidations:
12-
runs-on: ubuntu-latest
12+
runs-on: ubuntu-22.04
1313
env:
1414
buildConfiguration: Release
1515
dotnetSdkVersion: 3.1.401

.script/tests/asimParsersTest/ASimFilteringTest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
# Workspace ID for the Log Analytics workspace where the ASim filtering tests will be performed.
1919
WORKSPACE_ID = "e9beceee-7d61-429f-a177-ee5e2b7f481a"
2020
# Timespan for the parser query
21-
TIME_SPAN_IN_DAYS = 7
21+
TIME_SPAN_IN_DAYS = 2
2222

2323
# exclusion_file_path refers to the CSV file path containing a list of parsers. Despite failing tests, these parsers will not cause the overall workflow to fail
2424
exclusion_file_path = '.script/tests/asimParsersTest/ExclusionListForASimTests.csv'
@@ -309,6 +309,7 @@ def main():
309309
if parser_file['EquivalentBuiltInParser'] in read_exclusion_list_from_csv():
310310
print(f"{YELLOW}The parser {parser_file_path} is listed in the exclusions file. Therefore, this workflow run will not fail because of it. To allow this parser to cause the workflow to fail, please remove its name from the exclusions list file located at: {exclusion_file_path}{RESET}")
311311
sys.stdout.flush()
312+
continue
312313
# Check for exception cases where the failure can be ignored
313314
# Check if the failure message and schema match the exception cases
314315
if len(result.failures) == 1:

.script/tests/asimParsersTest/VerifyASimParserTemplate.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,10 @@ def extract_and_check_properties(Parser_file, Union_Parser__file, FileType, Pars
125125
if match:
126126
event_product = match.group(1)
127127
results.append((event_product, '"EventProduct" field is mapped in parser', 'Pass'))
128+
# if equivalent_built_in_parser end with Native, then use 'EventProduct' as SchemaName + 'NativeTable'
129+
elif equivalent_built_in_parser.endswith('_Native'):
130+
event_product = 'NativeTable'
131+
results.append((event_product, '"EventProduct" field is not required since this is a native table parser. Static value will be used for "EventProduct".', 'Pass'))
128132
# If 'EventProduct' was not found in the KQL query, add to results
129133
else:
130134
results.append((f'{RED}EventProduct{RESET}', f'{RED}"EventProduct" field not mapped in parser. Please map it in parser query.{RESET}', f'{RED}Fail{RESET}'))
@@ -136,6 +140,10 @@ def extract_and_check_properties(Parser_file, Union_Parser__file, FileType, Pars
136140
if match:
137141
event_vendor = match.group(1)
138142
results.append((event_vendor, '"EventVendor" field is mapped in parser', 'Pass'))
143+
# if equivalent_built_in_parser end with Native, then use 'EventVendor' as 'Microsoft'
144+
elif equivalent_built_in_parser.endswith('_Native'):
145+
event_vendor = 'Microsoft'
146+
results.append((event_vendor, '"EventVendor" field is not required since this is a native table parser. Static value will be used for "EventVendor".', 'Pass'))
139147
# If 'EventVendor' was not found in the KQL query, add to results
140148
else:
141149
results.append((f'{RED}EventVendor{RESET}', f'{RED}"EventVendor" field not mapped in parser. Please map it in parser query.{RESET}', f'{RED}Fail{RESET}'))

.script/tests/asimParsersTest/ingestASimSampleData.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,18 @@ def extract_event_vendor_product(parser_query,parser_file):
259259
match = re.search(r'EventVendor\s*=\s*[\'"]([^\'"]+)[\'"]', parser_query)
260260
if match:
261261
event_vendor = match.group(1)
262+
# if equivalent_built_in_parser end with Native, then use 'EventVendor' as 'Microsoft'
263+
elif equivalent_built_in_parser.endswith('_Native'):
264+
event_vendor = 'Microsoft'
262265
else:
263266
print(f'EventVendor field not mapped in parser. Please map it in parser query.{parser_file}')
264267

265268
match = re.search(r'EventProduct\s*=\s*[\'"]([^\'"]+)[\'"]', parser_query)
266269
if match:
267270
event_product = match.group(1)
271+
# if equivalent_built_in_parser end with Native, then use 'EventProduct' as SchemaName + 'NativeTable'
272+
elif equivalent_built_in_parser.endswith('_Native'):
273+
event_product = 'NativeTable'
268274
else:
269275
print(f'Event Product field not mapped in parser. Please map it in parser query.{parser_file}')
270276
return event_vendor, event_product ,schema_name
@@ -332,6 +338,7 @@ def convert_data_type(schema_result, data_result):
332338
parser_query = asim_parser.get('ParserQuery', '')
333339
normalization = asim_parser.get('Normalization', {})
334340
schema = normalization.get('Schema')
341+
equivalent_built_in_parser = asim_parser.get('EquivalentBuiltInParser')
335342
event_vendor, event_product, schema_name = extract_event_vendor_product(parser_query, file)
336343

337344
SampleDataFile = f'{event_vendor}_{event_product}_{schema}_IngestedLogs.csv'
-4 Bytes
Binary file not shown.

Solutions/Check Point CloudGuard CNAPP/Package/mainTemplate.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"_email": "[variables('email')]",
4949
"_solutionName": "Check Point CloudGuard CNAPP",
5050
"_solutionVersion": "3.0.0",
51-
"solutionId": "checkpoint-cloudguard.checkpoint-sentinel-solutions-cloud-guard",
51+
"solutionId": "checkpoint.checkpoint-sentinel-solutions-cloud-guard",
5252
"_solutionId": "[variables('solutionId')]",
5353
"workspaceResourceId": "[resourceId('microsoft.OperationalInsights/Workspaces', parameters('workspace'))]",
5454
"dataConnectorCCPVersion": "1.0.0",

Solutions/Check Point CloudGuard CNAPP/SolutionMetadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"publisherId": "checkpoint-cloudguard",
2+
"publisherId": "checkpoint",
33
"offerId": "checkpoint-sentinel-solutions-cloud-guard",
44
"firstPublishDate": "2024-11-12",
55
"providers": [

Tools/Sentinel-All-In-One/v2/LinkedTemplates/solutionsAndAlerts.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
},
9797
{
9898
"dependsOn": [
99-
"[resourceId('Microsoft.ManagedIdentity/userAssignedIdentities', variables('identityName'))]"
99+
"[resourceId('Microsoft.Authorization/roleAssignments', variables('roleGuidId'))]"
100100
],
101101
"type": "Microsoft.Resources/deploymentScripts",
102102
"apiVersion": "2020-10-01",
@@ -122,4 +122,4 @@
122122
}
123123
],
124124
"outputs": {}
125-
}
125+
}

Workbooks/WorkbooksMetadata.json

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1066,7 +1066,6 @@
10661066
"CommonSecurityLog"
10671067
],
10681068
"dataConnectorsDependencies": [
1069-
"TrendMicro",
10701069
"CefAma"
10711070
],
10721071
"previewImagesFileNames": [
@@ -1087,7 +1086,6 @@
10871086
"CommonSecurityLog"
10881087
],
10891088
"dataConnectorsDependencies": [
1090-
"TrendMicro",
10911089
"CefAma"
10921090
],
10931091
"previewImagesFileNames": [
@@ -1133,7 +1131,6 @@
11331131
"Syslog"
11341132
],
11351133
"dataConnectorsDependencies": [
1136-
"BarracudaCloudFirewall",
11371134
"SyslogAma"
11381135
],
11391136
"previewImagesFileNames": [
@@ -1601,7 +1598,6 @@
16011598
"Syslog"
16021599
],
16031600
"dataConnectorsDependencies": [
1604-
"SymantecProxySG",
16051601
"SyslogAma"
16061602
],
16071603
"previewImagesFileNames": [
@@ -3681,7 +3677,6 @@
36813677
"CommonSecurityLog"
36823678
],
36833679
"dataConnectorsDependencies": [
3684-
"AristaAwakeSecurity",
36853680
"CefAma"
36863681
],
36873682
"previewImagesFileNames": [
@@ -3973,8 +3968,6 @@
39733968
"CommonSecurityLog"
39743969
],
39753970
"dataConnectorsDependencies": [
3976-
"InfobloxCloudDataConnector",
3977-
"InfobloxCloudDataConnectorAma",
39783971
"CefAma"
39793972
],
39803973
"previewImagesFileNames": [
@@ -4104,7 +4097,7 @@
41044097
"SecurityBridgeLogs"
41054098
],
41064099
"dataConnectorsDependencies": [
4107-
"SecurityBridgeSAP"
4100+
"CustomLogsAma"
41084101
],
41094102
"previewImagesFileNames": [
41104103
""
@@ -4166,7 +4159,6 @@
41664159
"McAfeeEPOEvent"
41674160
],
41684161
"dataConnectorsDependencies": [
4169-
"McAfeeePO",
41704162
"SyslogAma"
41714163
],
41724164
"previewImagesFileNames": [
@@ -4642,7 +4634,6 @@
46424634
"DigitalGuardianDLPEvent"
46434635
],
46444636
"dataConnectorsDependencies": [
4645-
"DigitalGuardianDLP",
46464637
"SyslogAma"
46474638
],
46484639
"previewImagesFileNames": [
@@ -4703,7 +4694,6 @@
47034694
"Syslog"
47044695
],
47054696
"dataConnectorsDependencies": [
4706-
"CiscoWSA",
47074697
"SyslogAma"
47084698
],
47094699
"previewImagesFileNames": [
@@ -5790,7 +5780,6 @@
57905780
"description": "A workbook providing insights into malware and C2 activity detected by iboss.",
57915781
"dataTypesDependencies": [],
57925782
"dataConnectorsDependencies": [
5793-
"ibossAma",
57945783
"CefAma"
57955784
],
57965785
"previewImagesFileNames": [
@@ -5808,7 +5797,6 @@
58085797
"description": "A workbook providing insights into web usage activity detected by iboss.",
58095798
"dataTypesDependencies": [],
58105799
"dataConnectorsDependencies": [
5811-
"ibossAma",
58125800
"CefAma"
58135801
],
58145802
"previewImagesFileNames": [
@@ -7944,7 +7932,7 @@
79447932
"Infoblox_Config_Insight_Details_CL"
79457933
],
79467934
"dataConnectorsDependencies": [
7947-
"InfobloxCloudDataConnectorAma",
7935+
"CefAma",
79487936
"InfobloxSOCInsightsDataConnector_AMA",
79497937
"InfobloxSOCInsightsDataConnector_API",
79507938
"InfobloxSOCInsightsDataConnector_Legacy"

0 commit comments

Comments
 (0)