Cisco umbrella playbook changes and repackage#11603
Merged
Conversation
rahul0216
reviewed
Dec 30, 2024
Collaborator
rahul0216
left a comment
There was a problem hiding this comment.
Changes mostly looks good. There are few spelling mistakes in readme files. Please correct those.
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AddIpToDestinationList/readme.md
Outdated
Show resolved
Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AddIpToDestinationList/readme.md
Outdated
Show resolved
Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AssignPolicyToIdentity/readme.md
Outdated
Show resolved
Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-GetDomainInfo/readme.md
Outdated
Show resolved
Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AddIpToDestinationList/readme.md
Outdated
Show resolved
Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-GetDomainInfo/readme.md
Outdated
Show resolved
Hide resolved
rahul0216
reviewed
Dec 30, 2024
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-GetDomainInfo/readme.md
Outdated
Show resolved
Hide resolved
rahul0216
previously approved these changes
Dec 30, 2024
Collaborator
rahul0216
left a comment
There was a problem hiding this comment.
Thanks for the changes. Approved.
…ction YAML files." This reverts commit a2a35d1.
…Azure-Sentinel" This reverts commit 55a9e90, reversing changes made to 890bef0.
…ure-Sentinel into cisco_umbrella_playbook
…ction YAML files." This reverts commit df084bd.
v-dvedak
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Playbook version changes for below 3 playbooks. Re-structrucing of folders, update readme for all playbooks with images.
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: