Skip to content

Net clean updates#11640

Merged
v-atulyadav merged 13 commits intoAzure:masterfrom
NCstevenB:NetCleanUpdates
Jan 30, 2025
Merged

Net clean updates#11640
v-atulyadav merged 13 commits intoAzure:masterfrom
NCstevenB:NetCleanUpdates

Conversation

@NCstevenB
Copy link
Contributor

@NCstevenB NCstevenB commented Jan 8, 2025

Required items, please complete

Change(s):

  • .script/tests/KqlvalidationsTests/CustomTables/Netclean_Incidents_CL.json
  • Sample Data/Custom/Netclean_Incidents_CL.json
  • Solutions/NetClean ProActive/Analytic Rules/NetClean_Sentinel_analytic_rule.yaml
  • Solutions/NetClean ProActive/Data Connectors/Connector_NetClean.json
  • Solutions/NetClean ProActive/Workbooks/NetCleanProActiveWorkbook.json

Reason for Change(s):

  • Updated data connector

Version Updated:

  • yes

Testing Completed:

  • Need Help

Checked that the validations are passing and have addressed any issues that are present:

  • Need Help

@NCstevenB NCstevenB requested review from a team as code owners January 8, 2025 09:48
@NCstevenB
Copy link
Contributor Author

@NCstevenB please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement
@microsoft-github-policy-service agree [company="{NetClean Technologies AB}"]

@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Jan 8, 2025
@NCstevenB
Copy link
Contributor Author

NCstevenB commented Jan 9, 2025 via email

@NCstevenB
Copy link
Contributor Author

NCstevenB commented Jan 9, 2025 via email

@v-prasadboke
Copy link
Contributor

Hello @NCstevenB, Thanks for raising this PR. This PR will be investigated and we will provide you an update by 16 Jan, 2025

@v-prasadboke
Copy link
Contributor

Hello @NCstevenB, If this your forked repo please update it with azure repos master branch once.

@v-prasadboke
Copy link
Contributor

Looks good

@v-atulyadav v-atulyadav merged commit 3977aab into Azure:master Jan 30, 2025
34 checks passed
@NCstevenB NCstevenB deleted the NetCleanUpdates branch January 30, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants