Skip to content

Commit df68442

Browse files
committed
additional PR merger information
1 parent d257bfb commit df68442

File tree

4 files changed

+8
-0
lines changed

4 files changed

+8
-0
lines changed

docs/content/contributing/bicep/bicep-contribution-flow/_index.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -581,6 +581,8 @@ When publishing a new version of an existing module (i.e., anything that is not
581581

582582
{{% include file="/static/includes/PR-approval-guidance.md" %}}
583583

584+
In case of Bicep modules, if the PR includes any changes outside of the "modules/" folder, it first needs the module related code changes need to be reviewed and approved as per the above table, and only then does the PR need to be approved by a member of the core team. This way the core team's approval does not act as a bypass from the actual code review perspective.
585+
584586
<!--
585587
## Publishing to the Registry
586588

docs/content/contributing/terraform/terraform-contribution-flow/_index.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,3 +304,5 @@ When publishing a net new module for the first time ever, the PR **MUST** be rev
304304
When publishing a new version of an existing module (i.e., anything that is not being published for the first time ever), the PR approval logic is the following:
305305
306306
{{% include file="/static/includes/PR-approval-guidance.md" %}}
307+
308+
For more details, please refer to the [Owner Contribution flow]({{% siteparam base %}}/contributing/terraform/terraform-contribution-flow/owner-contribution-flow) section.

docs/content/help-support/issue-triage/brm-issue-triage.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,8 @@ The PR approval logic for existing modules is the following:
102102

103103
This behavior is assisted by bots, through automatic assignment of the expected reviewer(s) and supporting labels.
104104

105+
In case of Bicep modules, if the PR includes any changes outside of the "modules/" folder, it first needs the module related code changes need to be reviewed and approved as per the above table, and only then does the PR need to be approved by a member of the core team. This way the core team's approval does not act as a bypass from the actual code review perspective.
106+
105107
{{% /notice %}}
106108

107109
## General Question/Feedback and other standard issues

docs/content/specs-defs/module-lifecycle.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ The PR approval logic for existing modules is the following:
6767

6868
This behavior is assisted by bots, through automatic assignment of the expected reviewer(s) and supporting labels.
6969

70+
In case of Bicep modules, if the PR includes any changes outside of the "modules/" folder, it first needs the module related code changes need to be reviewed and approved as per the above table, and only then does the PR need to be approved by a member of the core team. This way the core team's approval does not act as a bypass from the actual code review perspective.
71+
7072
{{% /expand %}}
7173

7274
{{% /notice %}}

0 commit comments

Comments
 (0)