Skip to content

Commit 4d868a9

Browse files
Merge branch 'stable' of https://github.com/Azure/BatchLabs
2 parents 252219f + 83ddfe6 commit 4d868a9

File tree

5 files changed

+15
-6
lines changed

5 files changed

+15
-6
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# 0.10.2
2+
### Bug:
3+
4+
* VM Size selector broken [\#940](https://github.com/Azure/BatchLabs/issues/940)
5+
16
# 0.10.1
27
[All items](https://github.com/Azure/BatchLabs/milestone/13?closed=1)
38

app/components/pool/action/add/vm-size-picker.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<mat-tab-group class="form-tabs">
1+
<mat-tab-group class="form-tabs" [@.disabled]="true">
22
<mat-tab *ngFor="let category of categoryNames" [label]="categoryLabelName(category)">
33
<bl-focus-section>
44
<bl-table [activeItem]="pickedSize" (activeItemChange)="pickSize($event)">

app/services/monaco-loader.service.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Injectable } from "@angular/core";
2-
import { Constants } from "app/utils";
2+
import { Constants, OS } from "app/utils";
33
import { AutoscaleLanguage } from "app/utils/monaco-languages/autoscale.language";
44
import { JsonLanguage } from "app/utils/monaco-languages/json/json.language";
55

@@ -24,9 +24,12 @@ export class MonacoLoader {
2424

2525
public load(): Promise<any> {
2626
return new Promise((resolve) => {
27-
27+
let baseUrl = path.join(Constants.Client.root, "build/vendor/");
28+
if (!OS.isWindows()) {
29+
baseUrl = `file://${baseUrl}`;
30+
}
2831
const onGotAmdLoader = () => {
29-
anyWindow.amdRequire.config({ baseUrl: path.join(Constants.Client.root, "build/vendor/") });
32+
anyWindow.amdRequire.config({ baseUrl });
3033
// workaround monaco-css not understanding the environment
3134
(self as any).module = undefined;
3235
// workaround monaco-typescript not understanding the environment

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"name": "Microsoft Corporation",
1010
"email": "tiguerin@microsoft.com"
1111
},
12-
"version": "0.10.1",
12+
"version": "0.10.2",
1313
"main": "build/client/main.prod.js",
1414
"scripts": {
1515
"ts": "ts-node --project tsconfig.node.json",

test/app/components/pool/action/add/vm-size-picker.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { Component, DebugElement, NO_ERRORS_SCHEMA } from "@angular/core";
22
import { ComponentFixture, TestBed, fakeAsync, tick } from "@angular/core/testing";
33
import { FormsModule } from "@angular/forms";
44
import { By } from "@angular/platform-browser";
5+
import { NoopAnimationsModule } from "@angular/platform-browser/animations";
56
import { List } from "immutable";
67
import { Observable } from "rxjs";
78

@@ -60,7 +61,7 @@ describe("VmSizePickerComponent", () => {
6061
};
6162

6263
TestBed.configureTestingModule({
63-
imports: [FormsModule],
64+
imports: [FormsModule, NoopAnimationsModule],
6465
declarations: [VmSizePickerComponent, TestComponent],
6566
providers: [
6667
{ provide: VmSizeService, useValue: vmSizeServiceSpy },

0 commit comments

Comments
 (0)