Don't fail validation for a float when provided an int (#59)

* Extra conditional in validation

* Fix conditional. Add test

Author: trangevi

inference_schema/parameter_types/standard_py_parameter_type.py

@@ -57,7 +57,11 @@ def deserialize_input(self, input_data):
             input_data = parser.parse(input_data).timetz()
         elif self.sample_data_type is bytearray or (sys.version_info[0] == 3 and self.sample_data_type is bytes):
             input_data = base64.b64decode(input_data.encode('utf-8'))
-        if not isinstance(input_data, self.sample_data_type):
+
+        if self.sample_data_type is float and type(input_data) is int:
+            # Allow users to pass ints when expecting floats, for convenience
+            pass
+        elif not isinstance(input_data, self.sample_data_type):
             raise ValueError("Invalid input data type to parse. Expected: {0} but got {1}".format(
                 self.sample_data_type, type(input_data)))
 

tests/conftest.py

@@ -184,6 +184,15 @@ def standard_py_func(param):
     return standard_py_func
 
 
+@pytest.fixture(scope="session")
+def decorated_float_func():
+    @input_schema('param', StandardPythonParameterType(1.0))
+    def standard_float_func(param):
+        return param
+
+    return standard_float_func
+
+
 @pytest.fixture(scope="session")
 def decorated_nested_func(standard_sample_input, numpy_sample_input, pandas_sample_input, standard_sample_output,
                           numpy_sample_output, pandas_sample_output):

tests/test_standard_parameter_type.py

@@ -14,3 +14,12 @@ def test_standard_handling(self, decorated_standard_func):
         standard_input = {'param': {'name': ['Sarah'], 'state': ['WA']}}
         result = decorated_standard_func(**standard_input)
         assert state == result
+
+    def test_float_int_handling(self, decorated_float_func):
+        float_input = 1.0
+        result = decorated_float_func(float_input)
+        assert float_input == result
+
+        int_input = 1
+        result = decorated_float_func(int_input)
+        assert int_input == result