Skip to content

Commit 550ffbd

Browse files
preetriti1Priti Sambandam
andauthored
fix(mcp): Adding custom date time picker for generate keys and minor bug fixes (#8793)
* fix(mcp): Adding custom date time picker for generate keys and minor bug fixes * Added min date and time validation * Addressing PR comments --------- Co-authored-by: Priti Sambandam <psamband@microsoft.com>
1 parent 6412998 commit 550ffbd

File tree

10 files changed

+1645
-628
lines changed

10 files changed

+1645
-628
lines changed

Localize/lang/strings.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@
243243
"3Y9Ff3": "Use the following credentials to connect to your agent from external applications or custom integrations.",
244244
"3YFMW8": "Open Chat Client",
245245
"3a3eHg": "Select actions",
246+
"3c7eHH": "Please enter a valid time format (e.g., 2:30 PM).",
246247
"3cZFcy": "Error Panel",
247248
"3cZZKj": "Divider",
248249
"3eeli7": "Select a source schema",
@@ -454,6 +455,7 @@
454455
"8A0GFO": "Required. The XML-encoded name string to be decoded.",
455456
"8CWFEh": "Required. The value to return if the expression is 'true'.",
456457
"8DFwxH": "Returns a formatted number string",
458+
"8DgDf+": "Custom",
457459
"8FjOSh": "Required. The object to check if it is greater or equal to the comparing object.",
458460
"8G9bj4": "Add custom modules, uncover new scenarios, and find troubleshooting tips",
459461
"8Ifvot": "...and {count} more items. Type to search for specific items.",
@@ -498,6 +500,7 @@
498500
"92h1A6": "The server {serverName} has been created.",
499501
"95Psou": "Previous",
500502
"96JG8I": "{operationName} operation",
503+
"96v4Tz": "Select a time...",
501504
"99vsJy": "Connector",
502505
"9COFQr": "Collapse action",
503506
"9EmN2M": "Cancel",
@@ -1277,6 +1280,7 @@
12771280
"RxbkcI": "Unsupported token type: {controls}",
12781281
"S0N/tx": "Resubmit a workflow run from this action",
12791282
"S138/4": "Format text as bold. Shortcut: ⌘B",
1283+
"S2KtbJ": "Select date and time",
12801284
"S5kFNK": "Paste your sample data to test the mapping",
12811285
"SC5XB0": "Create Parameter",
12821286
"SCCE6s": "Password",
@@ -1890,6 +1894,7 @@
18901894
"_3Y9Ff3.comment": "Option 1 description in info dialog",
18911895
"_3YFMW8.comment": "Link text for chat client",
18921896
"_3a3eHg.comment": "Select Actions",
1897+
"_3c7eHH.comment": "Error message for invalid time format",
18931898
"_3cZFcy.comment": "Error Panel",
18941899
"_3cZZKj.comment": "Aria label for divider",
18951900
"_3eeli7.comment": "Source schema dropdown placeholder",
@@ -2101,6 +2106,7 @@
21012106
"_8A0GFO.comment": "Required parameter for name in decodeXmlName function",
21022107
"_8CWFEh.comment": "Required value parameter to return given if function is true",
21032108
"_8DFwxH.comment": "Label for description of custom formatNumber Function",
2109+
"_8DgDf+.comment": "Text for custom option",
21042110
"_8FjOSh.comment": "Required object parameter to check if greater than or equal to using greaterOrEqual function",
21052111
"_8G9bj4.comment": "This is a message give link to user to find out more about this action",
21062112
"_8Ifvot.comment": "Message indicating more items are available",
@@ -2145,6 +2151,7 @@
21452151
"_92h1A6.comment": "Content for the toaster after creating a server",
21462152
"_95Psou.comment": "Button text for moving to the previous tab in the create app panel",
21472153
"_96JG8I.comment": "Alt text on action/trigger card when there is an operation name but no connector name",
2154+
"_96v4Tz.comment": "Placeholder text for time picker",
21482155
"_99vsJy.comment": "Label For Connector Name in About Panel",
21492156
"_9COFQr.comment": "Text indicating a menu button to collapse an action in the designer",
21502157
"_9EmN2M.comment": "Button to cancel creating a connection",
@@ -2924,6 +2931,7 @@
29242931
"_RxbkcI.comment": "Exception for unsupported token types",
29252932
"_S0N/tx.comment": "accessibility text for the resubmit button",
29262933
"_S138/4.comment": "label to make bold text for Mac users",
2934+
"_S2KtbJ.comment": "Label for custom date time picker",
29272935
"_S5kFNK.comment": "Sample test data placeholder",
29282936
"_SC5XB0.comment": "label to add a parameter",
29292937
"_SCCE6s.comment": "Basic Password Label Display Name",
@@ -3575,6 +3583,7 @@
35753583
"_gkY5ya.comment": "Delete dynamic parameter corresponding to this row",
35763584
"_gkwo0O.comment": "Error message shown when required fields are not filled in new logic app details",
35773585
"_gl+tO3.comment": "Allowed values label",
3586+
"_gl0im8.comment": "Error message for selecting past time",
35783587
"_gnYVoF.comment": "Message displayed when there are no warnings",
35793588
"_gpUphl.comment": "Audience Placeholder Text",
35803589
"_gt3JdS.comment": "Body text for informing users this action is deleting selected workflows",
@@ -3617,6 +3626,7 @@
36173626
"_hZqQdt.comment": "Time zone value ",
36183627
"_haeWoU.comment": "Error message when splitOn cannot be evaluated",
36193628
"_hbOvB4.comment": "Dislike button text for suggested flow",
3629+
"_hbmiUp.comment": "Placeholder text for date picker",
36203630
"_hdN+aw.comment": "Description for host field",
36213631
"_hesDPs.comment": "Milliseconds",
36223632
"_hflWi6.comment": "Description for trimByteOrderMark function",
@@ -4747,6 +4757,7 @@
47474757
"gkY5ya": "Delete",
47484758
"gkwo0O": "Please fill all required fields and then continue.",
47494759
"gl+tO3": "Allowed values",
4760+
"gl0im8": "Please select a future time.",
47504761
"gnYVoF": "No warnings found in your map.",
47514762
"gpUphl": "Enter the audience.",
47524763
"gt3JdS": "Do you want to delete the workflow(s)? This will remove the workflow(s) from this template.",
@@ -4789,6 +4800,7 @@
47894800
"hZqQdt": "(UTC+02:00) Gaza, Hebron",
47904801
"haeWoU": "Failed to evaluate outputs because splitOn {splitOn} cannot be evaluated. As a result, this operation's outputs might not be correctly visible in subsequent actions",
47914802
"hbOvB4": "This isn't what I'm looking for",
4803+
"hbmiUp": "Select a date...",
47924804
"hdN+aw": "Specifies which Logic App sku the template supports (e.g., Standard, Consumption).",
47934805
"hesDPs": "{count} Milliseconds",
47944806
"hflWi6": "Removes Byte Order Mark (BOM) characters from the beginning of strings or binary content.",

apps/Standalone/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
"@fluentui/foundation-legacy": "8.2.15",
88
"@fluentui/react": "8.110.2",
99
"@fluentui/react-components": "9.70.0",
10+
"@fluentui/react-datepicker-compat": "0.6.22",
11+
"@fluentui/react-timepicker-compat": "0.4.28",
1012
"@fluentui/react-focus": "8.8.19",
1113
"@fluentui/react-hooks": "8.6.20",
1214
"@fluentui/react-icons": "2.0.224",

libs/designer/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
"@fluentui/azure-themes": "8.5.70",
66
"@fluentui/react": "8.110.2",
77
"@fluentui/react-components": "9.70.0",
8+
"@fluentui/react-datepicker-compat": "0.6.22",
9+
"@fluentui/react-timepicker-compat": "0.4.28",
810
"@fluentui/react-hooks": "8.6.20",
911
"@fluentui/react-icons": "2.0.224",
1012
"@fluentui/utilities": "8.15.0",

libs/designer/src/lib/ui/mcp/panel/server/__test__/create.spec.tsx

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,7 @@ describe('CreateServer', () => {
197197
const mockServer: Partial<McpServer> = {
198198
name: 'TestServer',
199199
description: 'Test Description',
200-
tools: {
201-
workflow1: { name: 'Workflow1' },
202-
},
200+
tools: [{ name: 'Workflow1' }],
203201
};
204202

205203
renderWithProviders({ server: mockServer as McpServer, onUpdate: mockOnUpdate, onClose: mockOnClose });
@@ -358,10 +356,7 @@ describe('CreateServer', () => {
358356
const mockServer: Partial<McpServer> = {
359357
name: 'Existing Server',
360358
description: 'Existing Description',
361-
tools: {
362-
workflow1: { name: 'Workflow1' },
363-
workflow2: { name: 'Workflow2' },
364-
},
359+
tools: [{ name: 'Workflow1' }, { name: 'Workflow2' }],
365360
};
366361

367362
renderWithProviders({ server: mockServer as McpServer, onUpdate: mockOnUpdate, onClose: mockOnClose });
@@ -462,7 +457,7 @@ describe('CreateServer', () => {
462457
expect(mockOnUpdate).toHaveBeenCalledWith({
463458
name: 'TestServer',
464459
description: 'Test Description',
465-
tools: [{ name: 'workflow1' }],
460+
tools: [{ name: 'Workflow1' }],
466461
});
467462
});
468463
});

0 commit comments

Comments
 (0)