Skip to content

Comments

fix(vscode): Updated bundle feed to use index.json instead of index-v2.json#8807

Merged
lambrianmsft merged 3 commits intoAzure:mainfrom
lambrianmsft:lambrian/bundleFeed_update
Feb 19, 2026
Merged

fix(vscode): Updated bundle feed to use index.json instead of index-v2.json#8807
lambrianmsft merged 3 commits intoAzure:mainfrom
lambrianmsft:lambrian/bundleFeed_update

Conversation

@lambrianmsft
Copy link
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Our current use of bundle feed is using index-v2.json which has not been updated in a while. Updating to use and pull the latest version from index.json

Impact of Change

  • Users:
  • None.
  • Developers:
  • None.
  • System:
  • Slightly better system performance as we are reducing an api call for getting the default version range.

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

Screenshots/Videos

Copilot AI review requested due to automatic review settings February 11, 2026 00:29
@github-actions
Copy link

github-actions bot commented Feb 11, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Updated bundle feed to use index.json instead of index-v2.json
  • Issue: None. The title is clear, follows conventional commits scope/type, and describes the change.
  • Recommendation: (Optional) No change needed.

Commit Type

  • Properly selected (fix).
  • Only one box selected, which is correct.

⚠️ Risk Level

  • PR body selected: Low.
  • Assessment: The repository labels do NOT include a risk label (e.g., risk:low, risk:medium, risk:high). Please add a corresponding risk label to the PR. Additionally, the code diff changes exported function signatures (for example, getLatestVersionRange becomes synchronous and addDefaultBundle no longer accepts a context param). Those changes can be breaking for callers and therefore justify a higher risk than 'Low'.
  • Recommendation: Add a label risk:medium to the PR and update the Risk Level section in the body to match that label.

What & Why

  • Current: "Our current use of bundle feed is using index-v2.json which has not been updated in a while. Updating to use and pull the latest version from index.json"
  • Issue: The description is concise and correct for the primary behavioral change, but it omits that exported function signatures were changed (API surface changes) and the rationale for returning defaultVersionRange directly.
  • Recommendation: Expand to mention the signature/API changes and rationale. Example: "Switch the extension bundle feed URL from index-v2.json to index.json and update utilities to read the feed format. As part of this, getLatestVersionRange was simplified to return the default constant (removing async network fetch), and addDefaultBundle was converted to a synchronous helper. These changes reduce runtime network calls and simplify the code, but do change function signatures used by other modules."

⚠️ Impact of Change

  • Issue: The PR body currently lists no developer impact, but the code modifies exported function signatures and return types (getLatestVersionRange now synchronous; addDefaultBundle no longer takes context and is synchronous; getWorkflowBundleFeed now returns string[]). That can break callers across the repo.
  • Recommendation:
    • Users: None user-facing for runtime of production customers, but tooling/extension behavior should be validated.
    • Developers: Update callers for changed signatures and add migration notes. Example: "Callers of getLatestVersionRange must no longer pass an IActionContext and should expect a synchronous string return. addDefaultBundle no longer accepts a context and should be invoked synchronously. getWorkflowBundleFeed now returns string[] of versions instead of the prior IBundleFeed structure."
    • System: Slightly improved behavior (reduces a network round trip in some cases), but run full builds and extension integration tests to ensure nothing breaks.

Test Plan

  • Unit tests added/updated: ✅ The diff includes new and updated unit tests (bundleFeed.test.ts) that exercise the new functions and code paths.
  • E2E tests: none added — acceptable if there are valid reasons. Consider adding an integration test or running the extension end-to-end in CI to validate runtime behavior.
  • Manual testing: none listed — consider adding notes if manual verification was performed (e.g., launched the extension and validated bundle download behavior).

⚠️ Contributors

  • Assessment: Empty section in the PR body. It's optional, but please remember to credit PMs, Designers, reviewers, or others who contributed ideas or reviews.
  • Recommendation: Add contributor mentions (optional but helpful).

Screenshots/Videos

  • Assessment: Not applicable for a non-UI change.

Summary Table

Section Status Recommendation
Title None needed
Commit Type None needed
Risk Level ⚠️ Add a risk:medium label and update the body to match; explain why risk is medium (API/signature changes).
What & Why Expand to mention signature/API changes and rationale.
Impact of Change ⚠️ Update Impact section to call out developer impact and migration steps.
Test Plan Unit tests present. Consider E2E / integration validation as follow-up.
Contributors ⚠️ Optional: add contributors if applicable.
Screenshots/Videos Not applicable

Summary / Action Items

  • Advised risk level: medium (higher than the PR's selected Low). Please update the PR label to risk:medium and change the Risk Level selection in the body to match.
  • Update the What & Why and Impact sections to explicitly mention the exported function signature changes (getLatestVersionRange, addDefaultBundle, getWorkflowBundleFeed) and call out that callers must be updated. Include a short migration note explaining the replacements.
  • Ensure all callers across the repo are updated for the new synchronous signatures, run a full build, run extension integration tests (or E2E if available), and include in the Test Plan a note that these checks passed.
  • Add a short note in Contributors if others reviewed or contributed.

Please update the PR description and add the risk:medium label to match the actual code changes and then re-submit. Thank you for the thorough unit tests and clear title — the main remaining items are labeling and explicitly documenting the API/signature changes and their impact.


Last updated: Thu, 19 Feb 2026 18:32:08 GMT

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the VS Code designer’s extension-bundle feed usage to rely on index.json (instead of index-v2.json) and avoids fetching the default bundle version range from the feed by using the in-repo constant.

Changes:

  • Switch workflow bundle feed URL to .../index.json and update the “latest bundle version” selection logic accordingly.
  • Remove the network-based “latest version range” lookup; getLatestVersionRange() and addDefaultBundle() now use defaultVersionRange.
  • Add unit tests covering the new getLatestVersionRange() and addDefaultBundle() behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
apps/vs-code-designer/src/app/utils/bundleFeed.ts Switches to index.json, removes index-v2.json feed usage for default version range, and adjusts version selection from feed results.
apps/vs-code-designer/src/app/utils/test/bundleFeed.test.ts Adds tests for getLatestVersionRange() and addDefaultBundle().

@lambrianmsft lambrianmsft merged commit 7a0b25b into Azure:main Feb 19, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants