Merge pull request #698 from Azure/revert-691-feature-attach-detach-2

Revert "[Compute] az vm disk attach-detach-data-disk: Add new attach-detach data disk command"

Author: necusjz

Commands/tree.json

@@ -232854,33 +232854,26 @@
           },
           "disk": {
             "commands": {
-              "attach-detach": {
+              "attach-detach-data-disk": {
                 "help": {
                   "short": "Attach and detach data disks to/from the virtual machine."
                 },
                 "names": [
                   "vm",
                   "disk",
-                  "attach-detach"
+                  "attach-detach-data-disk"
                 ],
                 "versions": [
                   {
-                    "examples": [
-                      {
-                        "commands": [
-                          "vm disk attach-detach --resource-group {resourceGroup} --vm-name {vmName} --data-disks-to-attach \"[{lun:1,disk-id:'/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/disks/{disk1Name}',disk-encryption-set:{id:'/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/diskEncryptionSets/{existing-diskEncryptionSet-name}'},caching:ReadOnly,delete-option:Delete,write-accelerator-enabled:True},{lun:2,disk-id:'/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/disks/{disk2Name}',disk-encryption-set:{id:'/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/diskEncryptionSets/{existing-diskEncryptionSet-name}'},caching:ReadWrite,delete-option:Detach,write-accelerator-enabled:False}]\" --data-disks-to-detach \"[{disk-id:'/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/disks/{disk3Name}',detach-option:ForceDetach},{disk-id:'/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/disks/{disk4Name}',detach-option:ForceDetach}]\""
-                        ],
-                        "name": "Virtual Machine attach detach multiple data disks"
-                      }
-                    ],
                     "name": "2024-03-01",
                     "resources": [
                       {
                         "id": "/subscriptions/{}/resourcegroups/{}/providers/microsoft.compute/virtualmachines/{}/attachdetachdatadisks",
                         "plane": "mgmt-plane",
                         "version": "2024-03-01"
                       }
-                    ]
+                    ],
+                    "stage": "Preview"
                   }
                 ]
               }

Commands/vm/disk/_attach-detach-data-disk.md

@@ -0,0 +1,9 @@
+# [Command] _vm disk attach-detach-data-disk_
+
+Attach and detach data disks to/from the virtual machine.
+
+## Versions
+
+### [2024-03-01](/Resources/mgmt-plane/L3N1YnNjcmlwdGlvbnMve30vcmVzb3VyY2Vncm91cHMve30vcHJvdmlkZXJzL21pY3Jvc29mdC5jb21wdXRlL3ZpcnR1YWxtYWNoaW5lcy97fS9hdHRhY2hkZXRhY2hkYXRhZGlza3M=/2024-03-01.xml) **Preview**
+
+<!-- mgmt-plane /subscriptions/{}/resourcegroups/{}/providers/microsoft.compute/virtualmachines/{}/attachdetachdatadisks 2024-03-01 -->

Commands/vm/disk/_attach-detach.md

@@ -19,5 +19,5 @@ Azure Virtual Machines use disks as a place to store an operating system, applic
 
 ## Commands
 
-- [attach-detach](/Commands/vm/disk/_attach-detach.md)
+- [attach-detach-data-disk](/Commands/vm/disk/_attach-detach-data-disk.md)
 : Attach and detach data disks to/from the virtual machine.

Commands/vm/disk/readme.md

@@ -2,7 +2,7 @@
 <CodeGen plane="mgmt-plane">
   <resource id="/subscriptions/{}/resourcegroups/{}/providers/microsoft.compute/virtualmachines/{}/attachdetachdatadisks" version="2024-03-01" swagger="mgmt-plane/compute/ResourceProviders/Microsoft.Compute/Paths/L3N1YnNjcmlwdGlvbnMve3N1YnNjcmlwdGlvbklkfS9yZXNvdXJjZUdyb3Vwcy97cmVzb3VyY2VHcm91cE5hbWV9L3Byb3ZpZGVycy9NaWNyb3NvZnQuQ29tcHV0ZS92aXJ0dWFsTWFjaGluZXMve3ZtTmFtZX0vYXR0YWNoRGV0YWNoRGF0YURpc2tz/V/MjAyNC0wMy0wMQ=="/>
   <commandGroup name="vm disk">
-    <command name="attach-detach" version="2024-03-01" confirmation="">
+    <command name="attach-detach-data-disk" version="2024-03-01" confirmation="">
       <resource id="/subscriptions/{}/resourcegroups/{}/providers/microsoft.compute/virtualmachines/{}/attachdetachdatadisks" version="2024-03-01" swagger="mgmt-plane/compute/ResourceProviders/Microsoft.Compute/Paths/L3N1YnNjcmlwdGlvbnMve3N1YnNjcmlwdGlvbklkfS9yZXNvdXJjZUdyb3Vwcy97cmVzb3VyY2VHcm91cE5hbWV9L3Byb3ZpZGVycy9NaWNyb3NvZnQuQ29tcHV0ZS92aXJ0dWFsTWFjaGluZXMve3ZtTmFtZX0vYXR0YWNoRGV0YWNoRGF0YURpc2tz/V/MjAyNC0wMy0wMQ=="/>
       <argGroup name="">
         <arg type="ResourceGroupName" var="$Path.resourceGroupName" options="resource-group g" required="True" idPart="resource_group"/>
@@ -14,7 +14,6 @@
       <argGroup name="Parameters">
         <arg type="array<object>" var="$parameters.dataDisksToAttach" options="data-disks-to-attach" group="Parameters">
           <help short="The list of managed data disks to be attached."/>
-          <format minLength="1"/>
           <item type="object">
             <arg type="string" var="$parameters.dataDisksToAttach[].caching" options="caching" group="">
               <help short="Specify the caching requirements. Possible values are: **None,** **ReadOnly,** **ReadWrite.** The defaulting behavior is: **None for Standard storage. ReadOnly for Premium storage.**"/>
@@ -50,7 +49,6 @@
         </arg>
         <arg type="array<object>" var="$parameters.dataDisksToDetach" options="data-disks-to-detach" group="Parameters">
           <help short="The list of managed data disks to be detached."/>
-          <format minLength="1"/>
           <item type="object">
             <arg type="string" var="$parameters.dataDisksToDetach[].detachOption" options="detach-option">
               <help short="Supported options available for Detach of a disk from a VM. Refer to DetachOption object reference for more details."/>
@@ -82,7 +80,6 @@
               <json>
                 <schema type="object" name="parameters" required="True" clientFlatten="True">
                   <prop type="array<object>" name="dataDisksToAttach" arg="$parameters.dataDisksToAttach" identifiers="diskId">
-                    <format minLength="1"/>
                     <item type="object">
                       <prop type="string" name="caching" arg="$parameters.dataDisksToAttach[].caching">
                         <enum>
@@ -106,7 +103,6 @@
                     </item>
                   </prop>
                   <prop type="array<object>" name="dataDisksToDetach" arg="$parameters.dataDisksToDetach" identifiers="diskId">
-                    <format minLength="1"/>
                     <item type="object">
                       <prop type="string" name="detachOption" arg="$parameters.dataDisksToDetach[].detachOption">
                         <enum>