-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Labels
Description
The ScalingCard component displays a chart with historical scaling metrics (replicas and CPU over time), but the data is entirely simulated using Math.random(). Meanwhile, the ScalingTab component fetches real data from Prometheus using queryPrometheus and getPrometheusEndpoint.
Options
1. Remove the chart from ScalingCard
Pros
- No misleading fake data
- Simpler code, less maintenance burden
- The
ScalingMetricscomponent already shows current replicas, CPU, HPA, etc. - Users who need historical data can just use the ScalingTab
Cons
- Card might look sparse/incomplete visually
- Users must navigate to a different tab for this data
2. Integrate real Prometheus data into ScalingCard
Pros
- Chart shows actual historical data
- Consistent UX between card and tab
Cons
- Requires additional dependencies
- Need to fetch namespace instance and extract labels, more complex code
- ScalingCard is meant to be a summary view (this might be overkill)
3. Show a place holder instead of a fake chart
Pros
- No misleading data
- Keeps the card simple
Cons
- Takes up space without providing much value
- May look unfinished
Reactions are currently unavailable