cp: logging and build pipeline change (#1630)

* fix: adjust logging verbosity and event logs (#1629)

* 5 -> 3

* add processing log for event

* fix test

* fix worker

* gh pipeline (#1625)

* Update merge-build.yml (#1626)

* Remove azdevops yamls (#1627)

* remove the azdevops yamls

* add release to trigger

---------

Co-authored-by: malpaniHMC <[email protected]>

Author: akshaysngupta

.github/workflows/merge-build.yml

@@ -0,0 +1,56 @@
+name: "Merge Build"
+
+on:
+  push:
+    branches:
+    - master
+    - release/*
+  pull_request:
+    branches:
+    - master
+    - release/*
+permissions:
+  actions: read
+  contents: read
+  deployments: read
+
+jobs:
+  build_and_test:
+    runs-on: ubuntu-latest
+    timeout-minutes: 30
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+    - name: Set up Go workspace
+      run: |
+        shopt -s extglob
+        shopt -s dotglob
+      shell: bash
+    - name: Install Helm
+      uses: azure/[email protected]
+      with:
+        version: v3.11.0
+    - name: Set up Go
+      uses: actions/[email protected]
+      with:
+        go-version: '1.19.2'
+    - name: Go and Helm lint check
+      run: make lint-all
+    - name: Go vet
+      run: make vet-all
+    - name: Get dependencies and build
+      run: make build
+    - name: Run unit tests with code coverage
+      run: make unittest
+    - name: Publish test results
+      if: always()
+      uses: actions/[email protected]
+      with:
+        name: test-results
+        path: ${{ github.workspace }}/**/report.xml
+    - name: Publish code coverage results
+      if: always()
+      uses: actions/[email protected]
+      with:
+        name: code-coverage
+        path: coverage.xml

.pipelines/build.yml

@@ -206,7 +206,7 @@ func main() {
 
 		err = azClient.ApplyRouteTable(subnetID, routeTableID)
 		if err != nil {
-			klog.V(5).Infof("Unable to associate Application Gateway subnet '%s' with route table '%s' due to error (this is relevant for AKS clusters using 'Kubenet' network plugin): [%+v]",
+			klog.V(3).Infof("Unable to associate Application Gateway subnet '%s' with route table '%s' due to error (this is relevant for AKS clusters using 'Kubenet' network plugin): [%+v]",
 				subnetID,
 				routeTableID,
 				err)

.pipelines/merge-build.yml

@@ -87,7 +87,6 @@ func getKubeClientConfig() *rest.Config {
 
 func getEventRecorder(kubeClient kubernetes.Interface, ingressClassControllerName string) record.EventRecorder {
 	eventBroadcaster := record.NewBroadcaster()
-	eventBroadcaster.StartLogging(klog.V(5).Infof)
 	sink := &typedcorev1.EventSinkImpl{Interface: kubeClient.CoreV1().Events("")}
 	eventBroadcaster.StartRecordingToSink(sink)
 	hostname, err := os.Hostname()

.pipelines/nightly-build.yml

@@ -33,7 +33,7 @@ func (c appGwConfigBuilder) getPools(cbCtx *ConfigBuilderContext) []n.Applicatio
 	}
 
 	defaultPool := defaultBackendAddressPool(c.appGwIdentifier)
-	klog.V(5).Infof("Created default backend pool %s", *defaultPool.Name)
+	klog.V(3).Infof("Created default backend pool %s", *defaultPool.Name)
 	managedPoolsByName := map[string]*n.ApplicationGatewayBackendAddressPool{
 		*defaultPool.Name: &defaultPool,
 	}
@@ -44,7 +44,7 @@ func (c appGwConfigBuilder) getPools(cbCtx *ConfigBuilderContext) []n.Applicatio
 	for backendID, serviceBackendPair := range serviceBackendPairMap {
 		if pool := c.getBackendAddressPool(backendID, serviceBackendPair, managedPoolsByName); pool != nil {
 			managedPoolsByName[*pool.Name] = pool
-			klog.V(5).Infof("Created backend pool %s for service %s", *pool.Name, backendID.serviceKey())
+			klog.V(3).Infof("Created backend pool %s for service %s", *pool.Name, backendID.serviceKey())
 		}
 	}
 
@@ -53,7 +53,7 @@ func (c appGwConfigBuilder) getPools(cbCtx *ConfigBuilderContext) []n.Applicatio
 		for destinationID, serviceBackendPair := range istioServiceBackendPairMap {
 			if pool := c.getIstioBackendAddressPool(destinationID, serviceBackendPair, managedPoolsByName); pool != nil {
 				managedPoolsByName[*pool.Name] = pool
-				klog.V(5).Infof("Created backend pool %s for service %s", *pool.Name, destinationID.serviceKey())
+				klog.V(3).Infof("Created backend pool %s for service %s", *pool.Name, destinationID.serviceKey())
 			}
 		}
 	}

.pipelines/release-build.yml

@@ -171,7 +171,7 @@ func (c *appGwConfigBuilder) resolveBackendPort(backendID backendIdentifier) (Po
 
 		// if target port is port name, then resolve the port number for the port name
 		// k8s matches service port name against endpoints port name retrieved by passing backendID service key to endpoint api.
-		klog.V(5).Infof("resolving port name '%s' for service '%s' and service port '%s' for Ingress '%s'", servicePort.Name, backendID.serviceKey(), serviceBackendPortToStr(backendID.Backend.Service.Port), backendID.Ingress.Name)
+		klog.V(3).Infof("resolving port name '%s' for service '%s' and service port '%s' for Ingress '%s'", servicePort.Name, backendID.serviceKey(), serviceBackendPortToStr(backendID.Backend.Service.Port), backendID.Ingress.Name)
 		targetPortsResolved := c.resolvePortName(servicePort.Name, &backendID)
 		for targetPort := range targetPortsResolved {
 			pair := serviceBackendPortPair{
@@ -315,7 +315,7 @@ func (c *appGwConfigBuilder) generateHTTPSettings(backendID backendIdentifier, p
 			certs = append(certs, *resourceRef(trustCertID))
 		}
 		httpSettings.TrustedRootCertificates = &certs
-		klog.V(5).Infof("Found trusted root certificate(s): %s from ingress: %s/%s", certificateNames, backendID.Ingress.Namespace, backendID.Ingress.Name)
+		klog.V(3).Infof("Found trusted root certificate(s): %s from ingress: %s/%s", certificateNames, backendID.Ingress.Namespace, backendID.Ingress.Name)
 
 	} else if err != nil && !controllererrors.IsErrorCode(err, controllererrors.ErrorMissingAnnotation) {
 		c.recorder.Event(backendID.Ingress, v1.EventTypeWarning, events.ReasonInvalidAnnotation, err.Error())

cmd/appgw-ingress/main.go

@@ -233,9 +233,9 @@ func generateListenerID(ingress *networking.Ingress, rule *networking.IngressRul
 	if overridePort != nil {
 		if *overridePort > 0 && *overridePort < 65000 {
 			frontendPort = *overridePort
-			klog.V(5).Infof("Using custom port specified in the override annotation: %d", *overridePort)
+			klog.V(3).Infof("Using custom port specified in the override annotation: %d", *overridePort)
 		} else {
-			klog.V(5).Infof("Derived listener port from ingress: %d", frontendPort)
+			klog.V(3).Infof("Derived listener port from ingress: %d", frontendPort)
 		}
 
 	}
@@ -257,7 +257,7 @@ func generateListenerID(ingress *networking.Ingress, rule *networking.IngressRul
 
 	extendedHostNames, err := annotations.GetHostNameExtensions(ingress)
 	if err != nil && !controllererrors.IsErrorCode(err, controllererrors.ErrorMissingAnnotation) {
-		klog.V(5).Infof("Error while parsing host name extensions: %s", err)
+		klog.V(3).Infof("Error while parsing host name extensions: %s", err)
 	} else {
 		if extendedHostNames != nil {
 			hostNames = append(hostNames, extendedHostNames...)
@@ -279,7 +279,7 @@ func (c *appGwConfigBuilder) addTags() {
 	if aksResourceID, err := azure.ConvertToClusterResourceGroup(c.k8sContext.GetInfrastructureResourceGroupID()); err == nil {
 		c.appGw.Tags[tags.IngressForAKSClusterID] = to.StringPtr(aksResourceID)
 	} else {
-		klog.V(5).Infof("Error while parsing cluster resource ID for tagging: %s", err)
+		klog.V(3).Infof("Error while parsing cluster resource ID for tagging: %s", err)
 	}
 }