fix 509 and 528 (#538)

Author: bmoore-msft

arm-ttk/testcases/deploymentTemplate/CommandToExecute-Must-Use-ProtectedSettings-For-Secrets.test.ps1

@@ -14,7 +14,7 @@ $TemplateObject
 # Find all references to an commandToExecute.
 $commandsToExecute = $TemplateObject | 
     Find-JsonContent -Key commandToExecute  -Value * -Like |
-    Where-Object { $_.ParentObject[0].type -imatch 'CustomScript$' } # on a customScript resource.
+    Where-Object { $_.ParentObject[0].type -imatch 'CustomScript|CustomScriptExtension|CustomScriptForLinux' } # on a customScript resource.
 
 
 foreach ($command in $commandsToExecute) {

arm-ttk/testcases/deploymentTemplate/Template-Should-Not-Contain-Blanks.test.ps1

@@ -46,7 +46,8 @@ $PropertiesThatCanBeEmpty = 'resources',
                             'notEquals', # Microsoft.Authorization/policyDefinitions policyRule'
                             'clientId', # Microsoft.ContainerService/managedClusters.properties.servicePrincipalProfile
                             'allowedCallerIpAddresses', # Microsoft.Logic/workflows Access Control
-                            'workerPools' # Microsoft.Web/hostingEnvironments
+                            'workerPools', # Microsoft.Web/hostingEnvironments
+                            'AzureMonitor' # Microsoft.Insights/VMDiagnosticsSettings
 
 if ($emptyItems) {
     foreach ($emptyItem in $emptyItems) {

unit-tests/CommandToExecute-Must-Use-ProtectedSettings-For-Secrets/Fail/customscriptextension.json

@@ -0,0 +1,25 @@
+{
+    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
+    "contentVersion": "1.0.0.0",
+    "parameters": {
+        "secure": {
+            "type": "secureObject"
+        }
+    },
+    "resources": [
+        {
+            "name": "vm/CustomScriptExtension",
+            "type": "Microsoft.HybridCompute/machines/extensions",
+            "apiVersion": "2019-08-02-preview",
+            "properties": {
+                "publisher": "Microsoft.Compute",
+                "type": "CustomScriptExtension",
+                "autoUpgradeMinorVersion": true,
+                "settings": {
+                    "fileUris": "https://foo.bar/script.ps1",
+                    "commandToExecute": "[concat('powershell -Arguments ', parameters('secure'))]"
+                }
+            }
+        }
+    ]
+}