eng, add openai-typespec lib #3268
Open
+44
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typespec-extension/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@autorest/codemodel": "~4.20.1", | ||
| "@azure-tools/openai-typespec": "^1.6.1", |
Member
Author
There was a problem hiding this comment.
In short-term, we still add it to emitter dependencies, to be synced to SDK repo.
Comment on lines
-23
to
-24
| "azure-ai-projects", # wait for service dev update tsp-location.yaml | ||
| "azure-ai-agents-persistent", # tspconfig does not have java |
Member
Author
There was a problem hiding this comment.
They likely would still fail, if run.
But in SDK repo they renamed tsp-location.yaml to _tsp-location.yaml, so it won't run.
weidongxu-microsoft
requested review from
XiaofeiCao,
haolingdong-msft and
srnagar
as code owners
| - job: Generate_SDK | ||
|
|
||
| timeoutInMinutes: 60 | ||
| timeoutInMinutes: 120 |
Member
Author
There was a problem hiding this comment.
The running time seems not very stable. I see range from 40min to more than 1hour (where the job times out).
Let's see if increase here would work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foundry is using this lib for API/models from native openai https://github.com/Azure/azure-rest-api-specs/blob/feature/foundry/package.json#L4