Extractor features (#101)

* add schemas to readme

* cleanup readme, include space for extractor

* fix table of contents routing

* extract diagnostic resource and add to template

* update to version 2018-06-01-preview, update creator config values

* remove name property from creator diagnostic

* extract loggers, enable logger and diagnostic iterative deployment

* update creator readme

* pull named values and substitute them for previously hidden credentials

* add validation on additional creator config properties, write tests

* refactor - update file structure, namespaces, remove dup classes,

* comment out representations on req/res operation schema until schema templates are extracted

* Odaibert/operations policies and products (#100)

* Added Products extractor to [APIM-NAME]-products.json file

* Finished:
- [Extractor] Relationship/Association between APIs and products are not extracted #85
- [Extractor] Allow users to specify if they want to extract all APIs or a single API (using apiId) #78
- [Extractor] Extract policies at the operation level #80
- [Extractor] Split APIs into multiple API templates #77

Author: odaibert

src/APIM_ARMTemplate/.gitignore

@@ -37,3 +37,6 @@ msbuild.wrn
 
 # Visual Studio 2015
 .vs/
+
+# Local Testing
+*validTesting.yml

src/APIM_ARMTemplate/README.md

@@ -2,8 +2,9 @@
 using Xunit;
 using McMaster.Extensions.CommandLineUtils;
 using System.IO;
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create;
 
-namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates
+namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Test
 {
     public class CreateTests
     {
@@ -110,5 +111,41 @@ public void ShouldFailWithInvalidLinking()
             var ex = Assert.ThrowsAny<CommandParsingException>(() => createCommand.Execute(args));
             Assert.Contains("LinkTemplatesBaseUrl is required for linked templates", ex.Message);
         }
+
+        [Fact]
+        public void ShouldFailWithInvalidVersionSetDisplayName()
+        {
+            var createCommand = new CreateCommand();
+            string[] args = new string[] { "--configFile", String.Concat(this.configExamplesFolder, "invalidVersionSetDisplayName.yml") };
+            var ex = Assert.ThrowsAny<CommandParsingException>(() => createCommand.Execute(args));
+            Assert.Contains("Display name is required if an API Version Set is provided", ex.Message);
+        }
+
+        [Fact]
+        public void ShouldFailWithInvalidVersionSetVersioningScheme()
+        {
+            var createCommand = new CreateCommand();
+            string[] args = new string[] { "--configFile", String.Concat(this.configExamplesFolder, "invalidVersionSetVersioningScheme.yml") };
+            var ex = Assert.ThrowsAny<CommandParsingException>(() => createCommand.Execute(args));
+            Assert.Contains("Versioning scheme is required if an API Version Set is provided", ex.Message);
+        }
+
+        [Fact]
+        public void ShouldFailWithInvalidOperationPolicy()
+        {
+            var createCommand = new CreateCommand();
+            string[] args = new string[] { "--configFile", String.Concat(this.configExamplesFolder, "invalidOperationPolicy.yml") };
+            var ex = Assert.ThrowsAny<CommandParsingException>(() => createCommand.Execute(args));
+            Assert.Contains("Policy XML is required if an API operation is provided", ex.Message);
+        }
+
+        [Fact]
+        public void ShouldFailWithInvalidDiagnosticLoggerId()
+        {
+            var createCommand = new CreateCommand();
+            string[] args = new string[] { "--configFile", String.Concat(this.configExamplesFolder, "invalidDiagnosticLoggerId.yml") };
+            var ex = Assert.ThrowsAny<CommandParsingException>(() => createCommand.Execute(args));
+            Assert.Contains("LoggerId is required if an API diagnostic is provided", ex.Message);
+        }
     }
 }

src/APIM_ARMTemplate/apimtemplate.test/CmdLine/CreateTests.cs

@@ -3,7 +3,7 @@
 using McMaster.Extensions.CommandLineUtils;
 
 
-namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates
+namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Test
 {
     public class ExtractTests
     {

src/APIM_ARMTemplate/apimtemplate.test/CmdLine/ExtractTests.cs

@@ -2,9 +2,9 @@
 using Xunit;
 using Newtonsoft.Json.Linq;
 using System;
-using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create;
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common;
 
-namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates
+namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Test
 {
     public class FileWriterTests
     {

src/APIM_ARMTemplate/apimtemplate.test/Creator/FileHandlerTests/FileWriterTests.cs

@@ -1,8 +1,8 @@
 using Xunit;
-using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create;
 using Microsoft.OpenApi.Models;
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common;
 
-namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates
+namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Test
 {
     public class OpenAPISpecReaderTests
     {

src/APIM_ARMTemplate/apimtemplate.test/Creator/FileHandlerTests/OpenAPISpecReaderTests.cs

@@ -1,5 +1,7 @@
-
-namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common;
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create;
+
+namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Test
 {
     public class APITemplateCreatorFactory
     {

src/APIM_ARMTemplate/apimtemplate.test/Creator/TemplateCreatorFactories/APITemplateCreatorFactory.cs

@@ -1,5 +1,6 @@
-
-namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create;
+
+namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Test
 {
     public class APIVersionSetTemplateCreatorFactory
     {

src/APIM_ARMTemplate/apimtemplate.test/Creator/TemplateCreatorFactories/APIVersionSetTemplateCreatorFactory.cs

@@ -1,5 +1,6 @@
-
-namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create;
+
+namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Test
 {
     public class MasterTemplateCreatorFactory
     {

src/APIM_ARMTemplate/apimtemplate.test/Creator/TemplateCreatorFactories/MasterTemplateCreatorFactory.cs

@@ -1,5 +1,7 @@
-
-namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common;
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create;
+
+namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Test
 {
     public class PolicyTemplateCreatorFactory
     {