Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Commit 8dc3519

Browse files
committed
refactor api extractor class, move all logic into subclasses from extract command
1 parent 1454e02 commit 8dc3519

File tree

7 files changed

+327
-351
lines changed

7 files changed

+327
-351
lines changed

src/APIM_ARMTemplate/apimtemplate/Commands/Extract.cs

Lines changed: 25 additions & 322 deletions
Large diffs are not rendered by default.

src/APIM_ARMTemplate/apimtemplate/Extractor/EntityExtractors/APIExtractor.cs

Lines changed: 292 additions & 19 deletions
Large diffs are not rendered by default.

src/APIM_ARMTemplate/apimtemplate/Extractor/EntityExtractors/AuthorizationServerExtractor.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public async Task<string> GetAuthorizationServer(string ApiManagementName, strin
3030
return await CallApiManagement(azToken, requestUrl);
3131
}
3232

33-
public async Task<Template> GenerateAuthorizationServersARMTemplate(string apimname, string resourceGroup, string singleApiName, List<TemplateResource> armTemplateResources)
33+
public async Task<Template> GenerateAuthorizationServersARMTemplate(string apimname, string resourceGroup, string singleApiName, List<TemplateResource> apiTemplateResources)
3434
{
3535
Console.WriteLine("------------------------------------------");
3636
Console.WriteLine("Getting authorization servers from service");
@@ -39,7 +39,7 @@ public async Task<Template> GenerateAuthorizationServersARMTemplate(string apimn
3939
List<TemplateResource> templateResources = new List<TemplateResource>();
4040

4141
// isolate api resources in the case of a single api extraction, as they may reference authorization servers
42-
var apiResources = armTemplateResources.Where(resource => resource.type == ResourceTypeConstants.API);
42+
var apiResources = apiTemplateResources.Where(resource => resource.type == ResourceTypeConstants.API);
4343

4444
string authorizationServers = await GetAuthorizationServers(apimname, resourceGroup);
4545
JObject oAuthorizationServers = JObject.Parse(authorizationServers);

src/APIM_ARMTemplate/apimtemplate/Extractor/EntityExtractors/BackendExtractor.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public async Task<string> GetBackend(string ApiManagementName, string ResourceGr
3030
return await CallApiManagement(azToken, requestUrl);
3131
}
3232

33-
public async Task<Template> GenerateBackendsARMTemplate(string apimname, string resourceGroup, string singleApiName, List<TemplateResource> armTemplateResources)
33+
public async Task<Template> GenerateBackendsARMTemplate(string apimname, string resourceGroup, string singleApiName, List<TemplateResource> apiTemplateResources)
3434
{
3535
Console.WriteLine("------------------------------------------");
3636
Console.WriteLine("Getting backends from service");
@@ -39,7 +39,7 @@ public async Task<Template> GenerateBackendsARMTemplate(string apimname, string
3939
List<TemplateResource> templateResources = new List<TemplateResource>();
4040

4141
// isolate api and operation policy resources in the case of a single api extraction, as they may reference backends
42-
var policyResources = armTemplateResources.Where(resource => (resource.type == ResourceTypeConstants.APIPolicy || resource.type == ResourceTypeConstants.APIOperationPolicy));
42+
var policyResources = apiTemplateResources.Where(resource => (resource.type == ResourceTypeConstants.APIPolicy || resource.type == ResourceTypeConstants.APIOperationPolicy));
4343

4444
string backends = await GetBackends(apimname, resourceGroup);
4545
JObject oBackends = JObject.Parse(backends);

src/APIM_ARMTemplate/apimtemplate/Extractor/EntityExtractors/LoggerExtractor.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,15 @@ public async Task<string> GetLogger(string ApiManagementName, string ResourceGro
3030
return await CallApiManagement(azToken, requestUrl);
3131
}
3232

33-
public async Task<Template> GenerateLoggerTemplate(string apimname, string resourceGroup, string singleApiName, List<TemplateResource> armTemplateResources)
33+
public async Task<Template> GenerateLoggerTemplate(string apimname, string resourceGroup, string singleApiName, List<TemplateResource> apiTemplateResources)
3434
{
3535
Console.WriteLine("------------------------------------------");
3636
Console.WriteLine("Getting loggers from service");
3737
Template armTemplate = GenerateEmptyTemplateWithParameters();
3838

3939
// isolate product api associations in the case of a single api extraction
40-
var diagnosticResources = armTemplateResources.Where(resource => resource.type == ResourceTypeConstants.APIDiagnostic);
41-
var policyResources = armTemplateResources.Where(resource => (resource.type == ResourceTypeConstants.APIPolicy || resource.type == ResourceTypeConstants.APIOperationPolicy));
40+
var diagnosticResources = apiTemplateResources.Where(resource => resource.type == ResourceTypeConstants.APIDiagnostic);
41+
var policyResources = apiTemplateResources.Where(resource => (resource.type == ResourceTypeConstants.APIPolicy || resource.type == ResourceTypeConstants.APIOperationPolicy));
4242

4343
List<TemplateResource> templateResources = new List<TemplateResource>();
4444

src/APIM_ARMTemplate/apimtemplate/Extractor/EntityExtractors/ProductExtractor.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@ public async Task<string> GetProductDetails(string ApiManagementName, string Res
3030
return await CallApiManagement(azToken, requestUrl);
3131
}
3232

33-
public async Task<Template> GenerateProductsARMTemplate(string apimname, string resourceGroup, string singleApiName, List<TemplateResource> armTemplateResources)
33+
public async Task<Template> GenerateProductsARMTemplate(string apimname, string resourceGroup, string singleApiName, List<TemplateResource> apiTemplateResources)
3434
{
3535
Console.WriteLine("------------------------------------------");
3636
Console.WriteLine("Getting products from service");
3737
Template armTemplate = GenerateEmptyTemplateWithParameters();
3838

3939
// isolate product api associations in the case of a single api extraction
40-
var productAPIResources = armTemplateResources.Where(resource => resource.type == ResourceTypeConstants.ProductAPI);
40+
var productAPIResources = apiTemplateResources.Where(resource => resource.type == ResourceTypeConstants.ProductAPI);
4141

4242
List<TemplateResource> templateResources = new List<TemplateResource>();
4343

src/APIM_ARMTemplate/apimtemplate/Extractor/EntityExtractors/PropertyExtractor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public async Task<string> GetProperty(string ApiManagementName, string ResourceG
2929
return await CallApiManagement(azToken, requestUrl);
3030
}
3131

32-
public async Task<Template> GenerateNamedValuesTemplate(string apimname, string resourceGroup, string singleApiName, List<TemplateResource> armTemplateResources)
32+
public async Task<Template> GenerateNamedValuesTemplate(string apimname, string resourceGroup, string singleApiName, List<TemplateResource> apiTemplateResources)
3333
{
3434
Console.WriteLine("------------------------------------------");
3535
Console.WriteLine("Getting named values from service");

0 commit comments

Comments
 (0)