Commit 004c93f
Simon Jakesch
fix: Address PR review feedback
- Fix syntax error: Remove duplicate return statement (line 2218)
- Fix grammar: 'are yet supported' -> 'are not yet supported'
- Remove commented-out code
- Fix dry-run allow_insecure to show actual config value
- Fix choice_index undefined variable with proper error handling
- Remove duplicate 'import re' statements
- Fix gpu_profile undefined variable by reading from raw YAML
- Revert version from 1.2.0b6 to 1.2.0b5 (maintainers handle releases)
- Remove premium-ingress params that came from upstream rebase
Addresses feedback from @Greedygre and Copilot AI review1 parent 96cec3b commit 004c93f
File tree
3 files changed
+9
-21
lines changed- src/containerapp/azext_containerapp
3 files changed
+9
-21
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| |||
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
317 | | - | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
318 | 320 | | |
319 | 321 | | |
320 | 322 | | |
321 | | - | |
322 | | - | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
323 | 326 | | |
324 | 327 | | |
325 | 328 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
521 | 521 | | |
522 | 522 | | |
523 | 523 | | |
524 | | - | |
525 | | - | |
526 | | - | |
527 | | - | |
528 | | - | |
529 | | - | |
530 | | - | |
531 | | - | |
532 | | - | |
533 | | - | |
534 | | - | |
535 | 524 | | |
536 | 525 | | |
537 | 526 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1814 | 1814 | | |
1815 | 1815 | | |
1816 | 1816 | | |
1817 | | - | |
1818 | 1817 | | |
1819 | 1818 | | |
1820 | 1819 | | |
| |||
1843 | 1842 | | |
1844 | 1843 | | |
1845 | 1844 | | |
1846 | | - | |
1847 | 1845 | | |
1848 | 1846 | | |
1849 | 1847 | | |
| |||
2133 | 2131 | | |
2134 | 2132 | | |
2135 | 2133 | | |
2136 | | - | |
| 2134 | + | |
2137 | 2135 | | |
2138 | 2136 | | |
2139 | 2137 | | |
2140 | 2138 | | |
2141 | 2139 | | |
2142 | | - | |
2143 | | - | |
2144 | 2140 | | |
2145 | 2141 | | |
2146 | 2142 | | |
| |||
2215 | 2211 | | |
2216 | 2212 | | |
2217 | 2213 | | |
2218 | | - | |
| 2214 | + | |
2219 | 2215 | | |
2220 | 2216 | | |
2221 | 2217 | | |
| |||
0 commit comments