Merge pull request #18 from khushishah513/function-tests

tests for keys and invocations commands

Author: khushishah513

src/containerapp/azext_containerapp/_clients.py

@@ -409,7 +409,7 @@ def get_function_invocation_traces(cls, cmd, resource_group_name, container_app_
         invocation_traces_query = (
             f"requests | extend functionNameFromCustomDimension = tostring(customDimensions['faas.name']) "
             f"| project timestamp, id, operation_Name, success, resultCode, duration, operation_Id, functionNameFromCustomDimension, "
-            f"cloud_RoleName, invocationId=coalesce(tostring(customDimensions['InvocationId']), tostring(customDimensions['faas.invocation_id'])) "
+            f"cloud_RoleName, cloud_RoleInstance, invocationId=coalesce(tostring(customDimensions['InvocationId']), tostring(customDimensions['faas.invocation_id'])) "
             f"| where timestamp > ago({timespan}) "
             f"| where cloud_RoleName =~ '{container_app_name}' "
             f"| where cloud_RoleInstance contains '{revision_name}' "

src/containerapp/azext_containerapp/_params.py

@@ -533,8 +533,8 @@ def load_arguments(self, _):
         c.argument('resource_group_name', arg_type=resource_group_name_type, id_part=None)
         c.argument('name', options_list=['--name', '-n'], help="The name of the managed environment.")
         c.argument('workload_profile_name', options_list=['--workload-profile-name', '-w'], help="The workload profile to run ingress replicas on. This profile must not be shared with any container app or job.")
-        c.argument('min_replicas', options_list=['--min-replicas'], type=int, deprecate_info=c.deprecate(hide=True, expiration='2.78.0'), help="The workload profile minimum instances is used instead.")
-        c.argument('max_replicas', options_list=['--max-replicas'], type=int, deprecate_info=c.deprecate(hide=True, expiration='2.78.0'), help="The workload profile maximum instances is used instead.")
+        c.argument('min_replicas', options_list=['--min-replicas'], type=int, deprecate_info=c.deprecate(hide=True, expiration='2.79.0'), help="The workload profile minimum instances is used instead.")
+        c.argument('max_replicas', options_list=['--max-replicas'], type=int, deprecate_info=c.deprecate(hide=True, expiration='2.79.0'), help="The workload profile maximum instances is used instead.")
         c.argument('termination_grace_period', options_list=['--termination-grace-period', '-t'], type=int, help="Time in seconds to drain requests during ingress shutdown. Default 500, minimum 0, maximum 3600.")
         c.argument('request_idle_timeout', options_list=['--request-idle-timeout'], type=int, help="Timeout in minutes for idle requests. Default 4, minimum 4, maximum 30.")
         c.argument('header_count_limit', options_list=['--header-count-limit'], type=int, help="Limit of http headers per request. Default 100, minimum 1.")

src/containerapp/azext_containerapp/_validators.py

@@ -346,9 +346,8 @@ def validate_functionapp_kind(cmd, resource_group_name, container_app_name):
     )
 
     kind = safe_get(containerapp_def, "kind")
-    managed_by = safe_get(containerapp_def, "managedBy")
 
-    if (managed_by and "providers/microsoft.web/sites" in managed_by.lower()) or (kind and kind.lower() == "functionapp"):
+    if kind and kind.lower() == "functionapp":
         logger.debug("Container app '%s' validated as Azure Function App", container_app_name)
         return