Skip to content

Commit 1b356a5

Browse files
committed
chore: add TODO comments on future changes required to aks-preview
1 parent e21724d commit 1b356a5

File tree

4 files changed

+11
-0
lines changed

4 files changed

+11
-0
lines changed

src/aks-preview/azext_aks_preview/_help.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1857,6 +1857,7 @@
18571857
short-summary: List node pools in the managed Kubernetes cluster.
18581858
"""
18591859

1860+
# TODO: Add params for blue green upgrade settings
18601861
helps['aks nodepool add'] = """
18611862
type: command
18621863
short-summary: Add a node pool to the managed Kubernetes cluster.

src/aks-preview/azext_aks_preview/_params.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1664,6 +1664,7 @@ def load_arguments(self, _):
16641664
c.argument("max_surge", validator=validate_max_surge)
16651665
c.argument("drain_timeout", type=int)
16661666
c.argument("node_soak_duration", type=int)
1667+
# TODO: Add args for blue green upgrades (and validators if needed)
16671668
c.argument("undrainable_node_behavior")
16681669
c.argument("max_unavailable", validator=validate_max_unavailable)
16691670
c.argument("max_blocked_nodes", validator=validate_max_blocked_nodes)

src/aks-preview/azext_aks_preview/agentpool_decorator.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -485,6 +485,8 @@ def get_undrainable_node_behavior(self) -> str:
485485
# this parameter does not need dynamic completion
486486
# this parameter does not need validation
487487
return undrainable_node_behavior
488+
489+
# TODO: Add getters for blue-green upgrade settings
488490

489491
def get_max_unavailable(self) -> str:
490492
"""Obtain the value of max_unavailable.
@@ -1260,6 +1262,8 @@ def set_up_upgrade_settings(self, agentpool: AgentPool) -> AgentPool:
12601262

12611263
agentpool.upgrade_settings = upgrade_settings
12621264
return agentpool
1265+
1266+
# TODO: Add a function to set up the blue green upgrade settings
12631267

12641268

12651269
class AKSPreviewAgentPoolUpdateDecorator(AKSAgentPoolUpdateDecorator):
@@ -1549,6 +1553,8 @@ def update_upgrade_settings(self, agentpool: AgentPool) -> AgentPool:
15491553
upgrade_settings.max_unavailable = max_unavailable
15501554

15511555
return agentpool
1556+
1557+
## TODO: Add a function to update the blue green upgrade settings
15521558

15531559
def update_agentpool(self, agentpool: AgentPool) -> AgentPool:
15541560
"""Send request to add a new agentpool.

src/aks-preview/azext_aks_preview/custom.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1378,6 +1378,7 @@ def aks_agentpool_add(
13781378
drain_timeout=None,
13791379
node_soak_duration=None,
13801380
undrainable_node_behavior=None,
1381+
# TODO: Add cli params for --upgrade-strategy and --upgrade-settings-blue-green
13811382
max_unavailable=None,
13821383
max_blocked_nodes=None,
13831384
mode=CONST_NODEPOOL_MODE_USER,
@@ -1463,6 +1464,7 @@ def aks_agentpool_update(
14631464
max_surge=None,
14641465
drain_timeout=None,
14651466
node_soak_duration=None,
1467+
# TODO: Add cli params for --upgrade-strategy and --upgrade-settings-blue-green
14661468
undrainable_node_behavior=None,
14671469
max_unavailable=None,
14681470
max_blocked_nodes=None,
@@ -1558,6 +1560,7 @@ def aks_agentpool_upgrade(cmd,
15581560
max_surge=None,
15591561
drain_timeout=None,
15601562
node_soak_duration=None,
1563+
# TODO: Add cli params for --upgrade-strategy and --upgrade-settings-blue-green
15611564
undrainable_node_behavior=None,
15621565
max_unavailable=None,
15631566
max_blocked_nodes=None,

0 commit comments

Comments
 (0)