add test for ManagedSystem pool

Author: Hao Yuan

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

@@ -1949,6 +1949,143 @@ def test_aks_enable_addon_with_azurekeyvaultsecretsprovider(
             ],
         )
 
+    @AllowLargeResponse()
+    @AKSCustomResourceGroupPreparer(
+        random_name_length=17, name_prefix="clitest", location="westus2"
+    )
+    def test_aks_create_normal_cluster_then_add_managed_system_pool(
+        self, resource_group, resource_group_location
+    ):
+        aks_name = self.create_random_name("cliakstest", 16)
+        nodepool_name = self.create_random_name("msnp", 12)
+        self.kwargs.update(
+            {
+                "resource_group": resource_group,
+                "name": aks_name,
+                "nodepool_name": nodepool_name,
+                "ssh_key_value": self.generate_ssh_keys(),
+            }
+        )
+
+        # Create a normal cluster without managed system pool
+        create_cmd = (
+            "aks create --resource-group={resource_group} --name={name} "
+            "-c 1 "
+            "--ssh-key-value={ssh_key_value} -o json"
+        )
+        self.cmd(
+            create_cmd,
+            checks=[
+                self.check("provisioningState", "Succeeded"),
+                self.check("agentPoolProfiles[0].mode", "System"),
+            ],
+        )
+
+        # Add a ManagedSystem node pool to the existing cluster should succeed
+        add_nodepool_cmd = (
+            "aks nodepool add --resource-group={resource_group} --cluster-name={name} "
+            "--name={nodepool_name} --mode ManagedSystem --node-count 1"
+        )
+        self.cmd(
+            add_nodepool_cmd,
+            checks=[
+                self.check("mode", "ManagedSystem"),
+                self.check("provisioningState", "Succeeded"),
+            ],
+        )
+
+        # Verify that the cluster now has both a normal System pool and a ManagedSystem pool
+        show_cmd = "aks show --resource-group={resource_group} --name={name} -o json"
+        cluster_info = self.cmd(show_cmd).get_output_in_json()
+
+        # Check that we have two node pools with different modes
+        agent_pools = cluster_info["agentPoolProfiles"]
+        modes = [pool["mode"] for pool in agent_pools]
+        assert "System" in modes, "Should have a normal System pool"
+        assert "ManagedSystem" in modes, "Should have a ManagedSystem pool"
+
+
+    @AllowLargeResponse()
+    @AKSCustomResourceGroupPreparer(
+        random_name_length=17, name_prefix="clitest", location="westus2"
+    )
+    def test_aks_create_with_managed_system_pool_multiple_fails(
+        self, resource_group, resource_group_location
+    ):
+        aks_name = self.create_random_name("cliakstest", 16)
+        nodepool_name = self.create_random_name("np", 12)
+        self.kwargs.update(
+            {
+                "resource_group": resource_group,
+                "name": aks_name,
+                "nodepool_name": nodepool_name,
+                "ssh_key_value": self.generate_ssh_keys(),
+            }
+        )
+
+        # Create cluster with managed system pool
+        create_cmd = (
+            "aks create --resource-group={resource_group} --name={name} "
+            "-c 1 "
+            "--enable-managed-system-pool "
+            "--ssh-key-value={ssh_key_value} -o json"
+        )
+        self.cmd(
+            create_cmd,
+            checks=[
+                self.check("provisioningState", "Succeeded"),
+                self.check("agentPoolProfiles[0].mode", "ManagedSystem"),
+            ],
+        )
+
+        # Attempt to add another ManagedSystem node pool should fail
+        add_nodepool_cmd = (
+            "aks nodepool add --resource-group={resource_group} --cluster-name={name} "
+            "--name={nodepool_name} --mode ManagedSystem --node-count 1"
+        )
+
+        # This should fail because only one ManagedSystem pool is allowed per cluster
+        with self.assertRaisesRegex(
+            (CLIError, ClientRequestError, HttpResponseError),
+            "only.*one.*ManagedSystem.*pool.*allowed|ManagedSystem.*pool.*already.*exists|cannot.*add.*multiple.*ManagedSystem"
+        ):
+            self.cmd(add_nodepool_cmd)
+
+        # Update the ManagedSystem pool to normal system pool should succeed
+        update_nodepool_cmd = (
+            "aks nodepool update --resource-group={resource_group} --cluster-name={name} "
+            "--name=nodepool1 --mode System"
+        )
+        self.cmd(
+            update_nodepool_cmd,
+            checks=[
+                self.check("mode", "System"),
+            ],
+        )
+        aks_name = self.create_random_name("cliakstest", 16)
+        self.kwargs.update(
+            {
+                "resource_group": resource_group,
+                "name": aks_name,
+                "ssh_key_value": self.generate_ssh_keys(),
+            }
+        )
+
+        create_cmd = (
+            "aks create --resource-group={resource_group} --name={name} "
+            "-c 1 "
+            "--enable-managed-system-pool "
+            "--ssh-key-value={ssh_key_value} -o json"
+        )
+        self.cmd(
+            create_cmd,
+            checks=[
+                self.check("provisioningState", "Succeeded"),
+                self.check("agentPoolProfiles[0].mode", "ManagedSystem"),
+                self.check("agentPoolProfiles[0].type", "VirtualMachines"),
+            ],
+        )
+
     @AllowLargeResponse()
     @AKSCustomResourceGroupPreparer(
         random_name_length=17, name_prefix="clitest", location="westus2"
@@ -2647,7 +2784,7 @@ def test_aks_nodepool_add_with_ossku_windows2022(
             "aks delete -g {resource_group} -n {name} --yes --no-wait",
             checks=[self.is_empty()],
         )
-        
+
     @AllowLargeResponse()
     @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus')
     def test_aks_nodepool_add_with_ossku_ubuntu2204(self, resource_group, resource_group_location):
@@ -3165,7 +3302,7 @@ def test_aks_nodepool_undrainable_node_behavior(
             checks=[self.is_empty()],
         )
 
-    
+
     @AllowLargeResponse()
     @AKSCustomResourceGroupPreparer(
         random_name_length=17, name_prefix="clitest", location="westus2"
@@ -7241,7 +7378,7 @@ def test_aks_maintenanceconfiguration(
             "aks delete -g {resource_group} -n {name} --yes --no-wait",
             checks=[self.is_empty()],
         )
-    
+
     @AllowLargeResponse()
     @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='uksouth')
     def test_aks_managed_namespace(self, resource_group, resource_group_location):
@@ -7294,21 +7431,21 @@ def test_aks_managed_namespace(self, resource_group, resource_group_location):
         list_namespace_full_cmd = (
             "aks namespace list --resource-group={resource_group} --cluster-name={resource_name} -o json"
         )
-        
+
         namespace_list = self.cmd(list_namespace_full_cmd).get_output_in_json()
         assert len(namespace_list) > 0
 
         list_namespace_with_resource_group_cmd = (
             "aks namespace list --resource-group={resource_group} -o json"
         )
-        
+
         namespace_list = self.cmd(list_namespace_with_resource_group_cmd).get_output_in_json()
         assert len(namespace_list) > 0
 
         list_namespace_subscription_level_cmd = (
             "aks namespace list -o json"
         )
-        
+
         namespace_list = self.cmd(list_namespace_subscription_level_cmd).get_output_in_json()
         assert len(namespace_list) > 0
 
@@ -12651,7 +12788,7 @@ def test_aks_azure_service_mesh_with_egress_gateway(
     ):
         """This test case exercises enabling and disabling an Istio egress gateway.
 
-        It creates a cluster with azure service mesh profile and Static Egress Gateway enabled. 
+        It creates a cluster with azure service mesh profile and Static Egress Gateway enabled.
         After that, we create a gateway nodepool and a staticgatewayconfiguration resource.
         Then, we create an Istio egress gateway, and then delete it.
         """
@@ -12742,7 +12879,7 @@ def test_aks_azure_service_mesh_with_egress_gateway(
                 self.cmd(get_credential_cmd)
             finally:
                 os.close(fd)
-            
+
             sgcResource = f"""apiVersion: egressgateway.kubernetes.azure.com/v1alpha1
 kind: StaticGatewayConfiguration
 metadata:
@@ -12751,7 +12888,7 @@ def test_aks_azure_service_mesh_with_egress_gateway(
 spec:
   gatewayNodepoolName: {gwNodepoolName}
 """
-            
+
             sgc_fd, sgc_browse_path = tempfile.mkstemp()
 
             try:
@@ -13655,7 +13792,7 @@ def test_aks_create_with_advanced_networkpolicies(
             "aks delete -g {resource_group} -n {name} --yes --no-wait",
             checks=[self.is_empty()],
         )
-    
+
     @AllowLargeResponse()
     @AKSCustomResourceGroupPreparer(
         random_name_length=17,
@@ -13701,7 +13838,7 @@ def test_aks_create_with_transit_encryption_type(
             "aks delete -g {resource_group} -n {name} --yes --no-wait",
             checks=[self.is_empty()],
         )
-    
+
     @AllowLargeResponse()
     @AKSCustomResourceGroupPreparer(
         random_name_length=17,
@@ -16204,11 +16341,11 @@ def test_aks_extension_backup(self, resource_group, resource_group_location):
                  '--location {location} --sku Standard_LRS '
                  '--allow-shared-key-access false')
 
-        # create blob container in storage account 
-        self.cmd('storage container create --name {blob} --account-name {storageAccount} ' 
+        # create blob container in storage account
+        self.cmd('storage container create --name {blob} --account-name {storageAccount} '
                  '--auth-mode login')
 
-        # create the cluster 
+        # create the cluster
         response = self.cmd('aks create -g {rg} -n {cluster_name} '
                  '--node-count 3  --ssh-key-value={ssh_key_value}').get_output_in_json()
         cluster_resource_id = response["id"]
@@ -16220,13 +16357,13 @@ def test_aks_extension_backup(self, resource_group, resource_group_location):
         # create the K8s extension
         self.cmd('aks extension create -g {rg} -n {name} -c {cluster_name} '
                  '--extension-type {extension_type}  --scope cluster '
-                 '--config useKubeletIdentity=true  --no-wait ' 
+                 '--config useKubeletIdentity=true  --no-wait '
                  '--configuration-settings blobContainer={blob} '
                  'storageAccount={storageAccount} '
                  'storageAccountResourceGroup={rg} '
                  'storageAccountSubscriptionId={subscription}')
 
-        # Update the K8s extension 
+        # Update the K8s extension
         self.cmd('aks extension update -g {rg} -n {name} -c {cluster_name} --yes '
                  '--no-wait --configuration-settings testKey=testValue')
 
@@ -16305,11 +16442,11 @@ def test_aks_extension_type_backup(self, resource_group, resource_group_location
                  '--location {location} --sku Standard_LRS '
                  '--allow-shared-key-access false')
 
-        # create blob container in storage account 
-        self.cmd('storage container create --name {blob} --account-name {storageAccount} ' 
+        # create blob container in storage account
+        self.cmd('storage container create --name {blob} --account-name {storageAccount} '
                  '--auth-mode login')
 
-        # create the cluster 
+        # create the cluster
         response = self.cmd('aks create -g {rg} -n {cluster_name} '
                  '--node-count 3  --ssh-key-value={ssh_key_value}').get_output_in_json()
         cluster_resource_id = response["id"]
@@ -16321,7 +16458,7 @@ def test_aks_extension_type_backup(self, resource_group, resource_group_location
         # create the K8s extension
         self.cmd('aks extension create -g {rg} -n {name} -c {cluster_name} '
                  '--extension-type {extension_type}  --scope cluster '
-                 '--config useKubeletIdentity=true  --no-wait ' 
+                 '--config useKubeletIdentity=true  --no-wait '
                  '--configuration-settings blobContainer={blob} '
                  'storageAccount={storageAccount} '
                  'storageAccountResourceGroup={rg} '
@@ -16554,7 +16691,7 @@ def test_aks_loadbalancer_commands(
     #     create_cmd = (
     #         "aks create --resource-group={resource_group} --name={name} --location={location} "
     #         "--ssh-key-value={ssh_key_value} "
-    #         "--vm-set-type AvailabilitySet " 
+    #         "--vm-set-type AvailabilitySet "
     #         "--load-balancer-sku Basic "
     #     )
     #     self.cmd(