Skip to content

Commit 2aa7bd5

Browse files
authored
Use 2nd latest revision for ASM e2e (#8908)
1 parent b55f88c commit 2aa7bd5

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,15 @@ def _convert_revision_to_semver(rev):
161161
sorted_revisions = sorted(revisions, key=_convert_revision_to_semver)
162162
return sorted_revisions
163163

164-
def _get_asm_supported_revision(self, location):
164+
def _get_asm_supported_revision(self, location, secondLatest=False):
165165
mesh_revisions_cmd = f"aks mesh get-revisions -l {location}"
166166
mesh_revisions = self.cmd(mesh_revisions_cmd).get_output_in_json()
167167
assert len(mesh_revisions["meshRevisions"]) > 0
168168
revisions = [r["revision"] for r in mesh_revisions["meshRevisions"]]
169169
sorted_revisons = self._sort_revisions(revisions)
170+
lenRevisions = len(sorted_revisons)
171+
if secondLatest and lenRevisions > 1:
172+
return sorted_revisons[lenRevisions - 2] # Return the second latest revision
170173
return sorted_revisons[0]
171174

172175
def _get_asm_upgrade_version(self, resource_group, name):
@@ -12541,7 +12544,7 @@ def test_aks_azure_service_mesh_enable_disable(
1254112544
"name": aks_name,
1254212545
"location": resource_group_location,
1254312546
"ssh_key_value": self.generate_ssh_keys(),
12544-
"revision": self._get_asm_supported_revision(resource_group_location),
12547+
"revision": self._get_asm_supported_revision(resource_group_location, False),
1254512548
}
1254612549
)
1254712550

@@ -12615,7 +12618,7 @@ def test_aks_azure_service_mesh_with_egress_gateway(
1261512618
"name": aks_name,
1261612619
"location": resource_group_location,
1261712620
"ssh_key_value": self.generate_ssh_keys(),
12618-
"revision": self._get_asm_supported_revision("westus2"), # Temporarily set to prod region to avoid using unsupported ASM revision for centraluseap
12621+
"revision": self._get_asm_supported_revision(resource_group_location, True),
1261912622
}
1262012623
)
1262112624

@@ -12823,7 +12826,7 @@ def test_aks_azure_service_mesh_with_ingress_gateway(
1282312826
"name": aks_name,
1282412827
"location": resource_group_location,
1282512828
"ssh_key_value": self.generate_ssh_keys(),
12826-
"revision": self._get_asm_supported_revision(resource_group_location),
12829+
"revision": self._get_asm_supported_revision(resource_group_location, False),
1282712830
}
1282812831
)
1282912832

@@ -12909,7 +12912,7 @@ def test_aks_azure_service_mesh_canary_upgrade(
1290912912
self.test_resources_count = 0
1291012913
# kwargs for string formatting
1291112914
aks_name = self.create_random_name("cliakstest", 16)
12912-
installed_revision = self._get_asm_supported_revision(resource_group_location)
12915+
installed_revision = self._get_asm_supported_revision(resource_group_location, False)
1291312916
self.kwargs.update(
1291412917
{
1291512918
"resource_group": resource_group,
@@ -13036,7 +13039,7 @@ def test_aks_azure_service_mesh_with_pluginca(
1303613039
"location": resource_group_location,
1303713040
"ssh_key_value": self.generate_ssh_keys(),
1303813041
"akv_resource_id": akv_resource_id,
13039-
"revision": self._get_asm_supported_revision(resource_group_location),
13042+
"revision": self._get_asm_supported_revision(resource_group_location, False),
1304013043
}
1304113044
)
1304213045

@@ -13144,7 +13147,7 @@ def test_aks_azure_service_mesh_get_upgrades(
1314413147
"name": aks_name,
1314513148
"location": resource_group_location,
1314613149
"ssh_key_value": self.generate_ssh_keys(),
13147-
"revision": self._get_asm_supported_revision(resource_group_location),
13150+
"revision": self._get_asm_supported_revision(resource_group_location, False),
1314813151
}
1314913152
)
1315013153

0 commit comments

Comments
 (0)