fixing style and removing tests

Author: kshitij-microsoft

src/machinelearningservices/azext_mlv2/manual/_help/_deployment_template_help.py

@@ -7,22 +7,22 @@
 
 def get_deployment_template_help():
     """Load deployment template help content."""
-    pass  # Help content is defined below using helps dictionary
+
 
 helps['ml deployment-template'] = """
 type: group
 short-summary: Manage Azure ML deployment templates.
 long-summary: |
-    Deployment templates are reusable templates that define deployment configurations for Azure ML. 
-    They support registry-based operations only (not workspace-based) and provide a way to 
+    Deployment templates are reusable templates that define deployment configurations for Azure ML.
+    They support registry-based operations only (not workspace-based) and provide a way to
     standardize and share deployment configurations across teams and projects.
 """
 
 helps['ml deployment-template list'] = """
 type: command
 short-summary: List deployment templates in a registry.
 long-summary: |
-    List all deployment templates available in the specified registry. This command 
+    List all deployment templates available in the specified registry. This command
     returns all templates along with their metadata including name, version, description, and tags.
 examples:
   - name: List all deployment templates in a registry
@@ -35,7 +35,7 @@ def get_deployment_template_help():
 type: command
 short-summary: Get a specific deployment template by name and version.
 long-summary: |
-    Retrieve detailed information about a specific deployment template. If version is not 
+    Retrieve detailed information about a specific deployment template. If version is not
     specified, the latest version will be returned.
 examples:
   - name: Get a specific version of a deployment template
@@ -46,7 +46,7 @@ def get_deployment_template_help():
 type: command
 short-summary: Create a new deployment template from a YAML file.
 long-summary: |
-    Create a new deployment template using a YAML configuration file. The YAML file should 
+    Create a new deployment template using a YAML configuration file. The YAML file should
     contain the complete deployment template definition including endpoints, parameters, and metadata.
     You can override specific values using command-line parameters.
 examples:
@@ -62,11 +62,11 @@ def get_deployment_template_help():
 type: command
 short-summary: Update specific fields of an existing deployment template.
 long-summary: |
-    Update metadata fields (description and tags) of an existing deployment template without 
-    requiring a YAML file. This command follows Azure CLI conventions and only accepts specific 
+    Update metadata fields (description and tags) of an existing deployment template without
+    requiring a YAML file. This command follows Azure CLI conventions and only accepts specific
     field updates. Tags are merged with existing tags rather than replaced.
-    
-    For structural changes to the deployment template (endpoints, deployment configuration, etc.), 
+
+    For structural changes to the deployment template (endpoints, deployment configuration, etc.),
     use the 'create' command with a YAML file.
 examples:
   - name: Update deployment template description
@@ -81,8 +81,8 @@ def get_deployment_template_help():
 type: command
 short-summary: Archive a deployment template.
 long-summary: |
-    Archive a deployment template to mark it as inactive. Archived templates are not 
-    returned in list operations by default. You can archive a specific version or all 
+    Archive a deployment template to mark it as inactive. Archived templates are not
+    returned in list operations by default. You can archive a specific version or all
     versions of a template.
 examples:
   - name: Archive a specific version
@@ -95,8 +95,8 @@ def get_deployment_template_help():
 type: command
 short-summary: Restore an archived deployment template.
 long-summary: |
-    Restore a previously archived deployment template to make it active again. Restored 
-    templates will appear in list operations. You can restore a specific version or all 
+    Restore a previously archived deployment template to make it active again. Restored
+    templates will appear in list operations. You can restore a specific version or all
     versions of a template.
 examples:
   - name: Restore a specific version

src/machinelearningservices/azext_mlv2/manual/_params/_deployment_template_params.py

@@ -2,7 +2,14 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # ---------------------------------------------------------
 
-from ._common_params import add_common_params, add_description_param, add_file_param, add_lro_param, add_override_param, add_tags_param
+from ._common_params import (
+    add_common_params,
+    add_description_param,
+    add_file_param,
+    add_lro_param,
+    add_override_param,
+    add_tags_param,
+)
 
 
 def add_deployment_template_common_param(
@@ -23,7 +30,10 @@ def load_deployment_template_params(self):
             "registry_name",
             options_list=["--registry-name", "-r"],
             required=True,
-            help="Name of the registry. This is required since deployment templates only support registry-name and not workspace.",
+            help=(
+                "Name of the registry. This is required since deployment templates "
+                "only support registry-name and not workspace."
+            ),
         )
 
     with self.argument_context("ml deployment-template get") as c:
@@ -33,20 +43,27 @@ def load_deployment_template_params(self):
             "registry_name",
             options_list=["--registry-name", "-r"],
             required=True,
-            help="Name of the registry. This is required since deployment templates only support registry-name and not workspace.",
+            help=(
+                "Name of the registry. This is required since deployment templates "
+                "only support registry-name and not workspace."
+            ),
         )
 
     with self.argument_context("ml deployment-template create") as c:
         add_common_params(c)
-        add_deployment_template_common_param(c, name_required=False, version_required=False)  # Optional for create since they can come from file
+        # Optional for create since they can come from file
+        add_deployment_template_common_param(c, name_required=False, version_required=False)
         add_lro_param(c)
         add_file_param(c, "deployment-template", "https://aka.ms/ml-cli-v2-deployment-template-yaml")
         add_override_param(c)
         c.argument(
             "registry_name",
             options_list=["--registry-name", "-r"],
             required=True,
-            help="Name of the registry. This is required since deployment templates only support registry-name and not workspace.",
+            help=(
+                "Name of the registry. This is required since deployment templates "
+                "only support registry-name and not workspace."
+            ),
         )
 
     with self.argument_context("ml deployment-template update") as c:
@@ -59,7 +76,10 @@ def load_deployment_template_params(self):
             "registry_name",
             options_list=["--registry-name", "-r"],
             required=True,
-            help="Name of the registry. This is required since deployment templates only support registry-name and not workspace.",
+            help=(
+                "Name of the registry. This is required since deployment templates "
+                "only support registry-name and not workspace."
+            ),
         )
 
     with self.argument_context("ml deployment-template archive") as c:
@@ -70,7 +90,10 @@ def load_deployment_template_params(self):
             "registry_name",
             options_list=["--registry-name", "-r"],
             required=True,
-            help="Name of the registry. This is required since deployment templates only support registry-name and not workspace.",
+            help=(
+                "Name of the registry. This is required since deployment templates "
+                "only support registry-name and not workspace."
+            ),
         )
 
     with self.argument_context("ml deployment-template restore") as c:
@@ -81,5 +104,8 @@ def load_deployment_template_params(self):
             "registry_name",
             options_list=["--registry-name", "-r"],
             required=True,
-            help="Name of the registry. This is required since deployment templates only support registry-name and not workspace.",
+            help=(
+                "Name of the registry. This is required since deployment templates "
+                "only support registry-name and not workspace."
+            ),
         )

src/machinelearningservices/azext_mlv2/manual/commands.py

@@ -231,16 +231,19 @@ def load_command_table(self, _):
         custom_deployment_template = CliCommandType(operations_tmpl=custom_tmpl)
         g.custom_command("list", "ml_deployment_template_list", command_type=custom_deployment_template)
         g.custom_command("get", "ml_deployment_template_get", command_type=custom_deployment_template)
-        g.custom_command("create", "ml_deployment_template_create", supports_no_wait=True, command_type=custom_deployment_template)
+        g.custom_command("create", "ml_deployment_template_create", supports_no_wait=True,
+                         command_type=custom_deployment_template)
         g.generic_update_command(
             "update",
             getter_name="ml_deployment_template_get",
             getter_type=custom_deployment_template,
             setter_name="_ml_deployment_template_update",
             setter_type=custom_deployment_template,
         )
-        g.custom_command("archive", "ml_deployment_template_archive", supports_no_wait=True, command_type=custom_deployment_template)
-        g.custom_command("restore", "ml_deployment_template_restore", supports_no_wait=True, command_type=custom_deployment_template)
+        g.custom_command("archive", "ml_deployment_template_archive", supports_no_wait=True,
+                         command_type=custom_deployment_template)
+        g.custom_command("restore", "ml_deployment_template_restore", supports_no_wait=True,
+                         command_type=custom_deployment_template)
 
     with self.command_group("ml compute", client_factory=cf_ml_cl) as g:
         custom_tmpl = "azext_mlv2.manual.custom.compute#{}"

src/machinelearningservices/azext_mlv2/manual/custom/deployment_template.py

@@ -1,4 +1,4 @@
-# ---------------------------------------------------------
+# ---------------------------------------------------------
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # ---------------------------------------------------------
 
@@ -10,11 +10,8 @@
 except ImportError:
     load_deployment_template = None
 
-from azure.ai.ml.exceptions import ErrorCategory, ErrorTarget, UserErrorException, ValidationException
-
 from .raise_error import log_and_raise_error
 from .utils import (
-    _dump_entity_with_warnings,
     get_ml_client,
     is_not_found_error,
     wrap_lro,
@@ -30,7 +27,7 @@ def ml_deployment_template_list(cmd, registry_name=None):
     ml_client, debug = get_ml_client(
         cli_ctx=cmd.cli_ctx, registry_name=registry_name
     )
-    
+
     try:
         deployment_templates = ml_client.deployment_templates.list()
         # Handle DeploymentTemplate serialization - try as_dict() first, then _to_dict()
@@ -57,16 +54,15 @@ def ml_deployment_template_get(cmd, name, version=None, registry_name=None):
     ml_client, debug = get_ml_client(
         cli_ctx=cmd.cli_ctx, registry_name=registry_name
     )
-    
+
     try:
         deployment_template = ml_client.deployment_templates.get(name=name, version=version)
         # Handle DeploymentTemplate serialization
         if hasattr(deployment_template, 'as_dict'):
             return deployment_template.as_dict()
-        elif hasattr(deployment_template, '_to_dict'):
+        if hasattr(deployment_template, '_to_dict'):
             return deployment_template._to_dict()  # pylint: disable=protected-access
-        else:
-            return dict(deployment_template)
+        return dict(deployment_template)
     except Exception as err:  # pylint: disable=broad-except
         if is_not_found_error(err):
             raise ValueError(f"Deployment template '{name}' with version '{version}' does not exist.") from err
@@ -87,35 +83,35 @@ def ml_deployment_template_create(
     ml_client, debug = get_ml_client(
         cli_ctx=cmd.cli_ctx, registry_name=registry_name
     )
-    
+
     params_override = params_override or []
-    
+
     try:
         if name:
             params_override.append({"name": name})
         if version:
             params_override.append({"version": version})
-            
+
         if load_deployment_template:
             deployment_template = load_deployment_template(source=file, params_override=params_override)
         else:
             # Fallback: load YAML manually if load_deployment_template is not available
             import yaml
             if not file:
                 raise ValueError("A YAML file must be provided for deployment template creation.")
-                
+
             with open(file, 'r', encoding='utf-8') as f:
                 yaml_content = yaml.safe_load(f)
-            
+
             # Apply parameter overrides
             for override in params_override:
                 if isinstance(override, dict):
                     yaml_content.update(override)
-            
+
             deployment_template = yaml_content
-            
+
         deployment_template_result = ml_client.deployment_templates.create_or_update(deployment_template)
-        
+
         if no_wait:
             module_logger.warning(
                 "Deployment template create/update request initiated. "
@@ -124,16 +120,14 @@ def ml_deployment_template_create(
                 deployment_template.version if hasattr(deployment_template, 'version') else version or "unknown"
             )
             return None
-        else:
-            deployment_template_result = wrap_lro(cmd.cli_ctx, deployment_template_result)
-            
+        deployment_template_result = wrap_lro(cmd.cli_ctx, deployment_template_result)
+
         # Handle serialization
         if hasattr(deployment_template_result, 'as_dict'):
             return deployment_template_result.as_dict()
-        elif hasattr(deployment_template_result, '_to_dict'):
+        if hasattr(deployment_template_result, '_to_dict'):
             return deployment_template_result._to_dict()  # pylint: disable=protected-access
-        else:
-            return dict(deployment_template_result)
+        return dict(deployment_template_result)
     except Exception as err:  # pylint: disable=broad-except
         yaml_operation = bool(file)
         log_and_raise_error(err, debug, yaml_operation=yaml_operation)
@@ -158,10 +152,9 @@ def _ml_deployment_template_update(
         # Handle serialization
         if hasattr(deployment_template_result, 'as_dict'):
             return deployment_template_result.as_dict()
-        elif hasattr(deployment_template_result, '_to_dict'):
+        if hasattr(deployment_template_result, '_to_dict'):
             return deployment_template_result._to_dict()  # pylint: disable=protected-access
-        else:
-            return dict(deployment_template_result)
+        return dict(deployment_template_result)
     except Exception as err:  # pylint: disable=broad-except
         log_and_raise_error(err, debug)
 
@@ -171,19 +164,18 @@ def _ml_deployment_template_show(cmd, name, version=None, registry_name=None):
     ml_client, debug = get_ml_client(
         cli_ctx=cmd.cli_ctx, registry_name=registry_name
     )
-    
+
     try:
         deployment_template = ml_client.deployment_templates.get(name=name, version=version)
-        
+
         # Use to_rest_object to get proper field naming (snake_case instead of camelCase)
         if hasattr(deployment_template, 'to_rest_object'):
             return deployment_template.to_rest_object()
-        elif hasattr(deployment_template, 'as_dict'):
+        if hasattr(deployment_template, 'as_dict'):
             return deployment_template.as_dict()
-        elif hasattr(deployment_template, '_to_dict'):
+        if hasattr(deployment_template, '_to_dict'):
             return deployment_template._to_dict()  # pylint: disable=protected-access
-        else:
-            return dict(deployment_template)
+        return dict(deployment_template)
     except Exception as err:  # pylint: disable=broad-except
         if is_not_found_error(err):
             raise ValueError(f"Deployment template '{name}' with version '{version}' does not exist.") from err
@@ -202,7 +194,7 @@ def ml_deployment_template_archive(
     ml_client, debug = get_ml_client(
         cli_ctx=cmd.cli_ctx, registry_name=registry_name
     )
-    
+
     try:
         ml_client.deployment_templates.archive(name=name, version=version)
     except Exception as err:  # pylint: disable=broad-except
@@ -221,11 +213,8 @@ def ml_deployment_template_restore(
     ml_client, debug = get_ml_client(
         cli_ctx=cmd.cli_ctx, registry_name=registry_name
     )
-    
+
     try:
         ml_client.deployment_templates.restore(name=name, version=version)
     except Exception as err:  # pylint: disable=broad-except
         log_and_raise_error(err, debug)
-
-
-