Skip to content

Commit 3747639

Browse files
author
Shichao Qiu
committed
remove GPU support
1 parent 3ed5929 commit 3747639

File tree

4 files changed

+3
-19
lines changed

4 files changed

+3
-19
lines changed

src/containerapp/HISTORY.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Release History
44
===============
55
upcoming
66
++++++
7+
* 'az containerapp sessionpool create': Add `Shell` container type
78

89
1.2.0b4
910
++++++
@@ -14,7 +15,6 @@ upcoming
1415
* 'az containerapp env premium-ingress': Deprecate `--min-replicas` and `--max-replicas` parameters, use workload profile scale instead.
1516
* 'az containerapp sessionpool create/update': Support `--probe-yaml`
1617
* 'az containerapp session stop': Support stop session for custom container sessions
17-
* 'az containerapp sessionpool create': Add `Shell` and `GpuBase` container types
1818

1919
1.2.0b3
2020
++++++

src/containerapp/azext_containerapp/_help.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1971,10 +1971,6 @@
19711971
text: |
19721972
az containerapp sessionpool create -n mysessionpool -g MyResourceGroup \\
19731973
--container-type Shell --location westus3
1974-
- name: Create or update a Session Pool with container type GpuBase default settings.
1975-
text: |
1976-
az containerapp sessionpool create -n mysessionpool -g MyResourceGroup \\
1977-
--container-type GpuBase --location westus3
19781974
- name: Create or update a Session Pool with container type PythonLTS, with max concurrent sessions is 30, ready session instances 20.
19791975
text: |
19801976
az containerapp sessionpool create -n mysessionpool -g MyResourceGroup \\

src/containerapp/azext_containerapp/_params.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def load_arguments(self, _):
451451
c.argument('network_status', arg_type=get_enum_type(["EgressEnabled", "EgressDisabled"]), help="Egress is enabled for the Sessions or not.")
452452

453453
with self.argument_context('containerapp sessionpool create', arg_group='Configuration') as c:
454-
c.argument('container_type', arg_type=get_enum_type(["CustomContainer", "PythonLTS", "NodeLTS", "Shell", "GpuBase"]), help="The pool type of the Session Pool, default='PythonLTS'")
454+
c.argument('container_type', arg_type=get_enum_type(["CustomContainer", "PythonLTS", "NodeLTS", "Shell"]), help="The pool type of the Session Pool, default='PythonLTS'")
455455
c.argument('lifecycle_type', arg_type=get_enum_type(["Timed", "OnContainerExit"]), help="The lifecycle type of the Session Pool", default='Timed')
456456

457457
with self.argument_context('containerapp sessionpool update', arg_group='Configuration') as c:

src/containerapp/azext_containerapp/tests/latest/test_containerapp_sessionpool.py

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,6 @@ def test_containerapp_sessionpool_e2e(self, resource_group, subnet_id, vnet_name
5858
JMESPathCheck('properties.dynamicPoolConfiguration.lifecycleConfiguration.cooldownPeriodInSeconds', 300),
5959
])
6060

61-
# Create GpuBase SessionPool
62-
sessionpool_name_gpu = self.create_random_name(prefix='spgpu', length=24)
63-
self.cmd('containerapp sessionpool create -g {} -n {} --container-type GpuBase --cooldown-period {}'.format(
64-
resource_group, sessionpool_name_gpu, 300), checks=[
65-
JMESPathCheck('name', sessionpool_name_gpu),
66-
JMESPathCheck('properties.containerType', "GpuBase"),
67-
JMESPathCheck('properties.provisioningState', "Succeeded"),
68-
JMESPathCheck('properties.dynamicPoolConfiguration.lifecycleConfiguration.lifecycleType', "Timed"),
69-
JMESPathCheck('properties.dynamicPoolConfiguration.lifecycleConfiguration.cooldownPeriodInSeconds', 300),
70-
])
71-
7261
# Create CustomContainer SessionPool
7362
sessionpool_name_custom = self.create_random_name(prefix='spcustomcontainer', length=24)
7463
ready_instances = 2
@@ -106,7 +95,7 @@ def test_containerapp_sessionpool_e2e(self, resource_group, subnet_id, vnet_name
10695

10796
# List Session Pools
10897
sessionpool_list = self.cmd("containerapp sessionpool list -g {}".format(resource_group)).get_output_in_json()
109-
self.assertTrue(len(sessionpool_list) == 4)
98+
self.assertTrue(len(sessionpool_list) == 3)
11099

111100
# Update Session Pool
112101
max_concurrent_session = 12
@@ -155,7 +144,6 @@ def test_containerapp_sessionpool_e2e(self, resource_group, subnet_id, vnet_name
155144
self.cmd('containerapp sessionpool delete -g {} -n {} --yes'.format(resource_group, sessionpool_name_python))
156145
self.cmd('containerapp sessionpool delete -g {} -n {} --yes'.format(resource_group, sessionpool_name_custom))
157146
self.cmd('containerapp sessionpool delete -g {} -n {} --yes'.format(resource_group, sessionpool_name_shell))
158-
self.cmd('containerapp sessionpool delete -g {} -n {} --yes'.format(resource_group, sessionpool_name_gpu))
159147

160148
# List Session Pools
161149
sessionpool_list = self.cmd("containerapp sessionpool list -g {}".format(resource_group)).get_output_in_json()

0 commit comments

Comments
 (0)