Addressing style issues

Author: mettursathish

src/migrate/HISTORY.rst

@@ -11,14 +11,14 @@ Release History
 +++++++++++++++
 * Refactor codebase for improved readability and maintainability.
 
-2.0.1b1
-+++++++++++++++
-* Switch to experimental version.
-
 2.0.0
 +++++++++++++++
 * New version.
 
+2.0.1b1
++++++++++++++++
+* Switch to experimental version.
+
 1.0.0
 +++++++++++++++
 * Initial release.

src/migrate/azext_migrate/commands.py

@@ -16,6 +16,6 @@ def load_command_table(self, _):
         g.custom_command('get', 'get_local_server_replication')
         g.custom_command('remove', 'remove_local_server_replication')
         g.custom_command('get-job', 'get_local_replication_job')
-        
+
     with self.command_group('migrate local', is_preview=True) as g:
-        g.custom_command('start-migration', 'start_local_server_migration')
+        g.custom_command('start-migration', 'start_local_server_migration')

src/migrate/azext_migrate/custom.py

@@ -468,13 +468,13 @@ def get_local_server_replication(cmd,
     # If both are provided, prefer ID
     if protected_item_id:
         return get_protected_item_by_id(cmd, protected_item_id)
-    
+
     # If using name, require resource_group and project_name
     if not resource_group or not project_name:
         raise CLIError(
             "When using --protected-item-name, both --resource-group and "
             "--project-name are required.")
-    
+
     return get_protected_item_by_name(
         cmd, subscription_id, resource_group, project_name, protected_item_name)
 
@@ -513,6 +513,7 @@ def remove_local_server_replication(cmd,
         protected_item_name, force_remove
     )
 
+
 def start_local_server_migration(cmd,
                                  protected_item_id=None,
                                  turn_off_source_server=False,

src/migrate/azext_migrate/helpers/migration/start/_execute_migrate.py

@@ -146,30 +146,30 @@ def get_job_from_operation(cmd, subscription_id, resource_group_name,
         # Try to get the job name from the response headers
         # Azure-AsyncOperation or Location headers typically contain the operation URL
         headers = operation_response.headers
-        
+
         # Check for Azure-AsyncOperation header
         async_op_url = headers.get('Azure-AsyncOperation') or headers.get('azure-asyncoperation')
         location_url = headers.get('Location') or headers.get('location')
-        
+
         operation_url = async_op_url or location_url
-        
+
         if operation_url:
             # Extract job name from the operation URL
             # URL typically ends with: .../workflows/{jobName}
             url_parts = operation_url.split('/')
-            
+
             # Look for the job name in the URL
             for i, part in enumerate(url_parts):
                 if part in ['workflows', 'operations'] and i + 1 < len(url_parts):
                     job_name_with_params = url_parts[i + 1]
                     # Remove query parameters and underscores
                     job_name = job_name_with_params.split('?')[0].split('_')[0]
-                    
+
                     logger.info(
                         "Extracted job name '%s' from operation response",
                         job_name
                     )
-                    
+
                     # Get the job details
                     job_uri = (
                         f"/subscriptions/{subscription_id}/"
@@ -179,20 +179,20 @@ def get_job_from_operation(cmd, subscription_id, resource_group_name,
                         f"jobs/{job_name}?"
                         f"api-version={APIVersion.Microsoft_DataReplication.value}"
                     )
-                    
+
                     full_uri = (
                         cmd.cli_ctx.cloud.endpoints.resource_manager + job_uri
                     )
-                    
+
                     job_response = send_get_request(cmd, full_uri)
                     return job_response.json()
-        
+
         # If we can't extract job name, try to get it from response body
         if operation_response.status_code == 202:
             response_body = operation_response.json()
             if 'name' in response_body:
                 job_name = response_body['name'].split('/')[-1].split('_')[0]
-                
+
                 job_uri = (
                     f"/subscriptions/{subscription_id}/"
                     f"resourceGroups/{resource_group_name}/"
@@ -201,11 +201,11 @@ def get_job_from_operation(cmd, subscription_id, resource_group_name,
                     f"jobs/{job_name}?"
                     f"api-version={APIVersion.Microsoft_DataReplication.value}"
                 )
-                
+
                 full_uri = (
                     cmd.cli_ctx.cloud.endpoints.resource_manager + job_uri
                 )
-                
+
                 job_response = send_get_request(cmd, full_uri)
                 return job_response.json()
 
@@ -215,18 +215,17 @@ def get_job_from_operation(cmd, subscription_id, resource_group_name,
         )
         return None
 
-    except Exception as e:
+    except Exception:  # pylint: disable=broad-exception-caught
         logger.warning(
-            "Failed to retrieve job details: %s. "
-            "The migration may still be in progress.",
-            str(e)
+            "Failed to retrieve job details. "
+            "The migration may still be in progress."
         )
         return None
 
 
 def execute_migration(cmd, subscription_id, protected_item_id,
-                     resource_group_name, vault_name, protected_item_name,
-                     turn_off_source_server):
+                      resource_group_name, vault_name, protected_item_name,
+                      turn_off_source_server):
     """
     Execute the complete migration workflow.
 
@@ -303,7 +302,7 @@ def execute_migration(cmd, subscription_id, protected_item_id,
                 job_details.get('id', 'Unknown')
             )
             return job_details
-        
+
         # Print success message if job details unavailable
         print(
             "Migration has been initiated successfully. "

src/migrate/azext_migrate/helpers/migration/start/_parse.py

@@ -12,6 +12,7 @@
 
 logger = get_logger(__name__)
 
+
 def parse_protected_item_id(protected_item_id):
     """
     Parse protected item ID to extract resource group, vault, and item name.

src/migrate/azext_migrate/helpers/migration/start/_validate.py

@@ -150,18 +150,22 @@ def validate_arc_resource_bridge(cmd, target_cluster_id, target_subscription):
 
         if not data or len(data) == 0:
             logger.warning(
-                "Could not verify Arc Resource Bridge status via Resource Graph query. "
-                f"Target cluster ID: '{target_cluster_id}'. "
-                "Continuing with migration - the cluster and Arc Resource Bridge will be validated during the migration process."
+                "Could not verify Arc Resource Bridge status via "
+                "Resource Graph query. Target cluster ID: '%s'. "
+                "Continuing with migration - the cluster and Arc Resource "
+                "Bridge will be validated during the migration process.",
+                target_cluster_id
             )
             # Don't fail the operation, just warn
             return
 
         bridge_status = data[0].get('statusOfTheBridge', '')
         if bridge_status.lower() not in ['running', 'online']:
             logger.warning(
-                f"Arc Resource Bridge status is '{bridge_status}'. "
-                "Continuing with migration - the status will be validated during the migration process."
+                "Arc Resource Bridge status is '%s'. "
+                "Continuing with migration - the status will be validated "
+                "during the migration process.",
+                bridge_status
             )
             # Don't fail the operation, just warn
             return
@@ -171,9 +175,9 @@ def validate_arc_resource_bridge(cmd, target_cluster_id, target_subscription):
             bridge_status
         )
 
-    except Exception as e:
+    except Exception:  # pylint: disable=broad-exception-caught
         logger.warning(
-            "Failed to validate Arc Resource Bridge: %s. Continuing with migration...",
-            str(e)
+            "Failed to validate Arc Resource Bridge. "
+            "Continuing with migration..."
         )
         # Don't fail the operation if Arc validation fails

src/migrate/azext_migrate/helpers/replication/get/_execute_get.py

@@ -54,7 +54,7 @@ def get_protected_item_by_id(cmd, protected_item_id):
         # Format and display the protected item
         formatted_item = _format_protected_item(protected_item)
         _print_protected_item_details(formatted_item)
-        
+
         return formatted_item
 
     except CLIError:
@@ -128,7 +128,7 @@ def get_protected_item_by_name(cmd, subscription_id, resource_group_name,
         # Format and display the protected item
         formatted_item = _format_protected_item(protected_item)
         _print_protected_item_details(formatted_item)
-        
+
         return formatted_item
 
     except CLIError:
@@ -152,7 +152,7 @@ def _format_protected_item(item):
     """
     properties = item.get('properties', {})
     custom_properties = properties.get('customProperties', {})
-    
+
     # Extract all properties
     formatted_item = {
         'id': item.get('id', 'N/A'),
@@ -189,33 +189,33 @@ def _print_protected_item_details(item):
     print("\n" + "=" * 120)
     print(f"Protected Item: {item.get('name', 'Unknown')}")
     print("=" * 120)
-    
+
     # Basic Information
     print("\n[ BASIC INFORMATION ]")
     print(f"  Name:                  {item.get('name', 'N/A')}")
     print(f"  Resource ID:           {item.get('id', 'N/A')}")
     print(f"  Type:                  {item.get('type', 'N/A')}")
     print(f"  Correlation ID:        {item.get('correlationId', 'N/A')}")
-    
+
     # Protection Status
     print("\n[ PROTECTION STATUS ]")
     print(f"  Protection State:      {item.get('protectionState', 'Unknown')}")
     print(f"  Description:           {item.get('protectionStateDescription', 'N/A')}")
     print(f"  Replication Health:    {item.get('replicationHealth', 'Unknown')}")
     print(f"  Resync Required:       {item.get('resynchronizationRequired', False)}")
-    
+
     # Policy and Extension
     print("\n[ CONFIGURATION ]")
     print(f"  Policy Name:           {item.get('policyName', 'N/A')}")
     print(f"  Replication Extension: {item.get('replicationExtensionName', 'N/A')}")
-    
+
     # Failover Information
     print("\n[ FAILOVER HISTORY ]")
     print(f"  Last Test Failover:        {item.get('lastSuccessfulTestFailoverTime', 'N/A')}")
     print(f"  Last Test Failover Status: {item.get('lastTestFailoverStatus', 'N/A')}")
     print(f"  Last Planned Failover:     {item.get('lastSuccessfulPlannedFailoverTime', 'N/A')}")
     print(f"  Last Unplanned Failover:   {item.get('lastSuccessfulUnplannedFailoverTime', 'N/A')}")
-    
+
     # Allowed Operations
     allowed_jobs = item.get('allowedJobs', [])
     print("\n[ ALLOWED OPERATIONS ]")
@@ -224,24 +224,24 @@ def _print_protected_item_details(item):
             print(f"  - {job}")
     else:
         print("  No operations currently allowed")
-    
+
     # Custom Properties (Machine Details)
     custom_props = item.get('customProperties', {})
     if custom_props:
         print("\n[ MACHINE DETAILS ]")
         instance_type = custom_props.get('instanceType', 'N/A')
         print(f"  Instance Type:         {instance_type}")
-        
+
         if instance_type != 'N/A':
             print(f"  Source Machine Name:   {custom_props.get('sourceMachineName', 'N/A')}")
             print(f"  Target VM Name:        {custom_props.get('targetVmName', 'N/A')}")
             print(f"  Target Resource Group: {custom_props.get('targetResourceGroupId', 'N/A')}")
             print(f"  Custom Location Region: {custom_props.get('customLocationRegion', 'N/A')}")
-            
+
             # Fabric specific properties
             fabric_specific = custom_props.get('fabricSpecificDetails', {})
             if fabric_specific:
-                print(f"\n  [ Fabric Specific Details ]")
+                print("\n  [ Fabric Specific Details ]")
                 for key, value in fabric_specific.items():
                     # Format key name for display
                     display_key = key.replace('_', ' ').title()
@@ -253,7 +253,7 @@ def _print_protected_item_details(item):
                         print(f"    {display_key}: {len(value)} item(s)")
                     else:
                         print(f"    {display_key}: {value}")
-    
+
     # Health Errors
     health_errors = item.get('healthErrors', [])
     if health_errors:
@@ -264,13 +264,13 @@ def _print_protected_item_details(item):
             severity = error.get('severity', 'Unknown')
             print(f"  {idx}. [{severity}] {error_code}")
             print(f"     {error_message}")
-            
+
             possible_causes = error.get('possibleCauses', 'N/A')
             if possible_causes and possible_causes != 'N/A':
                 print(f"     Possible Causes: {possible_causes}")
-            
+
             recommended_action = error.get('recommendedAction', 'N/A')
             if recommended_action and recommended_action != 'N/A':
                 print(f"     Recommended Action: {recommended_action}")
-    
+
     print("\n" + "=" * 120 + "\n")

src/migrate/azext_migrate/helpers/replication/init/_setup_extension.py

@@ -50,11 +50,11 @@ def get_or_check_existing_extension(cmd, extension_uri,
             .get('provisioningState')
         )
         custom_props = (replication_extension
-                       .get('properties', {})
-                       .get('customProperties', {}))
+                        .get('properties', {})
+                        .get('customProperties', {}))
         existing_storage_id = custom_props.get('storageAccountId')
         existing_instance_type = custom_props.get('instanceType')
-        
+
         # Get fabric IDs based on instance type
         if instance_type == AzLocalInstanceTypes.VMwareToAzLocal.value:
             existing_source_fabric = custom_props.get('vmwareFabricArmId')
@@ -88,17 +88,17 @@ def get_or_check_existing_extension(cmd, extension_uri,
         # If configuration doesn't match, we need to update it
         if existing_state == ProvisioningState.Succeeded.value and not config_matches:
             print(
-                f"Extension exists but configuration doesn't match. "
-                f"Will update it."
+                "Extension exists but configuration doesn't match. "
+                "Will update it."
             )
             if existing_storage_id != storage_account_id:
-                print(f"  - Storage account mismatch")
+                print("  - Storage account mismatch")
             if existing_instance_type != instance_type:
-                print(f"  - Instance type mismatch")
+                print("  - Instance type mismatch")
             if existing_source_fabric != source_fabric_id:
-                print(f"  - Source fabric mismatch")
+                print("  - Source fabric mismatch")
             if existing_target_fabric != target_fabric_id:
-                print(f"  - Target fabric mismatch")
+                print("  - Target fabric mismatch")
             return replication_extension, False, True  # Signal to update
 
         # If it's in a bad state, delete it
@@ -341,7 +341,7 @@ def setup_replication_extension(cmd, rg_uri, replication_vault_name,
     )
 
     # Get or check existing extension
-    (replication_extension, is_complete, 
+    (replication_extension, is_complete,
      needs_update) = get_or_check_existing_extension(
         cmd, extension_uri, replication_extension_name,
         storage_account_id, instance_type, source_fabric_id,