Skip to content

Commit 6b21b6e

Browse files
Test recordings updated for storagepool commands
1 parent 0180a60 commit 6b21b6e

File tree

8 files changed

+1037
-1519
lines changed

8 files changed

+1037
-1519
lines changed

src/pscloud/HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
Release History
44
===============
55

6+
1.0.0
7+
+++++
8+
* Stable release.
9+
610
1.0.0b1
711
++++++
812
* Initial release.

src/pscloud/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ The pscloud CLI has been recently improved for better usability and consistency:
88

99
### Enhanced Parameter Usability ###
1010
- **Simplified zone specification**: Use `--zone` or `-z` instead of `--availability-zone`
11-
- **Flattened network parameters**: Use `--subnet-id` and `--vnet-id` directly instead of complex `--vnet-injection` JSON objects
11+
- **Flattened network parameters**: Use `--subnet-name` and `--vnet-name` directly instead of complex `--vnet-injection` JSON objects
1212
- **Improved parameter names**: Consistent use of `--name` or `-n` across all commands
1313

1414
### Removed Unsupported Features ###
1515
- **Identity parameters removed**: `--system-assigned`, `--user-assigned`, and related identity options have been removed as they are not supported by the Pure Storage Cloud service
1616
- **Wait command removed**: `az pscloud pool wait` has been removed for consistency with other Azure CLI extensions
1717

1818
### Enhanced Validation ###
19-
- **Required parameters**: Key parameters like `--zone`, `--provisioned-bandwidth`, `--reservation-id`, `--subnet-id`, and `--vnet-id` are now properly validated as required
19+
- **Required parameters**: Key parameters like `--zone`, `--provisioned-bandwidth`, `--reservation-id`, `--subnet-name`, and `--vnet-name` are now properly validated as required
2020
- **Better examples**: All command examples now show realistic Azure resource IDs and cleaner syntax
2121

2222
## How to use ##
@@ -82,13 +82,13 @@ This resource represents a block storage array instance, delivered as a service,
8282
To create a Storage Pool, you need to have a virtual network with a delegated subnet to `PureStorage.Block` service.
8383

8484
```bash
85-
az pscloud pool create --resource-group {resource_group} --name {storage_pool_name} --location {location} --zone {availability_zone} --subnet-name {subnet_name} --vnet-name {vnet_name} --provisioned-bandwidth {bandwidth_mb_per_sec} --reservation-id {reservation_resource_id} --tags "{key:value}"
85+
az pscloud pool create --resource-group {resource_group} --storage-pool-name {storage_pool_name} --location {location} --zone {availability_zone} --subnet-name {subnet_resource_id} --vnet-name {vnet_resource_id} --provisioned-bandwidth {bandwidth_mb_per_sec} --reservation-id {reservation_resource_id} --tags "{key:value}"
8686
```
8787

8888
**Required Parameters:**
8989
- `--zone` or `-z`: Azure Availability Zone (1, 2, or 3)
90-
- `--subnet-name`: Name of the delegated subnet
91-
- `--vnet-name`: Name of the virtual network
90+
- `--subnet-name`: Full Azure resource ID of the delegated subnet
91+
- `--vnet-name`: Full Azure resource ID of the virtual network
9292
- `--provisioned-bandwidth`: Bandwidth in MB/s
9393
- `--reservation-id`: Azure resource ID of the Pure Storage Cloud reservation
9494

@@ -99,8 +99,8 @@ az pscloud pool create \
9999
--storage-pool-name myStoragePool \
100100
--location eastus \
101101
--zone 1 \
102-
--subnet-name mySubnet \
103-
--vnet-name myVnet \
102+
--subnet-name /subscriptions/12345678-1234-1234-1234-123456789abc/resourceGroups/myResourceGroup/providers/Microsoft.Network/virtualNetworks/myVnet/subnets/mySubnet \
103+
--vnet-name /subscriptions/12345678-1234-1234-1234-123456789abc/resourceGroups/myResourceGroup/providers/Microsoft.Network/virtualNetworks/myVnet \
104104
--provisioned-bandwidth 100 \
105105
--reservation-id /subscriptions/12345678-1234-1234-1234-123456789abc/providers/PureStorage.Block/reservations/myReservation
106106
```

src/pscloud/azext_pscloud/tests/latest/recordings/test_pscloud_storagepool_create.yaml

Lines changed: 442 additions & 1028 deletions
Large diffs are not rendered by default.

src/pscloud/azext_pscloud/tests/latest/recordings/test_pscloud_storagepool_delete.yaml

Lines changed: 313 additions & 273 deletions
Large diffs are not rendered by default.

src/pscloud/azext_pscloud/tests/latest/recordings/test_pscloud_storagepool_get.yaml

Lines changed: 198 additions & 52 deletions
Large diffs are not rendered by default.

src/pscloud/azext_pscloud/tests/latest/recordings/test_pscloud_storagepool_postAction.yaml

Lines changed: 16 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -13,27 +13,27 @@ interactions:
1313
Content-Length:
1414
- '0'
1515
ParameterSetName:
16-
- --resource-group --storage-pool-name
16+
- --resource-group -n
1717
User-Agent:
18-
- AZURECLI/2.76.0 azsdk-python-core/1.35.0 Python/3.12.11 (Linux-6.8.0-1030-azure-x86_64-with-glibc2.36)
18+
- AZURECLI/2.81.0 azsdk-python-core/1.35.0 Python/3.12.12 (Linux-6.8.0-1030-azure-x86_64-with-glibc2.41)
1919
method: POST
20-
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/aaa/providers/PureStorage.Block/storagePools/cliTestSPCUS/getHealthStatus?api-version=2024-11-01
20+
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/abc/providers/PureStorage.Block/storagePools/dhritijindal/getHealthStatus?api-version=2024-11-01
2121
response:
2222
body:
23-
string: '{"health":{"usedCapacityPercentage":0.0,"bandwidthUsage":{"current":0.0,"provisioned":1040187392.0,"max":2147483648.0},"iopsUsage":{"current":0.0,"provisioned":65384.0,"max":150000.0},"space":{"totalUsed":29437952,"unique":0,"snapshots":0,"shared":29437952},"dataReductionRatio":1.0,"estimatedMaxCapacity":0},"alerts":[]}'
23+
string: '{"health":{"usedCapacityPercentage":0.0,"bandwidthUsage":{"current":0.0,"provisioned":1040187392.0,"max":2147483648.0},"iopsUsage":{"current":0.0,"provisioned":65384.0,"max":150000.0},"space":{"totalUsed":0,"unique":0,"snapshots":0,"shared":0},"dataReductionRatio":1.0,"estimatedMaxCapacity":0},"alerts":[]}'
2424
headers:
2525
cache-control:
2626
- no-cache
2727
content-length:
28-
- '321'
28+
- '307'
2929
content-type:
3030
- application/json; charset=utf-8
3131
date:
32-
- Mon, 11 Aug 2025 07:34:41 GMT
32+
- Mon, 22 Dec 2025 07:53:15 GMT
3333
expires:
3434
- '-1'
3535
mise-correlation-id:
36-
- 2a117433-4a2e-4fda-b192-bbe9467851ae
36+
- feaacef2-ce40-4759-8af5-f4ffde4f946e
3737
pragma:
3838
- no-cache
3939
strict-transport-security:
@@ -43,15 +43,15 @@ interactions:
4343
x-content-type-options:
4444
- nosniff
4545
x-ms-operation-identifier:
46-
- appId=91a99062-ab22-4fd2-a3b2-766d55d6f5c5,tenantId=888d76fa-54b2-4ced-8ee5-aac1585adee7,objectId=d72e9d00-2ae6-4216-9c0f-ef425c71a2bc/southindia/2861fa0e-f0fa-48a6-9f54-a98b52d8f734
46+
- appId=91a99062-ab22-4fd2-a3b2-766d55d6f5c5,tenantId=888d76fa-54b2-4ced-8ee5-aac1585adee7,objectId=d72e9d00-2ae6-4216-9c0f-ef425c71a2bc/centraluseuap/bccf2175-7f8e-4c43-93a1-a3049deb8af0
4747
x-ms-providerhub-traffic:
4848
- 'True'
4949
x-ms-ratelimit-remaining-subscription-global-writes:
5050
- '2999'
5151
x-ms-ratelimit-remaining-subscription-writes:
5252
- '199'
5353
x-msedge-ref:
54-
- 'Ref A: CB4F23C0F21744B28145478F3733ADB9 Ref B: PNQ231110909052 Ref C: 2025-08-11T07:34:37Z'
54+
- 'Ref A: 7C8A9928972F405688AD84C687619427 Ref B: PNQ231110909052 Ref C: 2025-12-22T07:53:12Z'
5555
status:
5656
code: 200
5757
message: OK
@@ -69,11 +69,11 @@ interactions:
6969
Content-Length:
7070
- '0'
7171
ParameterSetName:
72-
- --resource-group --storage-pool-name
72+
- --resource-group -n
7373
User-Agent:
74-
- AZURECLI/2.76.0 azsdk-python-core/1.35.0 Python/3.12.11 (Linux-6.8.0-1030-azure-x86_64-with-glibc2.36)
74+
- AZURECLI/2.81.0 azsdk-python-core/1.35.0 Python/3.12.12 (Linux-6.8.0-1030-azure-x86_64-with-glibc2.41)
7575
method: POST
76-
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/aaa/providers/PureStorage.Block/storagePools/cliTestSPCUS/getAvsStatus?api-version=2024-11-01
76+
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/abc/providers/PureStorage.Block/storagePools/dhritijindal/getAvsStatus?api-version=2024-11-01
7777
response:
7878
body:
7979
string: '{"avsEnabled":false,"currentConnectionStatus":"NoAVS","sddcResourceId":""}'
@@ -85,11 +85,11 @@ interactions:
8585
content-type:
8686
- application/json; charset=utf-8
8787
date:
88-
- Mon, 11 Aug 2025 07:34:43 GMT
88+
- Mon, 22 Dec 2025 07:53:18 GMT
8989
expires:
9090
- '-1'
9191
mise-correlation-id:
92-
- e9241dc7-2bf4-4e10-93cd-c13e96631923
92+
- 7877c089-8492-4531-ac5f-2105d66df64e
9393
pragma:
9494
- no-cache
9595
strict-transport-security:
@@ -99,62 +99,16 @@ interactions:
9999
x-content-type-options:
100100
- nosniff
101101
x-ms-operation-identifier:
102-
- appId=91a99062-ab22-4fd2-a3b2-766d55d6f5c5,tenantId=888d76fa-54b2-4ced-8ee5-aac1585adee7,objectId=d72e9d00-2ae6-4216-9c0f-ef425c71a2bc/centralindia/40a1ebc2-5671-46dc-8c0e-cfbf21bf5e31
102+
- appId=91a99062-ab22-4fd2-a3b2-766d55d6f5c5,tenantId=888d76fa-54b2-4ced-8ee5-aac1585adee7,objectId=d72e9d00-2ae6-4216-9c0f-ef425c71a2bc/centraluseuap/c4945a41-2f91-44d2-9060-574c1cde22d7
103103
x-ms-providerhub-traffic:
104104
- 'True'
105105
x-ms-ratelimit-remaining-subscription-global-writes:
106106
- '2999'
107107
x-ms-ratelimit-remaining-subscription-writes:
108108
- '199'
109109
x-msedge-ref:
110-
- 'Ref A: 8C28F9A2EDA242C8ACB95921D3A3898C Ref B: PNQ231110906025 Ref C: 2025-08-11T07:34:42Z'
110+
- 'Ref A: F2747DB4591F40ED892B83877786C973 Ref B: PNQ231110909031 Ref C: 2025-12-22T07:53:15Z'
111111
status:
112112
code: 200
113113
message: OK
114-
- request:
115-
body: null
116-
headers:
117-
Accept:
118-
- '*/*'
119-
Accept-Encoding:
120-
- gzip, deflate
121-
CommandName:
122-
- pscloud pool delete
123-
Connection:
124-
- keep-alive
125-
Content-Length:
126-
- '0'
127-
ParameterSetName:
128-
- --resource-group --storage-pool-name --yes
129-
User-Agent:
130-
- AZURECLI/2.76.0 azsdk-python-core/1.35.0 Python/3.12.11 (Linux-6.8.0-1030-azure-x86_64-with-glibc2.36)
131-
method: DELETE
132-
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/S1RG1/providers/PureStorage.Block/storagePools/cliTestStoragePool8?api-version=2024-11-01
133-
response:
134-
body:
135-
string: ''
136-
headers:
137-
cache-control:
138-
- no-cache
139-
date:
140-
- Mon, 11 Aug 2025 07:34:44 GMT
141-
expires:
142-
- '-1'
143-
pragma:
144-
- no-cache
145-
strict-transport-security:
146-
- max-age=31536000; includeSubDomains
147-
x-cache:
148-
- CONFIG_NOCACHE
149-
x-content-type-options:
150-
- nosniff
151-
x-ms-ratelimit-remaining-subscription-deletes:
152-
- '199'
153-
x-ms-ratelimit-remaining-subscription-global-deletes:
154-
- '2999'
155-
x-msedge-ref:
156-
- 'Ref A: 6E0C7FFAD97742BEB711FA8D5BF1F2F6 Ref B: PNQ231110909040 Ref C: 2025-08-11T07:34:44Z'
157-
status:
158-
code: 204
159-
message: No Content
160114
version: 1

0 commit comments

Comments
 (0)