fix tests

Author: Lily Pan

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

@@ -5332,18 +5332,14 @@ def update_vmas_to_vms(self, mc: ManagedCluster) -> ManagedCluster:
 
         return mc
 
-    def update_http_proxy_config(self, mc: ManagedCluster) -> ManagedCluster:
+    def update_http_proxy_enabled(self, mc: ManagedCluster) -> ManagedCluster:
         """Update http proxy config for the ManagedCluster object.
 
         :return: the ManagedCluster object
         """
         self._ensure_mc(mc)
 
         if self.context.get_disable_http_proxy():
-            if not mc.http_proxy_config:
-                raise UnknownError(
-                    "Unexpectedly get an empty http proxy config in the process of disabling http proxy."
-                )
             if mc.http_proxy_config is None:
                 mc.http_proxy_config = (
                     self.models.ManagedClusterHTTPProxyConfig()  # pylint: disable=no-member
@@ -5428,7 +5424,7 @@ def update_mc_profile_preview(self) -> ManagedCluster:
         # update VMAS to VMS
         mc = self.update_vmas_to_vms(mc)
         # update http proxy config
-        mc = self.update_http_proxy_config(mc)
+        mc = self.update_http_proxy_enabled(mc)
 
         return mc
 

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

@@ -6141,7 +6141,7 @@ def test_aks_create_and_update_with_http_proxy_config(
         self.cmd(
             disable_cmd,
             checks=[
-                self.check("httpProxyConfig.enabled", "false"),
+                self.check("httpProxyConfig.enabled", False),
             ],
         )
 

src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py

@@ -6503,7 +6503,6 @@ def test_update_http_proxy_config(self):
         ground_truth_mc_1 = self.models.ManagedCluster(
             location="test_location",
             http_proxy_config={
-                "enabled": "True",
                 "httpProxy": "http://cli-proxy-vm:3128/",
                 "httpsProxy": "https://cli-proxy-vm:3129/",
                 "noProxy": ["localhost", "127.0.0.1"],
@@ -6512,7 +6511,7 @@ def test_update_http_proxy_config(self):
         )
         self.assertEqual(dec_mc_1, ground_truth_mc_1)
 
-                # custom value
+        # custom value
         dec_2 = AKSPreviewManagedClusterUpdateDecorator(
             self.cmd,
             self.client,
@@ -6526,13 +6525,13 @@ def test_update_http_proxy_config(self):
         dec_2.context.attach_mc(mc_2)
         # fail on passing the wrong mc object
         with self.assertRaises(CLIInternalError):
-            dec_2.update_http_proxy_config(None)
-        dec_mc_2 = dec_2.update_http_proxy_config(mc_2)
+            dec_2.update_http_proxy_enabled(None)
+        dec_mc_2 = dec_2.update_http_proxy_enabled(mc_2)
 
         ground_truth_mc_2 = self.models.ManagedCluster(
             location="test_location",
             http_proxy_config={
-                "enabled": "False",
+                "enabled": False,
                 "httpProxy": "http://cli-proxy-vm:3128/",
                 "httpsProxy": "https://cli-proxy-vm:3129/",
                 "noProxy": ["localhost", "127.0.0.1"],