Skip to content

Commit 883ea8f

Browse files
authored
Support clear config file pattern with empty string (#8717)
1 parent 2f8b566 commit 883ea8f

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

src/spring/HISTORY.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
Release History
22
===============
3+
1.28.1
4+
---
5+
* Fix clean up config file patterns of Application Configuration Service.
6+
37
1.28.0
48
---
59
* Add Azure Spring Apps retirement information. See https://aka.ms/asaretirement.

src/spring/azext_spring/_deployment_factory.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,10 @@ def _get_apms(self, apms=None, **_):
109109
return apms
110110

111111
def _get_addon_configs(self, config_file_patterns=None, custom_actuator_port=None, custom_actuator_path=None, **_):
112-
if not any([config_file_patterns, custom_actuator_port, custom_actuator_path]):
112+
if config_file_patterns is None and custom_actuator_port is None and custom_actuator_path is None:
113113
return None
114114
addon_configs = {}
115-
if config_file_patterns:
115+
if config_file_patterns is not None:
116116
addon_configs[APPLICATION_CONFIGURATION_SERVICE_NAME] = {
117117
APPLICATION_CONFIGURATION_SERVICE_PROPERTY_PATTERN: config_file_patterns
118118
}

src/spring/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
# TODO: Confirm this is the right version number you want and it matches your
1818
# HISTORY.rst entry.
19-
VERSION = '1.28.0'
19+
VERSION = '1.28.1'
2020

2121
# The full list of classifiers is available at
2222
# https://pypi.python.org/pypi?%3Aaction=list_classifiers

0 commit comments

Comments
 (0)