Skip to content

Commit 961d512

Browse files
fix: acns-datapath-acceleration-mode None should set the API field correctly (#9255)
1 parent f484717 commit 961d512

File tree

5 files changed

+415
-373
lines changed

5 files changed

+415
-373
lines changed

src/aks-preview/HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,12 @@ To release a new version, please select a new version number (usually plus 1 to
1111

1212
Pending
1313
+++++++
14+
15+
18.0.0b41
16+
+++++++
1417
* Fix `--localdns-config` parameter to handle null values in JSON configuration files gracefully, preventing crashes when DNS override sections are null.
1518
* Add jwtauthenticator commands `az aks jwtauthenticator add/update/show/list/delete` to manage JWT authenticators for a managed cluster.
19+
* Fix an issue in disabling ACNS performance (--acns-datapath-acceleration-mode None).
1620

1721
18.0.0b40
1822
+++++++

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3180,7 +3180,7 @@ def set_up_network_profile(self, mc: ManagedCluster) -> ManagedCluster:
31803180
if acns.security.transit_encryption is None:
31813181
acns.security.transit_encryption = self.models.AdvancedNetworkingSecurityTransitEncryption()
31823182
acns.security.transit_encryption.type = acns_transit_encryption_type
3183-
if acns_datapath_acceleration_mode == CONST_ACNS_DATAPATH_ACCELERATION_MODE_BPFVETH:
3183+
if acns_datapath_acceleration_mode is not None:
31843184
if acns.performance is None:
31853185
acns.performance = self.models.AdvancedNetworkingPerformance()
31863186
acns.performance.acceleration_mode = acns_datapath_acceleration_mode
@@ -4434,7 +4434,7 @@ def update_acns_in_network_profile(self, mc: ManagedCluster) -> ManagedCluster:
44344434
if acns.security.transit_encryption is None:
44354435
acns.security.transit_encryption = self.models.AdvancedNetworkingSecurityTransitEncryption()
44364436
acns.security.transit_encryption.type = acns_transit_encryption_type
4437-
if acns_datapath_acceleration_mode == CONST_ACNS_DATAPATH_ACCELERATION_MODE_BPFVETH:
4437+
if acns_datapath_acceleration_mode is not None:
44384438
if acns.performance is None:
44394439
acns.performance = self.models.AdvancedNetworkingPerformance()
44404440
acns.performance.acceleration_mode = acns_datapath_acceleration_mode

0 commit comments

Comments
 (0)