Linter ai

Author: hasani-h

src/arcdata/arcdata/azext_arcdata/core/exceptions.py

@@ -5,10 +5,7 @@
 # ------------------------------------------------------------------------------
 
 from knack.cli import CLIError
-from requests.exceptions import HTTPError
 
 
 class ClusterLogError(CLIError):
     """All errors related to log collection calls."""
-
-    pass

src/arcdata/arcdata/azext_arcdata/core/http_codes.py

@@ -7,7 +7,7 @@
 __all__ = ["HTTPCodes"]
 
 
-class HTTPCodes(object):
+class HTTPCodes:
     """
     Defines the HTTP status codes.
     NOTE: Add more when needed.

src/arcdata/arcdata/azext_arcdata/core/identity.py

@@ -5,6 +5,7 @@
 # ------------------------------------------------------------------------------
 
 from knack.log import get_logger
+from typing import Any, Optional
 
 import os
 import abc
@@ -32,19 +33,19 @@ def __init__(self, *args, **kwargs):
 
     @abc.abstractmethod
     def acquire_token(self, *scopes, **kwargs):
-        # type: (*str, **Any) -> Optional[AccessToken]
+        # type: (*str, **Any) -> Optional[Any]
         """
         Attempt to acquire an access token from a cache or by redeeming a
         refresh token
         """
 
     @abc.abstractmethod
     def request_token(self, *scopes, **kwargs):
-        # type: (*str, **Any) -> AccessToken
+        # type: (*str, **Any) -> Any
         """Request an access token"""
 
     def should_refresh(self, token):
-        # type: (AccessToken) -> bool
+        # type: (Any) -> bool
         now = int(time.time())
         if token.expires_on - now > BaseTokenMixin.DEFAULT_REFRESH_OFFSET:
             return False
@@ -56,7 +57,7 @@ def should_refresh(self, token):
         return True
 
     def get_token(self, *scopes, **kwargs):
-        # type: (*str, **Any) -> AccessToken
+        # type: (*str, **Any) -> Any
         """
         Request an access token for `scopes`.
 
@@ -89,7 +90,7 @@ def __init__(self, scopes=None):
 
     # override
     def get_token(self, *scopes, **kwargs):
-        # type: (*str, **Any) -> AccessToken
+        # type: (*str, **Any) -> Any
         """
         Request an access token for `scopes`.
         """
@@ -113,7 +114,7 @@ def get_token(self, *scopes, **kwargs):
 
     # override
     def acquire_token(self, *scopes):
-        # type: (*str) -> Optional[AccessToken]
+        # type: (*str) -> Optional[Any]
         """
         Attempt to acquire an access token from a cache or by redeeming
         a refresh token.
@@ -125,16 +126,13 @@ def acquire_token(self, *scopes):
         azure_folder = get_config_dir()
         ACCOUNT.load(os.path.join(azure_folder, "azureProfile.json"))
         p = Profile(storage=ACCOUNT)
-        cred, subscription_id, tenant_id = p.get_login_credentials()
+        cred, _, _ = p.get_login_credentials()
         scopes = ["https://management.azure.com/.default"]
         access_token = cred.get_token(*scopes)
 
         return access_token
 
     # override
     def request_token(self, *scopes, **kwargs):
-        # TODO: Impl refresh logic if possible. For now we give error
-        # to az login again
-        return super(ArcDataCliCredential, self).request_token(
-            *scopes, **kwargs
-        )
+        # TODO: Implement refresh logic if possible. For now, raise an error to prompt az login again.
+        raise NotImplementedError("Token refresh logic not implemented. Please run 'az login' again.")

src/arcdata/arcdata/azext_arcdata/core/labels.py

@@ -21,9 +21,8 @@ def parse_labels(label_str):
 
         label_key, label_value = label_kv
 
-        if label_key in labels.keys():
+        if label_key in labels:
             raise ValueError("Duplicate label key {}".format(label_key))
-
         labels[label_key.strip()] = label_value.strip()
 
     return labels

src/arcdata/arcdata/azext_arcdata/core/layout.py

@@ -15,7 +15,7 @@
 
 
 @add_metaclass(ABCMeta)
-class BaseLayout(object):
+class BaseLayout:
     def __init__(self):
         pass
 
@@ -311,13 +311,13 @@ def stack(data, boxes, parent="", name="", trail="", identifiers=None):
     def __repr__(self):
         return self.render()
 
-
+        class BaseLayout:
 # ---------------------------------------------------------------------------- #
 # ---------------------------------------------------------------------------- #
 # ---------------------------------------------------------------------------- #
 
 
-class Box(object):
+class Box:
     def __init__(self, data):
         self._data = data
         self._identifiers = (
@@ -351,10 +351,11 @@ def render(self):
 
 
 def print_formatted_text(text, end="\n"):
-    from prompt_toolkit import print_formatted_text as pft
-
     try:
+        from prompt_toolkit import print_formatted_text as pft
         pft(text, end=end)
+    except ImportError:
+        print(text, end=end)
     except Exception:
         print(text, end=end)
 
@@ -371,23 +372,22 @@ def indention(depth):
 
 def badge(text, depth=0, end="", identifiers=None):
     def background(label, color):
-        from prompt_toolkit import print_formatted_text as pft, ANSI
-
         try:
+            from prompt_toolkit import print_formatted_text as pft, ANSI
             style = {"green": 102, "red": 101}[color]
             pft(
                 ANSI(
                     "\x1b[97;{style}m{label}".format(style=style, label=label)
                 ),
                 end="",
             )
-        except Exception:
-            # shim fall back for cygwin/git-bash/ect...
+        except ImportError:
             from colorama import init, Back
-
             init(strip=False)
             style = {"green": Back.GREEN, "red": Back.RED}[color]
             print("{}{}".format(style, label) + Back.RESET, end="")
+        except Exception:
+            print(label)
 
     margin_left = "".ljust(indention(depth))
 

src/arcdata/arcdata/azext_arcdata/core/output.py

@@ -19,7 +19,7 @@
 
 
 @singleton
-class OutputStream(object):
+class OutputStream:
     __ORIGINAL_STDOUT__ = sys.stdout
     """
     Placeholder for the original system stdout.

src/arcdata/arcdata/azext_arcdata/core/serialization.py

@@ -29,13 +29,13 @@ def sanitize_value(self, property_path, value):
             return value
 
 
-class Sanitizer(object):
+class Sanitizer:
     """
     Object sanitizer allowing for properties to be excluded based on
     configurable filters
     """
 
-    def __init__(self, filters: List[SanitizerRule] = [], *args, **kwargs):
+    def __init__(self, filters: List[SanitizerRule] = None, *args, **kwargs):
         """
         Initializer with additional parameters for managing serialized content
 
@@ -46,7 +46,7 @@ def __init__(self, filters: List[SanitizerRule] = [], *args, **kwargs):
         """
         super().__init__(*args, **kwargs)
         self._serializedInstances = []
-        self._filters = filters
+        self._filters = filters if filters is not None else []
 
     def sanitize_value(self, property_path, property_value):
         for f in self._filters:
@@ -99,12 +99,12 @@ def sanitize(self, obj, path=""):
             return self.sanitize_value(path, obj)
 
     @staticmethod
-    def sanitize_object(obj, filters: List[SanitizerRule] = []):
+    def sanitize_object(obj, filters: List[SanitizerRule] = None):
         """
         Convenience method allowing for an object and filters to be passed in.
         The results will be the sanitized object
         """
-        sanitizer = Sanitizer(filters)
+        sanitizer = Sanitizer(filters if filters is not None else [])
         return sanitizer.sanitize(obj)
 
     @staticmethod

src/arcdata/arcdata/azext_arcdata/core/services.py

@@ -75,7 +75,7 @@ def beget_service(az_cli):
 
 
 @add_metaclass(ABCMeta)
-class BaseServiceProxy(object):
+class BaseServiceProxy:
     def __init__(self, name):
         self._name = name
 
@@ -110,6 +110,7 @@ def get_crd_dict():
         }
 
     @staticmethod
+
     def get_spec_file_dict():
         import azext_arcdata.vendored_sdks.kubernetes_sdk.dc.constants as dc_constants
 
@@ -228,7 +229,7 @@ def get_config(self, command_value_object: tuple):
 
 
 @add_metaclass(ABCMeta)
-class ArmMixin(object):
+class ArmMixin:
     @staticmethod
     def get_azure_credentials(az_cli):
         from azure.common.credentials import get_cli_profile
@@ -277,7 +278,7 @@ def acquire_arm_client(az_cli):
 
 
 @add_metaclass(ABCMeta)
-class KubernetesMixin(object):
+class KubernetesMixin:
     def __init__(self):
         self.apply_context()
 

src/arcdata/arcdata/azext_arcdata/core/util.py

@@ -21,6 +21,7 @@
 )
 from knack.log import get_logger
 from knack.cli import CLIError
+
 from kubernetes import config as kconfig
 from kubernetes.config.config_exception import ConfigException
 from jsonpatch import JsonPatch

src/arcdata/arcdata/azext_arcdata/sqlmi/custom.py

@@ -607,22 +607,15 @@ def arc_sql_mi_edit(
     license_type=None,
     tier=None,
     nowait=False,
-    dev=None,
     labels=None,
     annotations=None,
     service_labels=None,
     service_annotations=None,
     agent_enabled=None,
     trace_flags=None,
-    time_zone=None,
     use_k8s=None,
     retention_days=None,
-    # -- direct --
     resource_group=None,
-    location=None,
-    custom_location=None,
-    tag_name=None,
-    tag_value=None,
 ):
     """
     Deprecated, use update over edit.
@@ -632,7 +625,6 @@ def arc_sql_mi_edit(
             client,
             name,
             path=path,
-            time_zone=time_zone,
             cores_limit=cores_limit,
             cores_request=cores_request,
             memory_limit=memory_limit,
@@ -675,7 +667,6 @@ def arc_sql_mi_update(
     readable_secondaries=None,
     sync_secondary_to_commit=None,
     path=None,
-    time_zone=None,
     cores_limit=None,
     cores_request=None,
     memory_limit=None,
@@ -694,15 +685,11 @@ def arc_sql_mi_update(
     certificate_private_key_file=None,
     service_certificate_secret=None,
     preferred_primary_replica=None,
-    # -- indirect --
     use_k8s=None,
     namespace=None,
-    # -- direct --
     resource_group=None,
-    # -- Active Directory --
     keytab_secret=None,
     ad_encryption_types=None,
-    # -- Transparent Data Encryption --
     tde_mode=None,
     tde_protector_secret=None,
     tde_protector_public_key_file=None,