Add invalid test case

Author: Harshan01

src/load/azext_load/data_plane/utils/validators.py

@@ -486,7 +486,8 @@ def validate_autostop_maximum_virtual_users_per_engine(namespace):
 def _validate_autostop_disable_configfile(autostop):
     if autostop.casefold() not in ["disable"]:
         raise InvalidArgumentValueError(
-            "Invalid value for autoStop. Valid values are 'disable' or an object with errorPercentage and timeWindow"
+            "Invalid value for autoStop. Valid values are 'disable' or an object with errorPercentage, timeWindow "
+            "and/or maximumVirtualUsersPerEngine"
         )
 
 

src/load/azext_load/tests/latest/constants.py

@@ -132,6 +132,9 @@ class LoadConstants:
     LOAD_TEST_CONFIG_FILE_WITH_INVALID_AUTOSTOP_TIME_WINDOW = os.path.join(
         TEST_RESOURCES_DIR, r"config-invalid-autostop-criteria-time-window.yaml"
     )
+    LOAD_TEST_CONFIG_FILE_WITH_INVALID_AUTOSTOP_MAX_VU_PER_ENGINE = os.path.join(
+        TEST_RESOURCES_DIR, r"config-invalid-autostop-criteria-max-vu-per-engine.yaml"
+    )
     LOAD_TEST_CONFIG_FILE_WITH_INVALID_AUTOSTOP = os.path.join(
         TEST_RESOURCES_DIR, r"config-invalid-autostop-criteria-random-string.yaml"
     )

src/load/azext_load/tests/latest/resources/config-invalid-autostop-criteria-max-vu-per-engine.yaml

@@ -0,0 +1,21 @@
+# Invalid autoStop criteria: timeWindow is negative
+displayName: CLI-Test
+testPlan: sample-JMX-file.jmx
+description: 'Test created from az load test command'
+engineInstances: 1
+configurationFiles:
+  - additional-data.csv
+zipArtifacts:
+   - sample-ZIP-artifact.zip
+failureCriteria:
+  - avg(requests_per_sec) > 78
+  - percentage(error) > 50
+  - GetCustomerDetails: avg(latency) > 200
+env:
+  - name: 'rps'
+    value: 1
+splitAllCSVs: True
+autoStop:
+  errorPercentage: 87.5
+  timeWindow: 5
+  maximumVirtualUsersPerEngine: 0

src/load/azext_load/tests/latest/test_load_autostop_criteria.py

@@ -196,6 +196,20 @@ def test_load_test_autostop(self):
             autostop_error_rate_time_window=-1,
         )
 
+        # Invalid autostop test case: autostop maximum VU per engine = 0
+        _configure_command_assert_exception(
+            self,
+            "Autostop maximum users per engine should be greater than 0",
+            autostop_maximum_vu_per_engine=0,
+        )
+
+        # Invalid autostop test case: autostop maximum VU per engine < 0
+        _configure_command_assert_exception(
+            self,
+            "Autostop maximum users per engine should be greater than 0",
+            autostop_maximum_vu_per_engine=0,
+        )
+
         # Invalid autostop test case: autostop error rate time window not of integer type
         # This is not needed as the argument is type checked
         # argument --autostop-time-window: invalid int value: '90.4'
@@ -204,7 +218,7 @@ def test_load_test_autostop(self):
         # Invalid autostop from config test case: autostop random string
         _configure_command_assert_exception(
             self,
-            "Invalid value for autoStop. Valid values are 'disable' or an object with errorPercentage and timeWindow",
+            "Invalid value for autoStop. Valid values are 'disable' or an object with errorPercentage, timeWindow and/or maximumVirtualUsersPerEngine",
             load_test_config_file=LoadTestConstants.LOAD_TEST_CONFIG_FILE_WITH_INVALID_AUTOSTOP,
         )
 
@@ -222,13 +236,21 @@ def test_load_test_autostop(self):
             load_test_config_file=LoadTestConstants.LOAD_TEST_CONFIG_FILE_WITH_INVALID_AUTOSTOP_TIME_WINDOW,
         )
 
+        # Invalid autostop from config test case: autostop time window < 0
+        _configure_command_assert_exception(
+            self,
+            "Invalid value for maximumVirtualUserPerEngine. Value should be an integer greater than 0",
+            load_test_config_file=LoadTestConstants.LOAD_TEST_CONFIG_FILE_WITH_INVALID_AUTOSTOP_MAX_VU_PER_ENGINE,
+        )
+
 
 def _configure_command_jmes_checks(
     self,
     checks,
     autostop=None,
     autostop_error_rate=None,
     autostop_error_rate_time_window=None,
+    autostop_maximum_vu_per_engine=None,
     load_test_config_file=None,
 ):
     command = (
@@ -258,6 +280,13 @@ def _configure_command_jmes_checks(
             }
         )
         command += "--autostop-time-window {autostop_error_rate_time_window} "
+    if autostop_maximum_vu_per_engine is not None:
+        self.kwargs.update(
+            {
+                "autostop_maximum_vu_per_engine": autostop_maximum_vu_per_engine,
+            }
+        )
+        command += "--autostop-engine-users {autostop_maximum_vu_per_engine} "
     if load_test_config_file is not None:
         self.kwargs.update(
             {
@@ -277,6 +306,7 @@ def _configure_command_assert_exception(
     autostop=None,
     autostop_error_rate=None,
     autostop_error_rate_time_window=None,
+    autostop_maximum_vu_per_engine=None,
     load_test_config_file=None,
 ):
     command = (
@@ -306,6 +336,13 @@ def _configure_command_assert_exception(
             }
         )
         command += "--autostop-time-window {autostop_error_rate_time_window} "
+    if autostop_maximum_vu_per_engine is not None:
+        self.kwargs.update(
+            {
+                "autostop_maximum_vu_per_engine": autostop_maximum_vu_per_engine,
+            }
+        )
+        command += "--autostop-engine-users {autostop_maximum_vu_per_engine} "
     if load_test_config_file is not None:
         self.kwargs.update(
             {