Skip to content

Commit a3f7316

Browse files
fix 'az aks nodepool upgrade' cannot set 'node-soak-duration' to 0 (#8443)
1 parent 48772cc commit a3f7316

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

src/aks-preview/HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ If there is no rush to release a new version, please just add a description of t
99

1010
To release a new version, please select a new version number (usually plus 1 to last patch version, X.Y.Z -> Major.Minor.Patch, more details in `\doc <https://semver.org/>`_), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` variable in `setup.py` with this new version number.
1111

12+
13.0.0b4
13+
+++++++
14+
* `az aks nodepool upgrade`: Fix `--node-soak-duration` cannot be specified as 0
15+
1216
13.0.0b3
1317
+++++++
1418
* `az aks create`: Update outbound type selection logic for automatic cluster when customer brings BYO Vnet.

src/aks-preview/azext_aks_preview/custom.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1433,7 +1433,7 @@ def aks_agentpool_upgrade(cmd,
14331433
instance.upgrade_settings.max_surge = max_surge
14341434
if drain_timeout:
14351435
instance.upgrade_settings.drain_timeout_in_minutes = drain_timeout
1436-
if node_soak_duration:
1436+
if isinstance(node_soak_duration, int) and node_soak_duration >= 0:
14371437
instance.upgrade_settings.node_soak_duration_in_minutes = node_soak_duration
14381438
if undrainable_node_behavior:
14391439
instance.upgrade_settings.undrainable_node_behavior = undrainable_node_behavior

src/aks-preview/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
from setuptools import setup, find_packages
1111

12-
VERSION = "13.0.0b3"
12+
VERSION = "13.0.0b4"
1313

1414
CLASSIFIERS = [
1515
"Development Status :: 4 - Beta",

0 commit comments

Comments
 (0)