Skip to content

Commit ac6f7be

Browse files
author
Lauren Kam
committed
Resolving comments
1 parent 2148f96 commit ac6f7be

20 files changed

+3734
-3636
lines changed

‎src/databricks/HISTORY.rst‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Release History
44
===============
55

6-
1.2.0b1
6+
1.2.0
77
+++++
88
* az databricks workspace create: Add --compute-mode to set the compute mode for the workspace. Allowed values: 'Hybrid', 'Serverless'
99
* az databricks workspace create/update: Support additional ESC values

‎src/databricks/azext_databricks/aaz/latest/databricks/workspace/_create.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
208208
_args_schema.compliance_standards = AAZListArg(
209209
options=["--compliance-standards"],
210210
arg_group="Enhanced Security Compliance",
211-
help="Compliance Standards associated with the workspace, allowed values: NONE, HIPAA, PCI_DSS, CYBER_ESSENTIAL_PLUS, FEDRAMP_HIGH, CANADA_PROTECTED_B, IRAP_PROTECTED, ISMAP, HITRUST, K_FSI, GERMANY_C5, GERMANY_TISAX.",
211+
help="Compliance Standards associated with the workspace, allowed values referenced here: https://learn.microsoft.com/en-us/azure/databricks/security/privacy/security-profile.",
212212
nullable=True,
213213
)
214214
_args_schema.compliance_standards.Element = AAZStrArg(
@@ -480,9 +480,7 @@ def content(self):
480480
properties.set_prop("enhancedSecurityCompliance", AAZObjectType, ".enhanced_security_compliance")
481481
# Only add managedResourceGroupId if specified
482482
managed_resource_group_id = getattr(self.ctx.args, 'managed_resource_group', None)
483-
print("here")
484483
if managed_resource_group_id is not None:
485-
print(managed_resource_group_id)
486484
properties.set_prop("managedResourceGroupId", AAZStrType, ".managed_resource_group")
487485
properties.set_prop("parameters", AAZObjectType)
488486
properties.set_prop("publicNetworkAccess", AAZStrType, ".public_network_access")

‎src/databricks/azext_databricks/aaz/latest/databricks/workspace/_update.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
246246
_args_schema.compliance_standards = AAZListArg(
247247
options=["--compliance-standards"],
248248
arg_group="Enhanced Security Compliance",
249-
help="Compliance Standards associated with the workspace, allowed values: NONE, HIPAA, PCI_DSS, CYBER_ESSENTIAL_PLUS, FEDRAMP_HIGH, CANADA_PROTECTED_B, IRAP_PROTECTED, ISMAP, HITRUST, K_FSI, GERMANY_C5, GERMANY_TISAX.",
249+
help="Compliance Standards associated with the workspace, allowed values listed here: https://learn.microsoft.com/en-us/azure/databricks/security/privacy/security-profile.",
250250
nullable=True,
251251
)
252252
_args_schema.compliance_standards.Element = AAZStrArg(

‎src/databricks/azext_databricks/custom.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def pre_operations(self):
4848
subscription=subscription_id,
4949
resource_group=managed_resource_group)
5050

51-
if (not has_value(args.managed_resource_group)) and (not has_value(args.compute_mode) or args.compute_mode != 'Serverless'):
51+
if (not has_value(args.managed_resource_group)) and (not has_value(args.compute_mode) or args.compute_mode.to_serialized_data() != 'Serverless'):
5252
args.managed_resource_group = resource_id(
5353
subscription=subscription_id,
5454
resource_group='databricks-rg-' + workspace_name + '-' + id_generator())

‎src/databricks/azext_databricks/tests/latest/recordings/test_access_connector.yaml‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ interactions:
2424
body:
2525
string: "{\r\n \"id\": \"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_access_connector000001/providers/Microsoft.Databricks/accessConnectors/my-test-access-connector\",\r\n
2626
\ \"name\": \"my-test-access-connector\",\r\n \"type\": \"Microsoft.Databricks/accessConnectors\",\r\n
27-
\ \"location\": \"westus\",\r\n \"identity\": {\r\n \"principalId\": \"363fb1ad-4483-4ebe-bef8-85bec9f6efc5\",\r\n
27+
\ \"location\": \"westus\",\r\n \"identity\": {\r\n \"principalId\": \"f62fb0c6-0d58-4e3e-9b09-d07e481d1a92\",\r\n
2828
\ \"tenantId\": \"72f988bf-86f1-41af-91ab-2d7cd011db47\",\r\n \"type\":
2929
\"SystemAssigned\"\r\n },\r\n \"properties\": {\r\n \"provisioningState\":
3030
\"Succeeded\"\r\n },\r\n \"systemData\": {\r\n \"createdBy\": \"[email protected]\",\r\n
31-
\ \"createdByType\": \"User\",\r\n \"createdAt\": \"2025-12-19T19:57:17.0708231+00:00\",\r\n
31+
\ \"createdByType\": \"User\",\r\n \"createdAt\": \"2025-12-20T00:28:48.4344938+00:00\",\r\n
3232
\ \"lastModifiedBy\": \"[email protected]\",\r\n \"lastModifiedByType\":
33-
\"User\",\r\n \"lastModifiedAt\": \"2025-12-19T19:57:17.0708231+00:00\"\r\n
33+
\"User\",\r\n \"lastModifiedAt\": \"2025-12-20T00:28:48.4344938+00:00\"\r\n
3434
\ }\r\n}"
3535
headers:
3636
cache-control:
@@ -40,7 +40,7 @@ interactions:
4040
content-type:
4141
- application/json; charset=utf-8
4242
date:
43-
- Fri, 19 Dec 2025 19:57:18 GMT
43+
- Sat, 20 Dec 2025 00:28:49 GMT
4444
expires:
4545
- '-1'
4646
pragma:
@@ -52,11 +52,11 @@ interactions:
5252
x-content-type-options:
5353
- nosniff
5454
x-ms-operation-identifier:
55-
- tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47,objectId=a70a66b6-f372-4fcc-9f09-6c5e1e64c3dd/westus2/74c3e891-a29e-476d-af56-afdca9bcc050
55+
- tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47,objectId=a70a66b6-f372-4fcc-9f09-6c5e1e64c3dd/westus/25702de4-10eb-4c31-a328-35f6f97b59e9
5656
x-ms-ratelimit-remaining-subscription-resource-requests:
5757
- '99'
5858
x-msedge-ref:
59-
- 'Ref A: 23A7E3A4FC974F7F93F4C9DF590E3FC8 Ref B: CO6AA3150217021 Ref C: 2025-12-19T19:57:16Z'
59+
- 'Ref A: 4310555A16E844379A91F0227437FEC8 Ref B: MWH011020807062 Ref C: 2025-12-20T00:28:48Z'
6060
status:
6161
code: 201
6262
message: Created
@@ -81,13 +81,13 @@ interactions:
8181
body:
8282
string: "{\r\n \"id\": \"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_access_connector000001/providers/Microsoft.Databricks/accessConnectors/my-test-access-connector\",\r\n
8383
\ \"name\": \"my-test-access-connector\",\r\n \"type\": \"Microsoft.Databricks/accessConnectors\",\r\n
84-
\ \"location\": \"westus\",\r\n \"identity\": {\r\n \"principalId\": \"363fb1ad-4483-4ebe-bef8-85bec9f6efc5\",\r\n
84+
\ \"location\": \"westus\",\r\n \"identity\": {\r\n \"principalId\": \"f62fb0c6-0d58-4e3e-9b09-d07e481d1a92\",\r\n
8585
\ \"tenantId\": \"72f988bf-86f1-41af-91ab-2d7cd011db47\",\r\n \"type\":
8686
\"SystemAssigned\"\r\n },\r\n \"properties\": {\r\n \"provisioningState\":
8787
\"Succeeded\"\r\n },\r\n \"systemData\": {\r\n \"createdBy\": \"[email protected]\",\r\n
88-
\ \"createdByType\": \"User\",\r\n \"createdAt\": \"2025-12-19T19:57:17.0708231+00:00\",\r\n
88+
\ \"createdByType\": \"User\",\r\n \"createdAt\": \"2025-12-20T00:28:48.4344938+00:00\",\r\n
8989
\ \"lastModifiedBy\": \"[email protected]\",\r\n \"lastModifiedByType\":
90-
\"User\",\r\n \"lastModifiedAt\": \"2025-12-19T19:57:17.0708231+00:00\"\r\n
90+
\"User\",\r\n \"lastModifiedAt\": \"2025-12-20T00:28:48.4344938+00:00\"\r\n
9191
\ }\r\n}"
9292
headers:
9393
cache-control:
@@ -97,7 +97,7 @@ interactions:
9797
content-type:
9898
- application/json; charset=utf-8
9999
date:
100-
- Fri, 19 Dec 2025 19:57:19 GMT
100+
- Sat, 20 Dec 2025 00:28:50 GMT
101101
expires:
102102
- '-1'
103103
pragma:
@@ -111,7 +111,7 @@ interactions:
111111
x-ms-ratelimit-remaining-subscription-resource-requests:
112112
- '249'
113113
x-msedge-ref:
114-
- 'Ref A: E860528C37B44D48B34B0D90D7C3109C Ref B: MWH011020808031 Ref C: 2025-12-19T19:57:19Z'
114+
- 'Ref A: EF32986489724E4C89747732564109A4 Ref B: MWH011020806031 Ref C: 2025-12-20T00:28:51Z'
115115
status:
116116
code: 200
117117
message: OK
@@ -145,9 +145,9 @@ interactions:
145145
\ },\r\n \"tags\": {\r\n \"key\": \"value\"\r\n },\r\n \"properties\":
146146
{\r\n \"provisioningState\": \"Succeeded\"\r\n },\r\n \"systemData\":
147147
{\r\n \"createdBy\": \"[email protected]\",\r\n \"createdByType\": \"User\",\r\n
148-
\ \"createdAt\": \"2025-12-19T19:57:17.0708231+00:00\",\r\n \"lastModifiedBy\":
148+
\ \"createdAt\": \"2025-12-20T00:28:48.4344938+00:00\",\r\n \"lastModifiedBy\":
149149
\"[email protected]\",\r\n \"lastModifiedByType\": \"User\",\r\n \"lastModifiedAt\":
150-
\"2025-12-19T19:57:20.2029939+00:00\"\r\n }\r\n}"
150+
\"2025-12-20T00:28:51.6436617+00:00\"\r\n }\r\n}"
151151
headers:
152152
cache-control:
153153
- no-cache
@@ -156,7 +156,7 @@ interactions:
156156
content-type:
157157
- application/json; charset=utf-8
158158
date:
159-
- Fri, 19 Dec 2025 19:57:21 GMT
159+
- Sat, 20 Dec 2025 00:28:52 GMT
160160
expires:
161161
- '-1'
162162
pragma:
@@ -168,11 +168,11 @@ interactions:
168168
x-content-type-options:
169169
- nosniff
170170
x-ms-operation-identifier:
171-
- tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47,objectId=a70a66b6-f372-4fcc-9f09-6c5e1e64c3dd/westus/748bf730-8e8b-4a77-97e8-d7064f0d2eb8
171+
- tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47,objectId=a70a66b6-f372-4fcc-9f09-6c5e1e64c3dd/westus/e7a94502-8e50-4591-9432-4072d238e507
172172
x-ms-ratelimit-remaining-subscription-resource-requests:
173173
- '99'
174174
x-msedge-ref:
175-
- 'Ref A: B8C26B3371BF4CBBBE46133E4425C043 Ref B: CO6AA3150219051 Ref C: 2025-12-19T19:57:19Z'
175+
- 'Ref A: 3780E3542A08426697B3EB56D0B64EAD Ref B: MWH011020806040 Ref C: 2025-12-20T00:28:51Z'
176176
status:
177177
code: 200
178178
message: OK
@@ -195,7 +195,7 @@ interactions:
195195
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_access_connector000001/providers/Microsoft.Databricks/accessConnectors?api-version=2025-10-01-preview
196196
response:
197197
body:
198-
string: '{"value":[{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_access_connector000001/providers/Microsoft.Databricks/accessConnectors/my-test-access-connector","name":"my-test-access-connector","type":"Microsoft.Databricks/accessConnectors","location":"westus","identity":{"type":"None"},"tags":{"key":"value"},"properties":{"provisioningState":"Succeeded"},"systemData":{"createdBy":"[email protected]","createdByType":"User","createdAt":"2025-12-19T19:57:17.0708231+00:00","lastModifiedBy":"[email protected]","lastModifiedByType":"User","lastModifiedAt":"2025-12-19T19:57:20.2029939+00:00"}}]}'
198+
string: '{"value":[{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_access_connector000001/providers/Microsoft.Databricks/accessConnectors/my-test-access-connector","name":"my-test-access-connector","type":"Microsoft.Databricks/accessConnectors","location":"westus","identity":{"type":"None"},"tags":{"key":"value"},"properties":{"provisioningState":"Succeeded"},"systemData":{"createdBy":"[email protected]","createdByType":"User","createdAt":"2025-12-20T00:28:48.4344938+00:00","lastModifiedBy":"[email protected]","lastModifiedByType":"User","lastModifiedAt":"2025-12-20T00:28:51.6436617+00:00"}}]}'
199199
headers:
200200
cache-control:
201201
- no-cache
@@ -204,7 +204,7 @@ interactions:
204204
content-type:
205205
- application/json; charset=utf-8
206206
date:
207-
- Fri, 19 Dec 2025 19:57:23 GMT
207+
- Sat, 20 Dec 2025 00:28:54 GMT
208208
expires:
209209
- '-1'
210210
pragma:
@@ -216,11 +216,11 @@ interactions:
216216
x-content-type-options:
217217
- nosniff
218218
x-ms-original-request-ids:
219-
- westus:6f5f333e-a6f1-461b-aee0-96084f6f7ff0
219+
- westus:2dc67e0a-502f-4980-b756-1aaf0a0f8072
220220
x-ms-ratelimit-remaining-subscription-resource-requests:
221221
- '249'
222222
x-msedge-ref:
223-
- 'Ref A: FA7B7C8CDDA24B98ADB3AFDF45CE0343 Ref B: CO6AA3150219049 Ref C: 2025-12-19T19:57:22Z'
223+
- 'Ref A: C4C599AD9FD44AA69B7DE069A4ECD541 Ref B: MWH011020809034 Ref C: 2025-12-20T00:28:54Z'
224224
status:
225225
code: 200
226226
message: OK
@@ -249,9 +249,9 @@ interactions:
249249
\ },\r\n \"tags\": {\r\n \"key\": \"value\"\r\n },\r\n \"properties\":
250250
{\r\n \"provisioningState\": \"Succeeded\"\r\n },\r\n \"systemData\":
251251
{\r\n \"createdBy\": \"[email protected]\",\r\n \"createdByType\": \"User\",\r\n
252-
\ \"createdAt\": \"2025-12-19T19:57:17.0708231+00:00\",\r\n \"lastModifiedBy\":
252+
\ \"createdAt\": \"2025-12-20T00:28:48.4344938+00:00\",\r\n \"lastModifiedBy\":
253253
\"[email protected]\",\r\n \"lastModifiedByType\": \"User\",\r\n \"lastModifiedAt\":
254-
\"2025-12-19T19:57:20.2029939+00:00\"\r\n }\r\n}"
254+
\"2025-12-20T00:28:51.6436617+00:00\"\r\n }\r\n}"
255255
headers:
256256
cache-control:
257257
- no-cache
@@ -260,7 +260,7 @@ interactions:
260260
content-type:
261261
- application/json; charset=utf-8
262262
date:
263-
- Fri, 19 Dec 2025 19:57:23 GMT
263+
- Sat, 20 Dec 2025 00:28:54 GMT
264264
expires:
265265
- '-1'
266266
pragma:
@@ -274,7 +274,7 @@ interactions:
274274
x-ms-ratelimit-remaining-subscription-resource-requests:
275275
- '249'
276276
x-msedge-ref:
277-
- 'Ref A: E3444EAAACC843F89718DD09501E3825 Ref B: MWH011020808062 Ref C: 2025-12-19T19:57:23Z'
277+
- 'Ref A: EA43635000904B84A7FEFA59F1C26F2A Ref B: CO6AA3150217017 Ref C: 2025-12-20T00:28:54Z'
278278
status:
279279
code: 200
280280
message: OK
@@ -306,7 +306,7 @@ interactions:
306306
content-length:
307307
- '0'
308308
date:
309-
- Fri, 19 Dec 2025 19:57:24 GMT
309+
- Sat, 20 Dec 2025 00:28:55 GMT
310310
expires:
311311
- '-1'
312312
pragma:
@@ -318,13 +318,13 @@ interactions:
318318
x-content-type-options:
319319
- nosniff
320320
x-ms-operation-identifier:
321-
- tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47,objectId=a70a66b6-f372-4fcc-9f09-6c5e1e64c3dd/westus2/81b98749-28dc-478c-aa3f-bb124c315bb1
321+
- tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47,objectId=a70a66b6-f372-4fcc-9f09-6c5e1e64c3dd/westus/2c01b049-0200-4112-a83c-cb9c50cbdf51
322322
x-ms-ratelimit-remaining-subscription-deletes:
323323
- '799'
324324
x-ms-ratelimit-remaining-subscription-global-deletes:
325325
- '11999'
326326
x-msedge-ref:
327-
- 'Ref A: 4BD0193DED3C4887A0F734E821211881 Ref B: MWH011020809025 Ref C: 2025-12-19T19:57:24Z'
327+
- 'Ref A: AF49345A57824B7B935EA148654FCADF Ref B: MWH011020808023 Ref C: 2025-12-20T00:28:55Z'
328328
status:
329329
code: 200
330330
message: OK

0 commit comments

Comments
 (0)