Skip to content

Commit b26c21d

Browse files
pscloud: Release stable version 1.0.0 with CLI improvements
- Updated version from 1.0.0b1 to stable 1.0.0 with dual version management - Removed preview flags from all commands and command groups - Fixed parameter consistency across commands (--name/-n standardization) - Updated README documentation to reflect all parameter changes and stable version - Added version management with separate STABLE_VERSION and PREVIEW_VERSION variables
1 parent 82c82ff commit b26c21d

File tree

13 files changed

+26
-33
lines changed

13 files changed

+26
-33
lines changed

src/pscloud/README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ For more details about the Pure Storage Cloud resources please visit [documentat
2727

2828
Install this extension using the below CLI command:
2929
```
30-
az extension add --name pscloud --allow-preview
30+
az extension add --name pscloud
3131
```
3232

3333
### Check the version ###
@@ -82,13 +82,13 @@ This resource represents a block storage array instance, delivered as a service,
8282
To create a Storage Pool, you need to have a virtual network with a delegated subnet to `PureStorage.Block` service.
8383

8484
```bash
85-
az pscloud pool create --resource-group {resource_group} --storage-pool-name {storage_pool_name} --location {location} --zone {availability_zone} --subnet-id {subnet_resource_id} --vnet-id {vnet_resource_id} --provisioned-bandwidth {bandwidth_mb_per_sec} --reservation-id {reservation_resource_id} --tags "{key:value}"
85+
az pscloud pool create --resource-group {resource_group} --name {storage_pool_name} --location {location} --zone {availability_zone} --subnet-name {subnet_name} --vnet-name {vnet_name} --provisioned-bandwidth {bandwidth_mb_per_sec} --reservation-id {reservation_resource_id} --tags "{key:value}"
8686
```
8787

8888
**Required Parameters:**
8989
- `--zone` or `-z`: Azure Availability Zone (1, 2, or 3)
90-
- `--subnet-id`: Full Azure resource ID of the delegated subnet
91-
- `--vnet-id`: Full Azure resource ID of the virtual network
90+
- `--subnet-name`: Name of the delegated subnet
91+
- `--vnet-name`: Name of the virtual network
9292
- `--provisioned-bandwidth`: Bandwidth in MB/s
9393
- `--reservation-id`: Azure resource ID of the Pure Storage Cloud reservation
9494

@@ -99,16 +99,16 @@ az pscloud pool create \
9999
--storage-pool-name myStoragePool \
100100
--location eastus \
101101
--zone 1 \
102-
--subnet-id /subscriptions/12345678-1234-1234-1234-123456789abc/resourceGroups/myResourceGroup/providers/Microsoft.Network/virtualNetworks/myVnet/subnets/mySubnet \
103-
--vnet-id /subscriptions/12345678-1234-1234-1234-123456789abc/resourceGroups/myResourceGroup/providers/Microsoft.Network/virtualNetworks/myVnet \
102+
--subnet-name mySubnet \
103+
--vnet-name myVnet \
104104
--provisioned-bandwidth 100 \
105105
--reservation-id /subscriptions/12345678-1234-1234-1234-123456789abc/providers/PureStorage.Block/reservations/myReservation
106106
```
107107

108108
#### Show a Storage Pool ####
109109

110110
```bash
111-
az pscloud pool show --resource-group {resource_group} --storage-pool-name {storage_pool_name}
111+
az pscloud pool show --resource-group {resource_group} --name {storage_pool_name}
112112
```
113113

114114
#### List Storage Pools ####
@@ -128,7 +128,7 @@ az pscloud pool update --resource-group {resource_group} --name {storage_pool_na
128128
#### Delete a Storage Pool ####
129129

130130
```bash
131-
az pscloud pool delete --resource-group {resource_group} --storage-pool-name {storage_pool_name}
131+
az pscloud pool delete --resource-group {resource_group} --name {storage_pool_name}
132132
```
133133

134134
#### Connect a Storage Pool to AVS ####
@@ -140,7 +140,7 @@ Currently, establishing a connection between a Storage Pool and an Azure VMware
140140
This command provides the health status about the Storage Pool.
141141

142142
```bash
143-
az pscloud pool get-health-status --resource-group {resource_group} --storage-pool-name {storage_pool_name}
143+
az pscloud pool get-health-status --resource-group {resource_group} --name {storage_pool_name}
144144
```
145145

146146
#### Get Storage Pool AVS Status ####

src/pscloud/azext_pscloud/aaz/latest/pscloud/__cmd_group.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command_group(
1515
"pscloud",
16-
is_preview=True,
1716
)
1817
class __CMDGroup(AAZCommandGroup):
1918
"""Manage Pure Storage Block resources

src/pscloud/azext_pscloud/aaz/latest/pscloud/_list.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"pscloud list",
16-
is_preview=True,
1716
)
1817
class List(AAZCommand):
1918
"""List reservations by Azure subscription ID

src/pscloud/azext_pscloud/aaz/latest/pscloud/_show.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"pscloud show",
16-
is_preview=True,
1716
)
1817
class Show(AAZCommand):
1918
"""Get a reservation

src/pscloud/azext_pscloud/aaz/latest/pscloud/pool/__cmd_group.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command_group(
1515
"pscloud pool",
16-
is_preview=True,
1716
)
1817
class __CMDGroup(AAZCommandGroup):
1918
"""Manage Storage Pool

src/pscloud/azext_pscloud/aaz/latest/pscloud/pool/_create.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,12 @@
1313

1414
@register_command(
1515
"pscloud pool create",
16-
is_preview=True,
1716
)
1817
class Create(AAZCommand):
1918
"""Create a storage pool
2019
2120
:example: StoragePools_Create
22-
az pscloud pool create --resource-group rgpurestorage --storage-pool-name storagePoolname --zone 1 --subnet-id /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{vnetName}/subnets/{subnetName} --vnet-id /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{vnetName} --provisioned-bandwidth 100 --reservation-id /subscriptions/{subscriptionId}/providers/PureStorage.Block/reservations/{reservationName} --location eastus
21+
az pscloud pool create --resource-group rgpurestorage --storage-pool-name storagePoolname --zone 1 --subnet-name /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{vnetName}/subnets/{subnetName} --vnet-name /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{vnetName} --provisioned-bandwidth 100 --reservation-id /subscriptions/{subscriptionId}/providers/PureStorage.Block/reservations/{reservationName} --location eastus
2322
"""
2423

2524
_aaz_info = {
@@ -106,13 +105,13 @@ def _build_arguments_schema(cls, *args, **kwargs):
106105

107106
_args_schema = cls._args_schema
108107
_args_schema.subnet_id = AAZStrArg(
109-
options=["--subnet-id"],
108+
options=["--subnet-name"],
110109
arg_group="VnetInjection",
111110
help="Azure resource ID of the Virtual Network subnet where the storage pool will be connected",
112111
required=True,
113112
)
114113
_args_schema.vnet_id = AAZStrArg(
115-
options=["--vnet-id"],
114+
options=["--vnet-name"],
116115
arg_group="VnetInjection",
117116
help="Azure resource ID of the Virtual Network in which the subnet is located",
118117
required=True,

src/pscloud/azext_pscloud/aaz/latest/pscloud/pool/_delete.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"pscloud pool delete",
16-
is_preview=True,
1716
confirmation="Are you sure you want to perform this operation?",
1817
)
1918
class Delete(AAZCommand):

src/pscloud/azext_pscloud/aaz/latest/pscloud/pool/_get_avs_status.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"pscloud pool get-avs-status",
16-
is_preview=True,
1716
)
1817
class GetAvsStatus(AAZCommand):
1918
"""Returns the status of the storage pool connection to AVS
@@ -48,7 +47,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
4847
_args_schema.resource_group = AAZResourceGroupNameArg(
4948
required=True,
5049
)
51-
_args_schema.name = AAZStrArg(
50+
_args_schema.storage_pool_name = AAZStrArg(
5251
options=["-n", "--name"],
5352
help="Name of the storage pool",
5453
required=True,
@@ -112,7 +111,7 @@ def url_parameters(self):
112111
required=True,
113112
),
114113
**self.serialize_url_param(
115-
"storagePoolName", self.ctx.args.name,
114+
"storagePoolName", self.ctx.args.storage_pool_name,
116115
required=True,
117116
),
118117
**self.serialize_url_param(

src/pscloud/azext_pscloud/aaz/latest/pscloud/pool/_get_health_status.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"pscloud pool get-health-status",
16-
is_preview=True,
1716
)
1817
class GetHealthStatus(AAZCommand):
1918
"""Retrieve health metrics of a storage pool
@@ -49,7 +48,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
4948
required=True,
5049
)
5150
_args_schema.storage_pool_name = AAZStrArg(
52-
options=["--storage-pool-name"],
51+
options=["-n", "--name"],
5352
help="Name of the storage pool",
5453
required=True,
5554
id_part="name",
@@ -203,24 +202,24 @@ def _build_schema_on_200(cls):
203202
)
204203

205204
bandwidth_usage = cls._schema_on_200.health.bandwidth_usage
206-
bandwidth_usage.current = AAZIntType(
205+
bandwidth_usage.current = AAZFloatType(
207206
flags={"required": True},
208207
)
209-
bandwidth_usage.max = AAZIntType(
208+
bandwidth_usage.max = AAZFloatType(
210209
flags={"required": True},
211210
)
212-
bandwidth_usage.provisioned = AAZIntType(
211+
bandwidth_usage.provisioned = AAZFloatType(
213212
flags={"required": True},
214213
)
215214

216215
iops_usage = cls._schema_on_200.health.iops_usage
217-
iops_usage.current = AAZIntType(
216+
iops_usage.current = AAZFloatType(
218217
flags={"required": True},
219218
)
220-
iops_usage.max = AAZIntType(
219+
iops_usage.max = AAZFloatType(
221220
flags={"required": True},
222221
)
223-
iops_usage.provisioned = AAZIntType(
222+
iops_usage.provisioned = AAZFloatType(
224223
flags={"required": True},
225224
)
226225

src/pscloud/azext_pscloud/aaz/latest/pscloud/pool/_list.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"pscloud pool list",
16-
is_preview=True,
1716
)
1817
class List(AAZCommand):
1918
"""List storage pools by Azure subscription ID

0 commit comments

Comments
 (0)